VMCreateBareBones.run() - Code Metrics - Inspection of "Merge pull request #462 from Pulsant/vsphere-bareb..." - StackStorm/st2contrib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f419ff...edacad )

by Manas

created 2016-04-14 15:03 UTC

VMCreateBareBones.run() B

↳ Parent: VMCreateBareBones

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	5
dl	0
loc	80
rs	8.0192

How to fix Long Method

# Licensed to the StackStorm, Inc ('StackStorm') under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from pyVmomi import vim

from vmwarelib import inventory
from vmwarelib import checkinputs
from vmwarelib.actions import BaseAction


class VMCreateBareBones(BaseAction):
    def run(self, vm_name, cluster, datastore_cluster,
            datastore, resourcepool, cpu_size, ram_size,
            guestos, version, description):
        # Setup Identifiers for objects
        si = self.si
        si_content = si.RetrieveContent()
        # checkinputs.vm_storage(datastore_cluster, datastore)
        checkinputs.one_of_two_strings(datastore_cluster,
                                       datastore,
                                       "Datastore Cluster or Datastore")

        data_center = self.si_content.rootFolder.childEntity[0]
        cluster = inventory.get_cluster(self.si_content, name=cluster)
        data_store_cluster = inventory.get_datastore_cluster(
            self.si_content,
            name=datastore_cluster)
        # data_store = inventory.get_datastore(self.si_content, name=datastore)
        target_folder = data_center.vmFolder

        # If No Resource Pool issued the Default one for
        # the Cluster will be selected.
        if resourcepool:
            resource_pool = inventory.get_resource_pool(self.si_content,
                                                        name=resourcepool)
        else:
            resource_pool = cluster.resourcePool

        # Config created that is required for DS selection
        # Config is BareBones, CPU RAM no more.
        config = vim.vm.ConfigSpec(name=vm_name,
                                   memoryMB=(ram_size * 1024),
                                   numCPUs=cpu_size,
                                   guestId=guestos,
                                   version=version,
                                   cpuHotAddEnabled=True,
                                   memoryHotAddEnabled=True,
                                   annotation=description)

        # if Datastore cluster is provided it will find the
        # recommended Datastore to store VM files
        if datastore_cluster:
            podsel = vim.storageDrs.PodSelectionSpec()
            podsel.storagePod = data_store_cluster

            storage_spec = vim.storageDrs.StoragePlacementSpec(
                type='create',
                configSpec=config,
                resourcePool=resource_pool,
                podSelectionSpec=podsel,
                folder=target_folder)

            # Create Instance of Storage Resource Manager -
            # This is used to identify a Recommended Datastore from a Cluster
            srm = si_content.storageResourceManager
            results = srm.RecommendDatastores(storageSpec=storage_spec)
            rec_ds = results.recommendations[0].action[0]\
                .relocateSpec.datastore
            datastore_path = '[' + rec_ds.name + '] ' + vm_name
        else:
            # No Datastore Cluster has been offered so using the D
            if datastore:
                datastore_path = '[' + datastore + '] ' + vm_name
            else:
                raise Exception('Error No Storage Data Provided')

        # Now Datastore is known the remaining
        # of VM Config can be setup and added
        vmx_file = vim.vm.FileInfo(logDirectory=None,
                                   snapshotDirectory=None,
                                   suspendDirectory=None,
                                   vmPathName=datastore_path)
        config.files = vmx_file

        # Create task to Build actual Machine
        task = target_folder.CreateVM_Task(config=config, pool=resource_pool)
        self._wait_for_task(task)
        if task.info.state != vim.TaskInfo.State.success:
            raise Exception(task.info.error.msg)

        return {'vm_id': task.info.result._moId}


1			# Licensed to the StackStorm, Inc ('StackStorm') under one or more
2			# contributor license agreements. See the NOTICE file distributed with
3			# this work for additional information regarding copyright ownership.
4			# The ASF licenses this file to You under the Apache License, Version 2.0
5			# (the "License"); you may not use this file except in compliance with
6			# the License. You may obtain a copy of the License at
7			#
8			# http://www.apache.org/licenses/LICENSE-2.0
9			#
10			# Unless required by applicable law or agreed to in writing, software
11			# distributed under the License is distributed on an "AS IS" BASIS,
12			# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13			# See the License for the specific language governing permissions and
14			# limitations under the License.
15
16			from pyVmomi import vim
17
18			from vmwarelib import inventory
19			from vmwarelib import checkinputs
20			from vmwarelib.actions import BaseAction
21
22
23			class VMCreateBareBones(BaseAction):
24			def run(self, vm_name, cluster, datastore_cluster,
25			datastore, resourcepool, cpu_size, ram_size,
26			guestos, version, description):
27			# Setup Identifiers for objects
28			si = self.si
29			si_content = si.RetrieveContent()
30			# checkinputs.vm_storage(datastore_cluster, datastore)
31			checkinputs.one_of_two_strings(datastore_cluster,
32			datastore,
33			"Datastore Cluster or Datastore")
34
35			data_center = self.si_content.rootFolder.childEntity[0]
36			cluster = inventory.get_cluster(self.si_content, name=cluster)
37			data_store_cluster = inventory.get_datastore_cluster(
38			self.si_content,
39			name=datastore_cluster)
40			# data_store = inventory.get_datastore(self.si_content, name=datastore)
41			target_folder = data_center.vmFolder
42
43			# If No Resource Pool issued the Default one for
44			# the Cluster will be selected.
45			if resourcepool:
46			resource_pool = inventory.get_resource_pool(self.si_content,
47			name=resourcepool)
48			else:
49			resource_pool = cluster.resourcePool
50
51			# Config created that is required for DS selection
52			# Config is BareBones, CPU RAM no more.
53			config = vim.vm.ConfigSpec(name=vm_name,
54			memoryMB=(ram_size * 1024),
55			numCPUs=cpu_size,
56			guestId=guestos,
57			version=version,
58			cpuHotAddEnabled=True,
59			memoryHotAddEnabled=True,
60			annotation=description)
61
62			# if Datastore cluster is provided it will find the
63			# recommended Datastore to store VM files
64			if datastore_cluster:
65			podsel = vim.storageDrs.PodSelectionSpec()
66			podsel.storagePod = data_store_cluster
67
68			storage_spec = vim.storageDrs.StoragePlacementSpec(
69			type='create',
70			configSpec=config,
71			resourcePool=resource_pool,
72			podSelectionSpec=podsel,
73			folder=target_folder)
74
75			# Create Instance of Storage Resource Manager -
76			# This is used to identify a Recommended Datastore from a Cluster
77			srm = si_content.storageResourceManager
78			results = srm.RecommendDatastores(storageSpec=storage_spec)
79			rec_ds = results.recommendations[0].action[0]\
80			.relocateSpec.datastore
81			datastore_path = '[' + rec_ds.name + '] ' + vm_name
82			else:
83			# No Datastore Cluster has been offered so using the D
84			if datastore:
85			datastore_path = '[' + datastore + '] ' + vm_name
86			else:
87			raise Exception('Error No Storage Data Provided')
88
89			# Now Datastore is known the remaining
90			# of VM Config can be setup and added
91			vmx_file = vim.vm.FileInfo(logDirectory=None,
92			snapshotDirectory=None,
93			suspendDirectory=None,
94			vmPathName=datastore_path)
95			config.files = vmx_file
96
97			# Create task to Build actual Machine
98			task = target_folder.CreateVM_Task(config=config, pool=resource_pool)
99			self._wait_for_task(task)
100			if task.info.state != vim.TaskInfo.State.success:
101			raise Exception(task.info.error.msg)
102
103			return {'vm_id': task.info.result._moId}
104

StackStorm / st2contrib

Push — master ( f419ff...edacad )

VMCreateBareBones.run() B

Complexity

Size

Duplication

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like