VMAddHDD.run() - Code Metrics - Inspection of "Merge pull request #462 from Pulsant/vsphere-bareb..." - StackStorm/st2contrib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f419ff...edacad )

by Manas

created 2016-04-14 15:03 UTC

VMAddHDD.run() B

↳ Parent: VMAddHDD

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	60
rs	8.3554
cc	5

How to fix Long Method

# Licensed to the StackStorm, Inc ('StackStorm') under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from pyVmomi import vim
import sys

from vmwarelib import inventory
from vmwarelib import checkinputs
from vmwarelib.actions import BaseAction


class VMAddHDD(BaseAction):
    def run(self, vm_id, vm_name, datastore_cluster,
            datastore, disk_size, provision_type):
        # ensure that minimal inputs are provided
        checkinputs.one_of_two_strings(vm_id, vm_name, "ID or Name")

        vm = inventory.get_virtualmachine(self.si_content, vm_id, vm_name)
        spec = vim.vm.ConfigSpec()
        hdd_unit_number = self.get_next_unit_number(vm)
        ctrl_key = self.get_controller_key(vm)

        # Prepare new Disk configuration
        disk_changes = []
        disk_spec = vim.vm.device.VirtualDeviceSpec()
        disk_spec.fileOperation = "create"
        disk_spec.operation = vim.vm.device.VirtualDeviceSpec.Operation.add
        disk_spec.device = vim.vm.device.VirtualDisk()
        disk_spec.device.backing =\
            vim.vm.device.VirtualDisk.FlatVer2BackingInfo()
        disk_spec.device.backing.diskMode = "persistent"

        if provision_type == 'thin':
            disk_spec.device.backing.thinProvisioned = True

        disk_spec.device.unitNumber = hdd_unit_number
        disk_spec.device.capacityInKB = int(disk_size) * 1024 * 1024
        disk_spec.device.controllerKey = ctrl_key

        # If Datastore Cluster is provided attach Disk via that
        if datastore_cluster:
            ds_clust_obj = inventory.get_datastore_cluster(
                self.si_content, name=datastore_cluster)
            disk_changes.append(disk_spec)
            spec.deviceChange = disk_changes
            srm = self.si_content.storageResourceManager

            storage_placement_spec = self.get_storage_placement_spec(
                ds_clust_obj, vm, spec)
            datastores = srm.RecommendDatastores(
                storageSpec=storage_placement_spec)

            if not datastores.recommendations:
                sys.stderr.write('Skipping as No datastore Recommendations')

            add_disk_task = srm.ApplyStorageDrsRecommendation_Task(
                datastores.recommendations[0].key)

        elif datastore:
            datastore_obj = inventory.get_datastore(self.si_content,
                                                    name=datastore)
            disk_spec.device.backing.datastore = datastore_obj
            disk_changes.append(disk_spec)
            spec.deviceChange = disk_changes
            add_disk_task = vm.ReconfigVM_Task(spec)
        else:
            disk_changes.append(disk_spec)
            spec.deviceChange = disk_changes
            add_disk_task = vm.ReconfigVM_Task(spec)

        successfully_added_disk = self._wait_for_task(add_disk_task)
        return {'state': successfully_added_disk}

    def get_storage_placement_spec(self, ds_clust_obj, vm, vm_reconfig_spec):
        storage_placement_spec = vim.storageDrs.StoragePlacementSpec()
        storage_placement_spec.type =\
            vim.storageDrs.StoragePlacementSpec.PlacementType.reconfigure
        storage_placement_spec.configSpec = vm_reconfig_spec
        storage_placement_spec.podSelectionSpec =\
            vim.storageDrs.PodSelectionSpec()
        storage_placement_spec.vm = vm

        vm_pod_cfg = vim.storageDrs.PodSelectionSpec.VmPodConfig()
        vm_pod_cfg.storagePod = ds_clust_obj
        disk_locator = vim.storageDrs.PodSelectionSpec.DiskLocator()
        disk_locator.diskBackingInfo =\
            vm_reconfig_spec.deviceChange[0].device.backing
        vm_pod_cfg.disk = [disk_locator]
        storage_placement_spec.podSelectionSpec.initialVmConfig = [vm_pod_cfg]
        return storage_placement_spec

    def get_next_unit_number(self, vm):
        unit_number = 0
        # Cycle though devices on VM and find
        # entries with attribute "fileName".
        for device in vm.config.hardware.device:
            if hasattr(device.backing, 'fileName'):
                unit_number = int(device.unitNumber) + 1
                # unit number 7 is reserved
                if unit_number == 7:
                    unit_number += 1
        return unit_number

    def get_controller_key(self, vm):
        # 1000 is the default used for hdd controllers
        key = 1000
        for device in vm.config.hardware.device:
            if isinstance(device, vim.vm.device.VirtualSCSIController):
                key = device.key
        return key


1			# Licensed to the StackStorm, Inc ('StackStorm') under one or more
2			# contributor license agreements. See the NOTICE file distributed with
3			# this work for additional information regarding copyright ownership.
4			# The ASF licenses this file to You under the Apache License, Version 2.0
5			# (the "License"); you may not use this file except in compliance with
6			# the License. You may obtain a copy of the License at
7			#
8			# http://www.apache.org/licenses/LICENSE-2.0
9			#
10			# Unless required by applicable law or agreed to in writing, software
11			# distributed under the License is distributed on an "AS IS" BASIS,
12			# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13			# See the License for the specific language governing permissions and
14			# limitations under the License.
15
16			from pyVmomi import vim
17			import sys
18
19			from vmwarelib import inventory
20			from vmwarelib import checkinputs
21			from vmwarelib.actions import BaseAction
22
23
24			class VMAddHDD(BaseAction):
25			def run(self, vm_id, vm_name, datastore_cluster,
26			datastore, disk_size, provision_type):
27			# ensure that minimal inputs are provided
28			checkinputs.one_of_two_strings(vm_id, vm_name, "ID or Name")
29
30			vm = inventory.get_virtualmachine(self.si_content, vm_id, vm_name)
31			spec = vim.vm.ConfigSpec()
32			hdd_unit_number = self.get_next_unit_number(vm)
33			ctrl_key = self.get_controller_key(vm)
34
35			# Prepare new Disk configuration
36			disk_changes = []
37			disk_spec = vim.vm.device.VirtualDeviceSpec()
38			disk_spec.fileOperation = "create"
39			disk_spec.operation = vim.vm.device.VirtualDeviceSpec.Operation.add
40			disk_spec.device = vim.vm.device.VirtualDisk()
41			disk_spec.device.backing =\
42			vim.vm.device.VirtualDisk.FlatVer2BackingInfo()
43			disk_spec.device.backing.diskMode = "persistent"
44
45			if provision_type == 'thin':
46			disk_spec.device.backing.thinProvisioned = True
47
48			disk_spec.device.unitNumber = hdd_unit_number
49			disk_spec.device.capacityInKB = int(disk_size) * 1024 * 1024
50			disk_spec.device.controllerKey = ctrl_key
51
52			# If Datastore Cluster is provided attach Disk via that
53			if datastore_cluster:
54			ds_clust_obj = inventory.get_datastore_cluster(
55			self.si_content, name=datastore_cluster)
56			disk_changes.append(disk_spec)
57			spec.deviceChange = disk_changes
58			srm = self.si_content.storageResourceManager
59
60			storage_placement_spec = self.get_storage_placement_spec(
61			ds_clust_obj, vm, spec)
62			datastores = srm.RecommendDatastores(
63			storageSpec=storage_placement_spec)
64
65			if not datastores.recommendations:
66			sys.stderr.write('Skipping as No datastore Recommendations')
67
68			add_disk_task = srm.ApplyStorageDrsRecommendation_Task(
69			datastores.recommendations[0].key)
70
71			elif datastore:
72			datastore_obj = inventory.get_datastore(self.si_content,
73			name=datastore)
74			disk_spec.device.backing.datastore = datastore_obj
75			disk_changes.append(disk_spec)
76			spec.deviceChange = disk_changes
77			add_disk_task = vm.ReconfigVM_Task(spec)
78			else:
79			disk_changes.append(disk_spec)
80			spec.deviceChange = disk_changes
81			add_disk_task = vm.ReconfigVM_Task(spec)
82
83			successfully_added_disk = self._wait_for_task(add_disk_task)
84			return {'state': successfully_added_disk}
85
86			def get_storage_placement_spec(self, ds_clust_obj, vm, vm_reconfig_spec):
87			storage_placement_spec = vim.storageDrs.StoragePlacementSpec()
88			storage_placement_spec.type =\
89			vim.storageDrs.StoragePlacementSpec.PlacementType.reconfigure
90			storage_placement_spec.configSpec = vm_reconfig_spec
91			storage_placement_spec.podSelectionSpec =\
92			vim.storageDrs.PodSelectionSpec()
93			storage_placement_spec.vm = vm
94
95			vm_pod_cfg = vim.storageDrs.PodSelectionSpec.VmPodConfig()
96			vm_pod_cfg.storagePod = ds_clust_obj
97			disk_locator = vim.storageDrs.PodSelectionSpec.DiskLocator()
98			disk_locator.diskBackingInfo =\
99			vm_reconfig_spec.deviceChange[0].device.backing
100			vm_pod_cfg.disk = [disk_locator]
101			storage_placement_spec.podSelectionSpec.initialVmConfig = [vm_pod_cfg]
102			return storage_placement_spec
103
104			def get_next_unit_number(self, vm):
105			unit_number = 0
106			# Cycle though devices on VM and find
107			# entries with attribute "fileName".
108			for device in vm.config.hardware.device:
109			if hasattr(device.backing, 'fileName'):
110			unit_number = int(device.unitNumber) + 1
111			# unit number 7 is reserved
112			if unit_number == 7:
113			unit_number += 1
114			return unit_number
115
116			def get_controller_key(self, vm):
117			# 1000 is the default used for hdd controllers
118			key = 1000
119			for device in vm.config.hardware.device:
120			if isinstance(device, vim.vm.device.VirtualSCSIController):
121			key = device.key
122			return key
123

StackStorm / st2contrib

Push — master ( f419ff...edacad )

VMAddHDD.run() B

Complexity

Size

Duplication

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like