ApplyBuildPlan.run() - Code Metrics - Inspection of "Merge pull request #382 from jameseggleston/patch-..." - StackStorm/st2contrib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c616a5...008d9e )

by Tomaz

created 2016-05-03 05:55 UTC

ApplyBuildPlan.run() C

↳ Parent: ApplyBuildPlan

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	8
dl	0
loc	51
rs	5.2591
c	1
b	0
f	0

How to fix Long Method

# Licensed to the StackStorm, Inc ('StackStorm') under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from lib.icsp import ICSPBaseActions
import json


class ApplyBuildPlan(ICSPBaseActions):
    def run(self, buildplan_ids, server_data, connection_details=None):
        self.set_connection(connection_details)
        self.get_sessionid()

        # Prepare Endpoint within ICSP API
        endpoint = "/rest/os-deployment-jobs"

        # Prepare Pesonality Data data collection
        pload = {}
        pload['osbpUris'] = []
        pload['failMode'] = None
        pload['serverData'] = []

        for plan in buildplan_ids:
            # Confirm input are integers
            try:
                isinstance(plan, int)
            except:
                raise ValueError("Build plans must be \
                                 Integers (comma seperated)")

            pload["osbpUris"].append("/rest/os-deployment-build-plans/%s"
                                     % (plan))

        for server in server_data:
            data = {}
            pdata = {}
            data['serverUri'] = "/rest/os-deployment-servers/%s" % (server)

            # Prepare server personality Data
            # Initially not including network data Although
            # this can be included later
            # TODO extend variable values to include IP configuration

            if "hostname" in server_data[server]:
                pdata['hostName'] = server_data[server]['hostname']
            if "domain" in server_data[server]:
                pdata['domain'] = server_data[server]['domain']
            if "workgroup" in server_data[server]:
                pdata['workgroup'] = server_data[server]['workgroup']
            data['personalityData'] = pdata

            pload['serverData'].append(data)

        payload = json.dumps(pload)
        try:
            results = self.icsp_post(endpoint, payload)
        except Exception as e:
            raise Exception("Error: %s" % e)

        return {"jobid": self.extract_id(results['uri'])}


1			# Licensed to the StackStorm, Inc ('StackStorm') under one or more
2			# contributor license agreements. See the NOTICE file distributed with
3			# this work for additional information regarding copyright ownership.
4			# The ASF licenses this file to You under the Apache License, Version 2.0
5			# (the "License"); you may not use this file except in compliance with
6			# the License. You may obtain a copy of the License at
7			#
8			# http://www.apache.org/licenses/LICENSE-2.0
9			#
10			# Unless required by applicable law or agreed to in writing, software
11			# distributed under the License is distributed on an "AS IS" BASIS,
12			# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13			# See the License for the specific language governing permissions and
14			# limitations under the License.
15
16			from lib.icsp import ICSPBaseActions
17			import json
18
19
20			class ApplyBuildPlan(ICSPBaseActions):
21			def run(self, buildplan_ids, server_data, connection_details=None):
22			self.set_connection(connection_details)
23			self.get_sessionid()
24
25			# Prepare Endpoint within ICSP API
26			endpoint = "/rest/os-deployment-jobs"
27
28			# Prepare Pesonality Data data collection
29			pload = {}
30			pload['osbpUris'] = []
31			pload['failMode'] = None
32			pload['serverData'] = []
33
34			for plan in buildplan_ids:
35			# Confirm input are integers
36			try:
37			isinstance(plan, int)
38			except:
39			raise ValueError("Build plans must be \
40			Integers (comma seperated)")
41
42			pload["osbpUris"].append("/rest/os-deployment-build-plans/%s"
43			% (plan))
44
45			for server in server_data:
46			data = {}
47			pdata = {}
48			data['serverUri'] = "/rest/os-deployment-servers/%s" % (server)
49
50			# Prepare server personality Data
51			# Initially not including network data Although
52			# this can be included later
53			# TODO extend variable values to include IP configuration
54
55			if "hostname" in server_data[server]:
56			pdata['hostName'] = server_data[server]['hostname']
57			if "domain" in server_data[server]:
58			pdata['domain'] = server_data[server]['domain']
59			if "workgroup" in server_data[server]:
60			pdata['workgroup'] = server_data[server]['workgroup']
61			data['personalityData'] = pdata
62
63			pload['serverData'].append(data)
64
65			payload = json.dumps(pload)
66			try:
67			results = self.icsp_post(endpoint, payload)
68			except Exception as e:
69			raise Exception("Error: %s" % e)
70
71			return {"jobid": self.extract_id(results['uri'])}
72

StackStorm / st2contrib

Push — master ( c616a5...008d9e )

ApplyBuildPlan.run() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like