get_managed_entity() - Code Metrics - Inspection of "Vsphere barebones atomic actions" - StackStorm/st2contrib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#462)

unknown

created 2016-04-01 14:26 UTC

get_managed_entity() F

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	26
rs	2.7581
cc	14

How to fix Complexity

from pyVmomi import vim


def get_managed_entity(content, vimtype, moid=None, name=None):
    container = content.viewManager.CreateContainerView(
        content.rootFolder, [vimtype], True)
    for entity in container.view:
        # verify if this works.
        if moid and entity._moId == moid:
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
            return entity
        elif name and entity.name == name:
            return entity

    #if this area is reached no object has been found
    #if no arguments were passed just return with empty object
    if ((name is None or name == "") and (moid is None or moid == "")):

        return
    #if a name was passed error
    elif (name is not None and name != ""):

        raise Exception("Inventory Error: Unable to Find Object (%s): %s"
                        % (vimtype, name))
    #if a moid was passed error
    elif (moid is not None and moid != ""):

        raise Exception("Inventory Error: Unable to Find Object (%s): %s"
                        % (vimtype, moid))
    #catch all error
    else:
        raise Exception("Inventory Error: No Name or moid provided (%s)"
                        % vimtype)


def get_managed_entities(content, vimtype):
    container = content.viewManager.CreateContainerView(
        content.rootFolder, [vimtype], True)
    return container


def get_datacenter(content, moid=None, name=None):
    return get_managed_entity(content, vim.Datacenter, moid=moid, name=name)


def get_cluster(content, moid=None, name=None):
    return get_managed_entity(content, vim.ClusterComputeResource,
                              moid=moid, name=name)


def get_folder(content, moid=None, name=None):
    return get_managed_entity(content, vim.Folder,
                              moid=moid, name=name)


def get_resource_pool(content, moid=None, name=None):
    return get_managed_entity(content, vim.ResourcePool,
                              moid=moid, name=name)


def get_datastore_cluster(content, moid=None, name=None):
    return get_managed_entity(content, vim.StoragePod,
                              moid=moid, name=name)


def get_datastore(content, moid=None, name=None):
    return get_managed_entity(content, vim.Datastore,
                              moid=moid, name=name)


def get_network(content, moid=None, name=None):
    return get_managed_entity(content, vim.Network,
                              moid=moid, name=name)


def get_virtualmachine(content, moid=None, name=None):
    return get_managed_entity(content, vim.VirtualMachine,
                              moid=moid, name=name)


def get_virtualmachines(content):
    return get_managed_entities(content, vim.VirtualMachine)


def get_task(content, moid=None):
    return get_managed_entity(content, vim.Task,
                              moid=moid, name=None)


1			from pyVmomi import vim
2
3
4			def get_managed_entity(content, vimtype, moid=None, name=None):
5			container = content.viewManager.CreateContainerView(
6			content.rootFolder, [vimtype], True)
7			for entity in container.view:
8			# verify if this works.
9			if moid and entity._moId == moid:
			0 ignored issues – show Coding Style Best Practice introduced 2016-02-19 14:33 UTC by Report Bug Copy Issue Report It seems like `_moId` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
10			return entity
11			elif name and entity.name == name:
12			return entity
13
14			#if this area is reached no object has been found
15			#if no arguments were passed just return with empty object
16			if ((name is None or name == "") and (moid is None or moid == "")):
			0 ignored issues – show Unused Code Coding Style introduced 2016-04-01 14:28 UTC by Report Bug Copy Issue Report There is an unnecessary parenthesis after `if`. Loading history...
17			return
18			#if a name was passed error
19			elif (name is not None and name != ""):
			0 ignored issues – show Unused Code Coding Style introduced 2016-04-01 14:28 UTC by Report Bug Copy Issue Report There is an unnecessary parenthesis after `elif`. Loading history...
20			raise Exception("Inventory Error: Unable to Find Object (%s): %s"
21			% (vimtype, name))
22			#if a moid was passed error
23			elif (moid is not None and moid != ""):
			0 ignored issues – show Unused Code Coding Style introduced 2016-04-01 14:28 UTC by Report Bug Copy Issue Report There is an unnecessary parenthesis after `elif`. Loading history...
24			raise Exception("Inventory Error: Unable to Find Object (%s): %s"
25			% (vimtype, moid))
26			#catch all error
27			else:
28			raise Exception("Inventory Error: No Name or moid provided (%s)"
29			% vimtype)
30
31
32			def get_managed_entities(content, vimtype):
33			container = content.viewManager.CreateContainerView(
34			content.rootFolder, [vimtype], True)
35			return container
36
37
38			def get_datacenter(content, moid=None, name=None):
39			return get_managed_entity(content, vim.Datacenter, moid=moid, name=name)
40
41
42			def get_cluster(content, moid=None, name=None):
43			return get_managed_entity(content, vim.ClusterComputeResource,
44			moid=moid, name=name)
45
46
47			def get_folder(content, moid=None, name=None):
48			return get_managed_entity(content, vim.Folder,
49			moid=moid, name=name)
50
51
52			def get_resource_pool(content, moid=None, name=None):
53			return get_managed_entity(content, vim.ResourcePool,
54			moid=moid, name=name)
55
56
57			def get_datastore_cluster(content, moid=None, name=None):
58			return get_managed_entity(content, vim.StoragePod,
59			moid=moid, name=name)
60
61
62			def get_datastore(content, moid=None, name=None):
63			return get_managed_entity(content, vim.Datastore,
64			moid=moid, name=name)
65
66
67			def get_network(content, moid=None, name=None):
68			return get_managed_entity(content, vim.Network,
69			moid=moid, name=name)
70
71
72			def get_virtualmachine(content, moid=None, name=None):
73			return get_managed_entity(content, vim.VirtualMachine,
74			moid=moid, name=name)
75
76
77			def get_virtualmachines(content):
78			return get_managed_entities(content, vim.VirtualMachine)
79
80
81			def get_task(content, moid=None):
82			return get_managed_entity(content, vim.Task,
83			moid=moid, name=None)
84

StackStorm / st2contrib

Pull Request — master (#462)

get_managed_entity() F

Complexity

Size

Duplication

How to fix Complexity

Complexity

Duplication Side-by-Side

Filter issues like