FormatResultActionTestCase.test_rendering_local_shell_cmd() - Code Metrics - Inspection of "WIP: Chatops related improvements" - StackStorm/st2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2829)

by Lakshmi

created 2016-07-28 00:48 UTC

test_rendering_local_shell_cmd() A

↳ Parent: FormatResultActionTestCase

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
c	0
b	0
f	0
dl	0
loc	10
rs	9.4285

import json
import mock

from st2tests.base import BaseActionTestCase

from format_execution_result import FormatResultAction

__all__ = [
    'FormatResultActionTestCase'
]


class FormatResultActionTestCase(BaseActionTestCase):
    action_cls = FormatResultAction

    def test_rendering_works_remote_shell_cmd(self):
        remote_shell_cmd_execution_model = json.loads(
            self.get_fixture_content('remote_cmd_execution.json')
        )

        action = self.get_action_instance()
        action._get_execution = mock.MagicMock(
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
            return_value=remote_shell_cmd_execution_model
        )
        self.assertTrue(action.run(execution_id='57967f9355fc8c19a96d9e4f'))

    def test_rendering_local_shell_cmd(self):
        local_shell_cmd_execution_model = json.loads(
            self.get_fixture_content('local_cmd_execution.json')
        )

        action = self.get_action_instance()
        action._get_execution = mock.MagicMock(
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
            return_value=local_shell_cmd_execution_model
        )
        self.assertTrue(action.run(execution_id='5799522f55fc8c2d33ac03e0'))


1			import json
2			import mock
3
4			from st2tests.base import BaseActionTestCase
5
6			from format_execution_result import FormatResultAction
7
8			__all__ = [
9			'FormatResultActionTestCase'
10			]
11
12
13			class FormatResultActionTestCase(BaseActionTestCase):
14			action_cls = FormatResultAction
15
16			def test_rendering_works_remote_shell_cmd(self):
17			remote_shell_cmd_execution_model = json.loads(
18			self.get_fixture_content('remote_cmd_execution.json')
19			)
20
21			action = self.get_action_instance()
22			action._get_execution = mock.MagicMock(
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-28 00:54 UTC by Report Bug Copy Issue Report It seems like `_get_execution` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
23			return_value=remote_shell_cmd_execution_model
24			)
25			self.assertTrue(action.run(execution_id='57967f9355fc8c19a96d9e4f'))
26
27			def test_rendering_local_shell_cmd(self):
28			local_shell_cmd_execution_model = json.loads(
29			self.get_fixture_content('local_cmd_execution.json')
30			)
31
32			action = self.get_action_instance()
33			action._get_execution = mock.MagicMock(
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-28 00:54 UTC by Report Bug Copy Issue Report It seems like `_get_execution` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
34			return_value=local_shell_cmd_execution_model
35			)
36			self.assertTrue(action.run(execution_id='5799522f55fc8c2d33ac03e0'))
37

StackStorm / st2

Pull Request — master (#2829)

test_rendering_local_shell_cmd() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like