Completed
Pull Request — master (#2334)
by Edward
06:02
created

st2client.models.MultiColumnTable   B

Complexity

Total Complexity 40

Size/Duplication

Total Lines 136
Duplicated Lines 0 %
Metric Value
wmc 40
dl 0
loc 136
rs 8.2609

How to fix   Complexity   

Complex Class

Complex classes like st2client.models.MultiColumnTable often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

1
# Licensed to the StackStorm, Inc ('StackStorm') under one or more
2
# contributor license agreements.  See the NOTICE file distributed with
3
# this work for additional information regarding copyright ownership.
4
# The ASF licenses this file to You under the Apache License, Version 2.0
5
# (the "License"); you may not use this file except in compliance with
6
# the License.  You may obtain a copy of the License at
7
#
8
#     http://www.apache.org/licenses/LICENSE-2.0
9
#
10
# Unless required by applicable law or agreed to in writing, software
11
# distributed under the License is distributed on an "AS IS" BASIS,
12
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13
# See the License for the specific language governing permissions and
14
# limitations under the License.
15
16
import logging
17
18
from st2client.models import core
19
20
21
LOG = logging.getLogger(__name__)
22
23
24
class RunnerType(core.Resource):
25
    _alias = 'Runner'
26
    _display_name = 'Runner'
27
    _plural = 'RunnerTypes'
28
    _plural_display_name = 'Runners'
29
    _repr_attributes = ['name', 'enabled', 'description']
30
31
32
class Action(core.Resource):
33
    _plural = 'Actions'
34
    _repr_attributes = ['name', 'pack', 'enabled', 'runner_type']
35
36
37
class LiveAction(core.Resource):
38
    _alias = 'Execution'
39
    _display_name = 'Action Execution'
40
    _url_path = 'executions'
41
    _plural = 'ActionExecutions'
42
    _plural_display_name = 'Action executions'
43
    _repr_attributes = ['status', 'action', 'start_timestamp', 'end_timestamp', 'parameters']
44