Conditions | 1 |
Paths | 1 |
Total Lines | 109 |
Code Lines | 103 |
Lines | 0 |
Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
21 | public function testGetDeprecatedFunctionsList12() { |
||
22 | $functions = \code_review::getDeprecatedFunctionsList('1.2'); |
||
23 | $this->assertCount(5, $functions); |
||
24 | $this->assertArrayHasKey('dummy_deprecated_function1', $functions); |
||
25 | $this->assertArrayHasKey('dummy_deprecated_function2', $functions); |
||
26 | $this->assertArrayHasKey('foobardummyclass::deprecatedprivate', $functions); |
||
27 | $this->assertArrayHasKey('foobardummyclass::deprecatedprotected', $functions); |
||
28 | $this->assertArrayHasKey('foobardummyclass::deprecatedpublic', $functions); |
||
29 | |||
30 | $deprecatedFunction1 = $functions['dummy_deprecated_function1']; |
||
31 | $this->assertInstanceOf('CodeReview_Issues_Deprecated', $deprecatedFunction1); |
||
32 | $this->assertInstanceOf('ArrayAccess', $deprecatedFunction1); |
||
33 | $this->assertFalse(is_array($deprecatedFunction1)); |
||
34 | $this->assertArrayHasKey('name', $deprecatedFunction1); |
||
35 | $this->assertArrayHasKey('version', $deprecatedFunction1); |
||
36 | $this->assertArrayHasKey('file', $deprecatedFunction1); |
||
37 | $this->assertArrayHasKey('line', $deprecatedFunction1); |
||
38 | $this->assertArrayHasKey('deprecated', $deprecatedFunction1); |
||
39 | $this->assertArrayHasKey('reason', $deprecatedFunction1); |
||
40 | $this->assertArrayHasKey('fixinfoshort', $deprecatedFunction1); |
||
41 | $this->assertEquals('dummy_deprecated_function1', $deprecatedFunction1['name']); |
||
42 | $this->assertEquals('1.1', $deprecatedFunction1['version']); |
||
43 | $this->assertEquals(true, $deprecatedFunction1['deprecated']); |
||
44 | $this->assertEquals('deprecated', $deprecatedFunction1['reason']); |
||
45 | $this->assertEquals('Remove it', $deprecatedFunction1['fixinfoshort']); |
||
46 | $this->assertEquals("Line " . $deprecatedFunction1['line'] . ":\tFunction call: " |
||
47 | . $deprecatedFunction1['name'] . " (deprecated since 1.1) Remove it", |
||
48 | (string)$deprecatedFunction1); |
||
49 | |||
50 | $deprecatedFunction2 = $functions['dummy_deprecated_function2']; |
||
51 | $this->assertInstanceOf('CodeReview_Issues_Deprecated', $deprecatedFunction2); |
||
52 | $this->assertInstanceOf('ArrayAccess', $deprecatedFunction2); |
||
53 | $this->assertFalse(is_array($deprecatedFunction2)); |
||
54 | $this->assertArrayHasKey('name', $deprecatedFunction2); |
||
55 | $this->assertArrayHasKey('version', $deprecatedFunction2); |
||
56 | $this->assertArrayHasKey('file', $deprecatedFunction2); |
||
57 | $this->assertArrayHasKey('line', $deprecatedFunction2); |
||
58 | $this->assertArrayHasKey('deprecated', $deprecatedFunction2); |
||
59 | $this->assertArrayHasKey('reason', $deprecatedFunction2); |
||
60 | $this->assertArrayHasKey('fixinfoshort', $deprecatedFunction2); |
||
61 | $this->assertEquals('dummy_deprecated_function2', $deprecatedFunction2['name']); |
||
62 | $this->assertEquals('1.2', $deprecatedFunction2['version']); |
||
63 | $this->assertEquals(true, $deprecatedFunction2['deprecated']); |
||
64 | $this->assertEquals('deprecated', $deprecatedFunction2['reason']); |
||
65 | $this->assertEquals(false, $deprecatedFunction2['fixinfoshort']); |
||
66 | $this->assertEquals("Line " . $deprecatedFunction2['line'] . ":\tFunction call: " |
||
67 | . $deprecatedFunction2['name'] . " (deprecated since 1.2)", |
||
68 | (string)$deprecatedFunction2); |
||
69 | |||
70 | $deprecatedFunction3 = $functions['foobardummyclass::deprecatedprivate']; |
||
71 | $this->assertInstanceOf('CodeReview_Issues_Deprecated', $deprecatedFunction3); |
||
72 | $this->assertInstanceOf('ArrayAccess', $deprecatedFunction3); |
||
73 | $this->assertFalse(is_array($deprecatedFunction3)); |
||
74 | $this->assertArrayHasKey('name', $deprecatedFunction3); |
||
75 | $this->assertArrayHasKey('version', $deprecatedFunction3); |
||
76 | $this->assertArrayHasKey('file', $deprecatedFunction3); |
||
77 | $this->assertArrayHasKey('line', $deprecatedFunction3); |
||
78 | $this->assertArrayHasKey('deprecated', $deprecatedFunction3); |
||
79 | $this->assertArrayHasKey('reason', $deprecatedFunction3); |
||
80 | $this->assertArrayHasKey('fixinfoshort', $deprecatedFunction3); |
||
81 | $this->assertEquals('FoobarDummyClass::deprecatedPrivate', $deprecatedFunction3['name']); |
||
82 | $this->assertEquals('1.2', $deprecatedFunction3['version']); |
||
83 | $this->assertEquals(true, $deprecatedFunction3['deprecated']); |
||
84 | $this->assertEquals('deprecated', $deprecatedFunction3['reason']); |
||
85 | $this->assertEquals('Deprecated private class method.', $deprecatedFunction3['fixinfoshort']); |
||
86 | $this->assertEquals("Line " . $deprecatedFunction3['line'] . ":\tFunction call: " |
||
87 | . $deprecatedFunction3['name'] . " (deprecated since 1.2) Deprecated private class method.", |
||
88 | (string)$deprecatedFunction3); |
||
89 | |||
90 | $deprecatedFunction4 = $functions['foobardummyclass::deprecatedprotected']; |
||
91 | $this->assertInstanceOf('CodeReview_Issues_Deprecated', $deprecatedFunction4); |
||
92 | $this->assertInstanceOf('ArrayAccess', $deprecatedFunction4); |
||
93 | $this->assertFalse(is_array($deprecatedFunction4)); |
||
94 | $this->assertArrayHasKey('name', $deprecatedFunction4); |
||
95 | $this->assertArrayHasKey('version', $deprecatedFunction4); |
||
96 | $this->assertArrayHasKey('file', $deprecatedFunction4); |
||
97 | $this->assertArrayHasKey('line', $deprecatedFunction4); |
||
98 | $this->assertArrayHasKey('deprecated', $deprecatedFunction4); |
||
99 | $this->assertArrayHasKey('reason', $deprecatedFunction4); |
||
100 | $this->assertArrayHasKey('fixinfoshort', $deprecatedFunction4); |
||
101 | $this->assertEquals('FoobarDummyClass::deprecatedProtected', $deprecatedFunction4['name']); |
||
102 | $this->assertEquals('1.2', $deprecatedFunction4['version']); |
||
103 | $this->assertEquals(true, $deprecatedFunction4['deprecated']); |
||
104 | $this->assertEquals('deprecated', $deprecatedFunction4['reason']); |
||
105 | $this->assertEquals('Deprecated protected class method.', $deprecatedFunction4['fixinfoshort']); |
||
106 | $this->assertEquals("Line " . $deprecatedFunction4['line'] . ":\tFunction call: " |
||
107 | . $deprecatedFunction4['name'] . " (deprecated since 1.2) Deprecated protected class method.", |
||
108 | (string)$deprecatedFunction4); |
||
109 | |||
110 | $deprecatedFunction5 = $functions['foobardummyclass::deprecatedpublic']; |
||
111 | $this->assertInstanceOf('CodeReview_Issues_Deprecated', $deprecatedFunction5); |
||
112 | $this->assertInstanceOf('ArrayAccess', $deprecatedFunction5); |
||
113 | $this->assertFalse(is_array($deprecatedFunction5)); |
||
114 | $this->assertArrayHasKey('name', $deprecatedFunction5); |
||
115 | $this->assertArrayHasKey('version', $deprecatedFunction5); |
||
116 | $this->assertArrayHasKey('file', $deprecatedFunction5); |
||
117 | $this->assertArrayHasKey('line', $deprecatedFunction5); |
||
118 | $this->assertArrayHasKey('deprecated', $deprecatedFunction5); |
||
119 | $this->assertArrayHasKey('reason', $deprecatedFunction5); |
||
120 | $this->assertArrayHasKey('fixinfoshort', $deprecatedFunction5); |
||
121 | $this->assertEquals('FoobarDummyClass::deprecatedPublic', $deprecatedFunction5['name']); |
||
122 | $this->assertEquals('1.1', $deprecatedFunction5['version']); |
||
123 | $this->assertEquals(true, $deprecatedFunction5['deprecated']); |
||
124 | $this->assertEquals('deprecated', $deprecatedFunction5['reason']); |
||
125 | $this->assertEquals('Deprecated public class method.', $deprecatedFunction5['fixinfoshort']); |
||
126 | $this->assertEquals("Line " . $deprecatedFunction5['line'] . ":\tFunction call: " |
||
127 | . $deprecatedFunction5['name'] . " (deprecated since 1.1) Deprecated public class method.", |
||
128 | (string)$deprecatedFunction5); |
||
129 | } |
||
130 | |||
216 |