CodeReviewConfig - Code Metrics - Inspection of "New scrutinizer config and updated tests for new c..." - Srokap/code_review - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (486a28)

by Paweł

created 2016-05-15 12:57 UTC

CodeReviewConfig A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	157
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

39.06%

Importance

Changes	3
Bugs	0	Features	2

Metric	Value
c	3
b	0
f	2
dl	0
loc	157
rs	10
ccs	25
cts	64
cp	0.3906
wmc	22
lcom	1
cbo	1

13 Methods

Rating	Name	Size	Complexity
A	__construct()	3	1
A	__get()	3	1
A	getOption()	3	2
A	__set()	3	1
C	getPluginIds()	32	8
A	parseInput()	16	1
A	isFixProblemsEnabled()	3	1
A	getMaxVersion()	7	2
A	getSubPath()	3	1
A	isIncludeDisabledPluginsEnabled()	3	1
A	isSkipInactivePluginsEnabled()	3	1
A	isDeprecatedFunctionsTestEnabled()	3	1
A	isPrivateFunctionsTestEnabled()	3	1

<?php
/**
 * Simple configuration container handling basic options parsing nad providing convenient methods.
 */
class CodeReviewConfig {
namespace YourVendor;

class YourClass { }

	const T_PLUGINS_ALL = 0;
	const T_PLUGINS_ACTIVE = 1;
	const T_PLUGINS_INACTIVE = 2;

	/**
	 * @var array
	 */
	protected $options = array();

	/**
	 * @param array $options
	 */
	public function __construct(array $options = array()) {
		$this->options = (array)$options;
	}

	/**
	 * @param $key
	 * @return mixed
	 */
	public function __get($key) {
		return $this->options[$key];
	}

	/**
	 * @param      $key
	 * @param null $default
	 * @return null
	 */
	public function getOption($key, $default = null) {
		return isset($this->options[$key]) ? $this->options[$key] : $default;
	}

	/**
	 * @param $key
	 * @param $value
	 */
	public function __set($key, $value) {
		$this->options[$key] = $value;
	}

	/**
	 * @param $type
	 * @return array
	 */
	public function getPluginIds($type) {
		$pluginsDirs = false;

		$config = code_review::getConfig();

		switch ($type) {
			case self::T_PLUGINS_INACTIVE:
				$pluginsDirs = $this->getPluginIds(self::T_PLUGINS_ALL);
				$actives = call_user_func($config['plugins_getter'], 'active');
				foreach ($actives as $plugin) {
					if ($plugin instanceof ElggPlugin) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
						$pluginsDirs = array_diff($pluginsDirs, array($plugin->getID()));
					} else {
						$pluginsDirs = array_diff($pluginsDirs, array($plugin));
					}
				}
				break;
			case self::T_PLUGINS_ACTIVE:
				$pluginsDirs = call_user_func($config['plugins_getter'], 'active');
				foreach ($pluginsDirs as $key => $plugin) {
					if ($plugin instanceof ElggPlugin) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
						$pluginsDirs[$key] = $plugin->getID();
					}
				}
				break;
			case self::T_PLUGINS_ALL:
				$pluginsDirs = code_review::getPluginDirsInDir($config['pluginspath']);
				break;

		}
		return $pluginsDirs;
	}

	/*
	 * Shorthand methods
	 */

	/**
	 * @param array $vars
	 */
	public function parseInput(array $vars) {

		//sanitize provided path
		$subPath = elgg_extract('subpath', $vars, '/');
		$subPath = trim($subPath, '/\\');
		$subPath = str_replace('\\', '/', $subPath);
		$subPath = str_replace('..', '', $subPath);
		$subPath = $subPath . '/';

		$this->subPath = $subPath;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$this->maxVersion = elgg_extract('version', $vars);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$this->includeDisabledPlugins = elgg_extract('include_disabled_plugins', $vars, false);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$this->findDeprecatedFunctions = elgg_extract('find_deprecated_functions', $vars, true);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$this->findPrivateFunctions = elgg_extract('find_private_functions', $vars, true);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$this->fixProblems = elgg_extract('fix_problems', $vars);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
	}

	/**
	 * @return bool
	 */
	public function isFixProblemsEnabled() {
		return (bool)$this->getOption('fixProblems', false);
	}

	/**
	 * @return string
	 */
	public function getMaxVersion() {
		if (!$this->maxVersion) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			//TODO decouple Elgg core dependency
			return elgg_get_version(true);
		}
		return $this->maxVersion;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
	}

	/**
	 * @return string
	 */
	public function getSubPath() {
		return (string)$this->subPath;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
	}

	/**
	 * @return bool
	 */
	public function isIncludeDisabledPluginsEnabled() {
		return (bool)$this->getOption('includeDisabledPlugins', false);
	}

	/**
	 * @return bool
	 */
	public function isSkipInactivePluginsEnabled() {
		return !$this->isIncludeDisabledPluginsEnabled();
	}

	/**
	 * @return bool
	 */
	public function isDeprecatedFunctionsTestEnabled() {
		return (bool)$this->getOption('findDeprecatedFunctions', true);
	}

	/**
	 * @return bool
	 */
	public function isPrivateFunctionsTestEnabled() {
		return (bool)$this->getOption('findPrivateFunctions', true);
	}
}

1		<?php
2		/**
3		* Simple configuration container handling basic options parsing nad providing convenient methods.
4		*/
5		class CodeReviewConfig {
		0 ignored issues – show Coding Style Compatibility introduced 2016-05-15 12:57 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6
7		const T_PLUGINS_ALL = 0;
8		const T_PLUGINS_ACTIVE = 1;
9		const T_PLUGINS_INACTIVE = 2;
10
11		/**
12		* @var array
13		*/
14		protected $options = array();
15
16		/**
17		* @param array $options
18		*/
19	3	public function __construct(array $options = array()) {
20	3	$this->options = (array)$options;
21	3	}
22
23		/**
24		* @param $key
25		* @return mixed
26		*/
27		public function __get($key) {
28		return $this->options[$key];
29		}
30
31		/**
32		* @param $key
33		* @param null $default
34		* @return null
35		*/
36	2	public function getOption($key, $default = null) {
37	2	return isset($this->options[$key]) ? $this->options[$key] : $default;
38		}
39
40		/**
41		* @param $key
42		* @param $value
43		*/
44		public function __set($key, $value) {
45		$this->options[$key] = $value;
46		}
47
48		/**
49		* @param $type
50		* @return array
51		*/
52	1	public function getPluginIds($type) {
53	1	$pluginsDirs = false;
54
55	1	$config = code_review::getConfig();
56
57		switch ($type) {
58	1	case self::T_PLUGINS_INACTIVE:
59	1	$pluginsDirs = $this->getPluginIds(self::T_PLUGINS_ALL);
60	1	$actives = call_user_func($config['plugins_getter'], 'active');
61	1	foreach ($actives as $plugin) {
62	1	if ($plugin instanceof ElggPlugin) {
		1 ignored issue – show Bug introduced 2016-05-15 12:57 UTC by Report Bug Copy Issue Report The class `ElggPlugin` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
63		$pluginsDirs = array_diff($pluginsDirs, array($plugin->getID()));
64		} else {
65	1	$pluginsDirs = array_diff($pluginsDirs, array($plugin));
66		}
67	1	}
68	1	break;
69	1	case self::T_PLUGINS_ACTIVE:
70		$pluginsDirs = call_user_func($config['plugins_getter'], 'active');
71		foreach ($pluginsDirs as $key => $plugin) {
72		if ($plugin instanceof ElggPlugin) {
		1 ignored issue – show Bug introduced 2016-05-15 12:57 UTC by Report Bug Copy Issue Report The class `ElggPlugin` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
73		$pluginsDirs[$key] = $plugin->getID();
74		}
75		}
76		break;
77	1	case self::T_PLUGINS_ALL:
78	1	$pluginsDirs = code_review::getPluginDirsInDir($config['pluginspath']);
79	1	break;
80
81		}
82	1	return $pluginsDirs;
83		}
84
85		/*
86		* Shorthand methods
87		*/
88
89		/**
90		* @param array $vars
91		*/
92		public function parseInput(array $vars) {
93
94		//sanitize provided path
95		$subPath = elgg_extract('subpath', $vars, '/');
96		$subPath = trim($subPath, '/\\');
97		$subPath = str_replace('\\', '/', $subPath);
98		$subPath = str_replace('..', '', $subPath);
99		$subPath = $subPath . '/';
100
101		$this->subPath = $subPath;
		0 ignored issues – show Documentation introduced 2016-05-15 12:57 UTC by Report Bug Copy Issue Report The property `subPath` does not exist on `object<CodeReviewConfig>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
102		$this->maxVersion = elgg_extract('version', $vars);
		0 ignored issues – show Documentation introduced 2016-05-15 12:57 UTC by Report Bug Copy Issue Report The property `maxVersion` does not exist on `object<CodeReviewConfig>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
103		$this->includeDisabledPlugins = elgg_extract('include_disabled_plugins', $vars, false);
		0 ignored issues – show Documentation introduced 2016-05-15 12:57 UTC by Report Bug Copy Issue Report The property `includeDisabledPlugins` does not exist on `object<CodeReviewConfig>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
104		$this->findDeprecatedFunctions = elgg_extract('find_deprecated_functions', $vars, true);
		0 ignored issues – show Documentation introduced 2016-05-15 12:57 UTC by Report Bug Copy Issue Report The property `findDeprecatedFunctions` does not exist on `object<CodeReviewConfig>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
105		$this->findPrivateFunctions = elgg_extract('find_private_functions', $vars, true);
		0 ignored issues – show Documentation introduced 2016-05-15 12:57 UTC by Report Bug Copy Issue Report The property `findPrivateFunctions` does not exist on `object<CodeReviewConfig>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
106		$this->fixProblems = elgg_extract('fix_problems', $vars);
		0 ignored issues – show Documentation introduced 2016-05-15 12:57 UTC by Report Bug Copy Issue Report The property `fixProblems` does not exist on `object<CodeReviewConfig>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
107		}
108
109		/**
110		* @return bool
111		*/
112		public function isFixProblemsEnabled() {
113		return (bool)$this->getOption('fixProblems', false);
114		}
115
116		/**
117		* @return string
118		*/
119		public function getMaxVersion() {
120		if (!$this->maxVersion) {
		0 ignored issues – show Documentation introduced 2016-05-15 12:57 UTC by Report Bug Copy Issue Report The property `maxVersion` does not exist on `object<CodeReviewConfig>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
121		//TODO decouple Elgg core dependency
122		return elgg_get_version(true);
123		}
124		return $this->maxVersion;
		0 ignored issues – show Documentation introduced 2016-05-15 12:57 UTC by Report Bug Copy Issue Report The property `maxVersion` does not exist on `object<CodeReviewConfig>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
125		}
126
127		/**
128		* @return string
129		*/
130		public function getSubPath() {
131		return (string)$this->subPath;
		0 ignored issues – show Documentation introduced 2016-05-15 12:57 UTC by Report Bug Copy Issue Report The property `subPath` does not exist on `object<CodeReviewConfig>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
132		}
133
134		/**
135		* @return bool
136		*/
137	2	public function isIncludeDisabledPluginsEnabled() {
138	2	return (bool)$this->getOption('includeDisabledPlugins', false);
139		}
140
141		/**
142		* @return bool
143		*/
144	2	public function isSkipInactivePluginsEnabled() {
145	2	return !$this->isIncludeDisabledPluginsEnabled();
146		}
147
148		/**
149		* @return bool
150		*/
151		public function isDeprecatedFunctionsTestEnabled() {
152		return (bool)$this->getOption('findDeprecatedFunctions', true);
153		}
154
155		/**
156		* @return bool
157		*/
158		public function isPrivateFunctionsTestEnabled() {
159		return (bool)$this->getOption('findPrivateFunctions', true);
160		}
161		}

Srokap / code_review

Branch — master (486a28)

CodeReviewConfig A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

13 Methods

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like