CodeReviewPhpFileParserTest::testArrayAndIteratorInterfaces() - Code Metrics - Inspection of "New scrutinizer config and updated tests for new c..." - Srokap/code_review - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 612575...486a28 )

by Paweł

created 2016-05-15 12:54 UTC

testArrayAndIteratorInterfaces() B

↳ Parent: CodeReviewPhpFileParserTest

Complexity

Conditions	5
Paths	6

Size

Total Lines	27
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	5
eloc	16
c	2
b	0
f	0
nc	6
nop	0
dl	0
loc	27
rs	8.439

<?php
class CodeReviewPhpFileParserTest extends PHPUnit_Framework_TestCase {
namespace YourVendor;

class YourClass { }

	public function testNotExistingFile() {
		$fileName = '/not/existing/file/path/to/php/file.php';
		$this->setExpectedException('CodeReview_IOException', "File $fileName does not exists");
		new PhpFileParser($fileName);
	}

	public function testNotAFile() {
		$fileName = dirname(__FILE__);//just a path to directory
		$this->setExpectedException('CodeReview_IOException', "$fileName must be a file");
		new PhpFileParser($fileName);
	}

	/**
	 * @requires PHP 5.3
	 */
	public function testUnserializeInternalErrorNoFileName() {
		$fileName = dirname(__FILE__) . '/test_files/php/input/sample1.php';
		$tokens = new PhpFileParser($fileName);

		$reflection = new ReflectionClass($tokens);
		$reflection_property = $reflection->getProperty('fileName');
		$reflection_property->setAccessible(true);
		$reflection_property->setValue($tokens, null);

		$this->setExpectedException('LogicException', "Missing file's path. Looks like severe internal error.");

		$serializedTokens = serialize($tokens);
		unserialize($serializedTokens);
	}

	/**
	 * @requires PHP 5.3
	 */
	public function testUnserializeInternalErrorBadFileName() {
		$fileName = dirname(__FILE__) . '/test_files/php/input/sample1.php';
		$badPath = dirname(__FILE__) . '/test_files/php/input/not_existing_file.php';
		$tokens = new PhpFileParser($fileName);

		$reflection = new ReflectionClass($tokens);
		$reflection_property = $reflection->getProperty('fileName');
		$reflection_property->setAccessible(true);
		$reflection_property->setValue($tokens, $badPath);

		$this->setExpectedException('CodeReview_IOException', "File $badPath does not exists");

		$serializedTokens = serialize($tokens);
		unserialize($serializedTokens);
	}

	/**
	 * @requires PHP 5.3
	 */
	public function testUnserializeInternalErrorNoSha1() {
		$fileName = dirname(__FILE__) . '/test_files/php/input/sample1.php';
		$tokens = new PhpFileParser($fileName);

		$reflection = new ReflectionClass($tokens);
		$reflection_property = $reflection->getProperty('sha1hash');
		$reflection_property->setAccessible(true);
		$reflection_property->setValue($tokens, null);

		$this->setExpectedException('LogicException', "Missing file's SHA1 hash. Looks like severe internal error.");

		$serializedTokens = serialize($tokens);
		unserialize($serializedTokens);
	}

	public function testSerializationDataPreserve() {
		$tokens = new PhpFileParser(__FILE__);
		$serializedTokens = serialize($tokens);
		$unserializedTokens = unserialize($serializedTokens);
		$this->assertEquals($tokens, $unserializedTokens);
	}

	/**
	 * @return array
	 */
	private function getTestsPhpFiles() {
		$tests = array(
			'sample1',
			'sample1',
		);
		$result = array();
		$dir = dirname(__FILE__) . '/test_files/php/';
		foreach ($tests as $test) {
			$result[$test] = array(
				$dir . 'input/' . $test . '.php',
				$dir . 'output/' . $test . '.php',
			);
		}
		return $result;
	}

	public function testSerializationOutput() {
		$tests = $this->getTestsPhpFiles();
		foreach ($tests as $test) {
			list($inPath, ) = $test;
			$tokens = new PhpFileParser($inPath);

			$serializedClass = serialize($tokens);
			$this->assertTrue(is_string($serializedClass));
			$this->assertTrue(strlen($serializedClass) > 0);

			$actual = unserialize($serializedClass);
			$expected = new PhpFileParser($inPath);

			$this->assertEquals($expected, $actual);
		}
	}

	public function testSourcePreserve() {
		$tests = $this->getTestsPhpFiles();
		foreach ($tests as $test) {
			list($inPath, ) = $test;
			$tokens = new PhpFileParser($inPath);

			$actual = $tokens->exportPhp();

			$this->assertTrue(is_string($actual));
			$this->assertTrue(strlen($actual) > 0);

			$expected = file_get_contents($inPath);

			$this->assertEquals($expected, $actual);
		}
	}

	public function testArrayAndIteratorInterfaces() {
		$tests = $this->getTestsPhpFiles();
		foreach ($tests as $test) {
			list($inPath, ) = $test;

			$tokens = new PhpFileParser($inPath);

			//testing repeated iteration and isset
			foreach (array(1,2) as $i) {
				$result = array();
				foreach ($tokens as $key => $token) {
					$result[] = array(isset($tokens[$key - 1]), isset($tokens[$key]), isset($tokens[$key + 1]));
				}

				$this->assertTrue(count($result) > 2);
				$first = array_shift($result);
				$this->assertEquals(array(false, true, true), $first);
				$last = array_pop($result);
				$this->assertEquals(array(true, true, false), $last);

				foreach ($result as $row) {
					$this->assertEquals(array(true, true, true), $row);
				}
			}

		}
	}

	public function testSerializationFileModifiedDetection() {
		$tests = $this->getTestsPhpFiles();
		foreach ($tests as $test) {
			list($inPath, ) = $test;

			$content = file_get_contents($inPath);
			$this->assertNotEmpty($content);

			$tmpPath = tempnam(sys_get_temp_dir(), 'phpfileparsertest');

			$this->assertNotEquals(file_put_contents($tmpPath, $content), false);

			$tokens = new PhpFileParser($tmpPath);
			$serializedTokens = serialize($tokens);

			//modify file
			$this->assertNotEquals(file_put_contents($tmpPath, 'modified' . $content), false);

//			$this->setExpectedException('CodeReview_IOException');

			try {
				//this shall fail
				unserialize($serializedTokens);
			} catch (CodeReview_IOException $e) {
				$this->assertEquals("The file on disk has changed and this PhpFileParser class instance is no longer valid for use. Please create fresh instance.", $e->getMessage());
				continue;
			}
			$this->fail("Expected CodeReview_IOException to be thrown!");
		}
	}
}

1			<?php
2			class CodeReviewPhpFileParserTest extends PHPUnit_Framework_TestCase {
			0 ignored issues – show Coding Style Compatibility introduced 2016-05-15 12:57 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
3
4			public function testNotExistingFile() {
5			$fileName = '/not/existing/file/path/to/php/file.php';
6			$this->setExpectedException('CodeReview_IOException', "File $fileName does not exists");
7			new PhpFileParser($fileName);
8			}
9
10			public function testNotAFile() {
11			$fileName = dirname(__FILE__);//just a path to directory
12			$this->setExpectedException('CodeReview_IOException', "$fileName must be a file");
13			new PhpFileParser($fileName);
14			}
15
16			/**
17			* @requires PHP 5.3
18			*/
19			public function testUnserializeInternalErrorNoFileName() {
20			$fileName = dirname(__FILE__) . '/test_files/php/input/sample1.php';
21			$tokens = new PhpFileParser($fileName);
22
23			$reflection = new ReflectionClass($tokens);
24			$reflection_property = $reflection->getProperty('fileName');
25			$reflection_property->setAccessible(true);
26			$reflection_property->setValue($tokens, null);
27
28			$this->setExpectedException('LogicException', "Missing file's path. Looks like severe internal error.");
29
30			$serializedTokens = serialize($tokens);
31			unserialize($serializedTokens);
32			}
33
34			/**
35			* @requires PHP 5.3
36			*/
37			public function testUnserializeInternalErrorBadFileName() {
38			$fileName = dirname(__FILE__) . '/test_files/php/input/sample1.php';
39			$badPath = dirname(__FILE__) . '/test_files/php/input/not_existing_file.php';
40			$tokens = new PhpFileParser($fileName);
41
42			$reflection = new ReflectionClass($tokens);
43			$reflection_property = $reflection->getProperty('fileName');
44			$reflection_property->setAccessible(true);
45			$reflection_property->setValue($tokens, $badPath);
46
47			$this->setExpectedException('CodeReview_IOException', "File $badPath does not exists");
48
49			$serializedTokens = serialize($tokens);
50			unserialize($serializedTokens);
51			}
52
53			/**
54			* @requires PHP 5.3
55			*/
56			public function testUnserializeInternalErrorNoSha1() {
57			$fileName = dirname(__FILE__) . '/test_files/php/input/sample1.php';
58			$tokens = new PhpFileParser($fileName);
59
60			$reflection = new ReflectionClass($tokens);
61			$reflection_property = $reflection->getProperty('sha1hash');
62			$reflection_property->setAccessible(true);
63			$reflection_property->setValue($tokens, null);
64
65			$this->setExpectedException('LogicException', "Missing file's SHA1 hash. Looks like severe internal error.");
66
67			$serializedTokens = serialize($tokens);
68			unserialize($serializedTokens);
69			}
70
71			public function testSerializationDataPreserve() {
72			$tokens = new PhpFileParser(__FILE__);
73			$serializedTokens = serialize($tokens);
74			$unserializedTokens = unserialize($serializedTokens);
75			$this->assertEquals($tokens, $unserializedTokens);
76			}
77
78			/**
79			* @return array
80			*/
81			private function getTestsPhpFiles() {
82			$tests = array(
83			'sample1',
84			'sample1',
85			);
86			$result = array();
87			$dir = dirname(__FILE__) . '/test_files/php/';
88			foreach ($tests as $test) {
89			$result[$test] = array(
90			$dir . 'input/' . $test . '.php',
91			$dir . 'output/' . $test . '.php',
92			);
93			}
94			return $result;
95			}
96
97			public function testSerializationOutput() {
98			$tests = $this->getTestsPhpFiles();
99			foreach ($tests as $test) {
100			list($inPath, ) = $test;
101			$tokens = new PhpFileParser($inPath);
102
103			$serializedClass = serialize($tokens);
104			$this->assertTrue(is_string($serializedClass));
105			$this->assertTrue(strlen($serializedClass) > 0);
106
107			$actual = unserialize($serializedClass);
108			$expected = new PhpFileParser($inPath);
109
110			$this->assertEquals($expected, $actual);
111			}
112			}
113
114			public function testSourcePreserve() {
115			$tests = $this->getTestsPhpFiles();
116			foreach ($tests as $test) {
117			list($inPath, ) = $test;
118			$tokens = new PhpFileParser($inPath);
119
120			$actual = $tokens->exportPhp();
121
122			$this->assertTrue(is_string($actual));
123			$this->assertTrue(strlen($actual) > 0);
124
125			$expected = file_get_contents($inPath);
126
127			$this->assertEquals($expected, $actual);
128			}
129			}
130
131			public function testArrayAndIteratorInterfaces() {
132			$tests = $this->getTestsPhpFiles();
133			foreach ($tests as $test) {
134			list($inPath, ) = $test;
135
136			$tokens = new PhpFileParser($inPath);
137
138			//testing repeated iteration and isset
139			foreach (array(1,2) as $i) {
140			$result = array();
141			foreach ($tokens as $key => $token) {
142			$result[] = array(isset($tokens[$key - 1]), isset($tokens[$key]), isset($tokens[$key + 1]));
143			}
144
145			$this->assertTrue(count($result) > 2);
146			$first = array_shift($result);
147			$this->assertEquals(array(false, true, true), $first);
148			$last = array_pop($result);
149			$this->assertEquals(array(true, true, false), $last);
150
151			foreach ($result as $row) {
152			$this->assertEquals(array(true, true, true), $row);
153			}
154			}
155
156			}
157			}
158
159			public function testSerializationFileModifiedDetection() {
160			$tests = $this->getTestsPhpFiles();
161			foreach ($tests as $test) {
162			list($inPath, ) = $test;
163
164			$content = file_get_contents($inPath);
165			$this->assertNotEmpty($content);
166
167			$tmpPath = tempnam(sys_get_temp_dir(), 'phpfileparsertest');
168
169			$this->assertNotEquals(file_put_contents($tmpPath, $content), false);
170
171			$tokens = new PhpFileParser($tmpPath);
172			$serializedTokens = serialize($tokens);
173
174			//modify file
175			$this->assertNotEquals(file_put_contents($tmpPath, 'modified' . $content), false);
176
177			// $this->setExpectedException('CodeReview_IOException');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-15 12:57 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
178			try {
179			//this shall fail
180			unserialize($serializedTokens);
181			} catch (CodeReview_IOException $e) {
182			$this->assertEquals("The file on disk has changed and this PhpFileParser class instance is no longer valid for use. Please create fresh instance.", $e->getMessage());
183			continue;
184			}
185			$this->fail("Expected CodeReview_IOException to be thrown!");
186			}
187			}
188			}

Srokap / code_review

Push — master ( 612575...486a28 )

testArrayAndIteratorInterfaces() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like