PublicKeyCredentialRpEntity::getId() - Code Metrics - Inspection of "First FIDO2 classes added and FIDO classes moved t..." - Spomky-Labs/u2f-php - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 104856...f1eb38 )

by Florent

created 2018-05-05 08:39 UTC

PublicKeyCredentialRpEntity::getId() A

↳ Parent: PublicKeyCredentialRpEntity

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2018 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace U2FAuthentication\Fido2;

class PublicKeyCredentialRpEntity extends PublicKeyCredentialEntity
{
    /**
     * @var null|string
     */
    private $id;

    /**
     * PublicKeyCredentialRpEntity constructor.
     * @param string      $name
     * @param null|string $icon
     * @param null|string $id
     */
    public function __construct(string $name, ?string $icon, ?string $id)
    {
        parent::__construct($name, $icon);
        $this->id = $id;
    }

    /**
     * @return string
     */
    public function getId(): string
    {
        return $this->id;

    }

    /**
     * {@inheritdoc}
     */
    public function jsonSerialize(): array
    {
        $json = parent::jsonSerialize();
        if ($this->id) {
            $json['id'] = $this->id;
        }

        return $json;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* The MIT License (MIT)
7			*
8			* Copyright (c) 2018 Spomky-Labs
9			*
10			* This software may be modified and distributed under the terms
11			* of the MIT license. See the LICENSE file for details.
12			*/
13
14			namespace U2FAuthentication\Fido2;
15
16			class PublicKeyCredentialRpEntity extends PublicKeyCredentialEntity
17			{
18			/**
19			* @var null\|string
20			*/
21			private $id;
22
23			/**
24			* PublicKeyCredentialRpEntity constructor.
25			* @param string $name
26			* @param null\|string $icon
27			* @param null\|string $id
28			*/
29			public function __construct(string $name, ?string $icon, ?string $id)
30			{
31			parent::__construct($name, $icon);
32			$this->id = $id;
33			}
34
35			/**
36			* @return string
37			*/
38			public function getId(): string
39			{
40			return $this->id;
			0 ignored issues – show Bug Best Practice introduced 2018-05-05 08:41 UTC by Report Bug Copy Issue Report The expression `return $this->id` could return the type `null` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
41			}
42
43			/**
44			* {@inheritdoc}
45			*/
46			public function jsonSerialize(): array
47			{
48			$json = parent::jsonSerialize();
49			if ($this->id) {
50			$json['id'] = $this->id;
51			}
52
53			return $json;
54			}
55			}
56

Spomky-Labs / u2f-php

Push — master ( 104856...f1eb38 )

PublicKeyCredentialRpEntity::getId() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like