PublicKeyCredentialLoader::createResponse() - Code Metrics - Inspection of "Project updated" - Spomky-Labs/u2f-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 234d27...d96c64 )

by Florent

created 2018-09-03 12:09 UTC

PublicKeyCredentialLoader::createResponse() B

↳ Parent: PublicKeyCredentialLoader

Complexity

Conditions	7
Paths	7

Size

Total Lines	51
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	38
nc	7
nop	1
dl	0
loc	51
rs	8.3786
c	0
b	0
f	0

How to fix Long Method

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2018 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace U2FAuthentication\Fido2;

use Base64Url\Base64Url;
use CBOR\Decoder;
use U2FAuthentication\Fido2\AttestationStatement\AttestationObjectLoader;

class PublicKeyCredentialLoader
{
    private const FLAG_AT = 0b01000000;
    private const FLAG_ED = 0b10000000;

    private $decoder;

    private $attestationObjectLoader;

    public function __construct(Decoder $decoder, AttestationObjectLoader $attestationObjectLoader)
    {
        $this->decoder = $decoder;
        $this->attestationObjectLoader = $attestationObjectLoader;
    }

    public function load(string $data): PublicKeyCredential
    {
        $json = json_decode($data, true);
        if (!array_key_exists('id', $json)) {
            throw new \InvalidArgumentException();
        }
        $id = Base64Url::decode($json['id']);
        if (!array_key_exists('rawId', $json)) {
            throw new \InvalidArgumentException();
        }
        $rawId = Base64Url::decode($json['rawId']);
        if (!array_key_exists('type', $json)) {
            throw new \InvalidArgumentException();
        }
        if (!hash_equals($id, $rawId)) {
            throw new \InvalidArgumentException();
        }
        if (!array_key_exists('response', $json)) {
            throw new \InvalidArgumentException();
        }

        $publicKeyCredential = new PublicKeyCredential(
            $json['id'],
            $json['type'],
            $rawId,
            $this->createResponse($json['response'])
        );

        return $publicKeyCredential;
    }

    private function createResponse(array $response): AuthenticatorResponse
    {
        if (!array_key_exists('clientDataJSON', $response)) {
            throw new \InvalidArgumentException();
        }
        if (array_key_exists('attestationObject', $response)) {
            $attestationObject = $this->attestationObjectLoader->load($response['attestationObject']);

            return new AuthenticatorAttestationResponse(
                CollectedClientData::createFormJson($response['clientDataJSON']),
                $attestationObject
            );
        }
        if (array_key_exists('authenticatorData', $response) && array_key_exists('signature', $response)) {
            $authData = Base64Url::decode($response['authenticatorData']);

            $authDataStream = new StringStream($authData);
            $rp_id_hash = $authDataStream->read(32);
            $flags = $authDataStream->read(1);
            $signCount = $authDataStream->read(4);
            $signCount = unpack('N', $signCount)[1];

            if (\ord($flags) & self::FLAG_AT) {
                $aaguid = $authDataStream->read(16);
                $credentialLength = $authDataStream->read(2);
                $credentialLength = unpack('n', $credentialLength)[1];
                $credentialId = $authDataStream->read($credentialLength);
                $credentialPublicKey = $this->decoder->decode($authDataStream);
                $attestedCredentialData = new AttestedCredentialData($aaguid, $credentialId, $credentialPublicKey);
                $attestedCredentialData = new AttestedCredentialData($aaguid, $credentialId, /** @scrutinizer ignore-type */ $credentialPublicKey);
            } else {
                $attestedCredentialData = null;
            }

            if (\ord($flags) & self::FLAG_ED) {
                $extension = $this->decoder->decode($authDataStream);
            } else {
                $extension = null;
            }
            $authenticatorData = new AuthenticatorData(
                $rp_id_hash,
                $flags,
                $signCount,
                $attestedCredentialData,
                $extension
            );

            return new AuthenticatorAssertionResponse(
                CollectedClientData::createFormJson($response['clientDataJSON']),
                $authenticatorData,
                Base64Url::decode($response['signature']),
                $response['userHandle'] ?? null
            );
        }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }
}


Spomky-Labs / u2f-php

Push — master ( 234d27...d96c64 )

PublicKeyCredentialLoader::createResponse() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like