U2FAuthentication\Fido2\StringStream

Complexity

Total Complexity

5

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	read()	0	14	4
A	__construct()	0	5	1

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2018 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace U2FAuthentication\Fido2;

use CBOR\Stream;

final class StringStream implements Stream
{
    private $resource;

    /**
     * StringStream constructor.
     *
     * @param string $data
     */
    public function __construct(string $data)
    {
        $this->resource = fopen('php://memory', 'r+');
        fwrite($this->resource, $data);

It seems like $this->resource can also be of type false; however, parameter $handle of fwrite() does only seem to accept resource, maybe add an additional type check?

        rewind($this->resource);

It seems like $this->resource can also be of type false; however, parameter $handle of rewind() does only seem to accept resource, maybe add an additional type check?

    }

    public function read(int $length): string
    {
        if (0 === $length) {
            return '';
        }
        $data = fread($this->resource, $length);

It seems like $this->resource can also be of type false; however, parameter $handle of fread() does only seem to accept resource, maybe add an additional type check?

        if (!is_string($data)) {

The condition is_string($data) is always true.

            throw new \InvalidArgumentException('Cannot stream the data');
        }
        if (mb_strlen($data, '8bit') !== $length) {
            throw new \InvalidArgumentException(sprintf('Out of range. Expected: %d, read: %d', $length, mb_strlen($data, '8bit')));
        }

        return $data;
    }
}