It seems like $jwk defined by $jwk on line 52 can be null; however, Jose\Component\KeyManage...lyzerManager::analyze() does not accept null, maybe add an additional type check?
Unless you are absolutely sure that the expression can never be null because of
other conditions, we strongly recommend to add an additional type check to your
code:
/** @return stdClass|null */functionmayReturnNull(){}functiondoesNotAcceptNull(stdClass$x){}// With potential error.functionwithoutCheck(){$x=mayReturnNull();doesNotAcceptNull($x);// Potential error here.}// Safe - Alternative 1functionwithCheck1(){$x=mayReturnNull();if(!$xinstanceofstdClass){thrownew\LogicException('$x must be defined.');}doesNotAcceptNull($x);}// Safe - Alternative 2functionwithCheck2(){$x=mayReturnNull();if($xinstanceofstdClass){doesNotAcceptNull($x);}}
Loading history...
55
if (!empty($messages)) {
56
foreach ($messages as $message) {
57
$output->writeln(' '.$message);
58
}
59
} else {
60
$output->writeln(' No issue with this key');
61
}
62
63
switch (true) {
64
case 'oct' === $jwk->get('kty'):
65
$sharedKeys++;
66
if (0 !== $privateKeys+$publicKeys) {
67
$mixedKeys = true;
68
}
69
break;
70
case in_array($jwk->get('kty'), ['RSA', 'EC', 'OKP']):
71
if ($jwk->has('d')) {
72
$privateKeys++;
73
if (0 !== $sharedKeys+$publicKeys) {
74
$mixedKeys = true;
75
}
76
} else {
77
$publicKeys++;
78
if (0 !== $privateKeys+$sharedKeys) {
79
$mixedKeys = true;
80
}
81
}
82
break;
83
default:
84
break;
85
}
86
}
87
88
if ($mixedKeys) {
89
$output->writeln('/!\\ This key set mixes share, public and private keys. You should create one key set per key type. /!\\');
90
}
91
}
92
93
/**
94
* @param InputInterface $input
95
*
96
* @return JWKSet
97
*/
98
private function getKeyset(InputInterface $input): JWKSet
99
{
100
$jwkset = $input->getArgument('jwkset');
101
$json = json_decode($jwkset, true);
102
if (is_array($json)) {
103
return JWKSet::createFromKeyData($json);
104
} elseif ($this->getContainer()->has($jwkset)) {
105
$id = $this->getContainer()->get($jwkset);
106
if ($id instanceof JWKSet) {
107
return $id;
108
}
109
}
110
111
throw new \InvalidArgumentException('The argument must be a valid JWKSet or a service ID to a JWKSet.');
Spomky-Labs /
jose
Spomky
Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: