RotatableJWKSet::getJWKSet() - Code Metrics - Inspection of "PublicJWKSet and JWKSets added" - Spomky-Labs/jose - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( c70c83...5e6944 )

by Florent

created 2016-09-23 11:46 UTC

RotatableJWKSet::getJWKSet() A

↳ Parent: RotatableJWKSet

Complexity

Conditions	4
Paths	3

Size

Total Lines	19
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.2
c	0
b	0
f	0
cc	4
eloc	13
nc	3
nop	0

<?php

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2016 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace Jose\Object;

use Assert\Assertion;

/**
 * Class RotatableJWKSet.
 */
final class RotatableJWKSet extends StorableJWKSet implements RotatableJWKSetInterface
{
    /**
     * @var int
     */
    private $ttl;

    /**
     * RotatableJWKSet constructor.
     *
     * @param string $filename
     * @param array  $parameters
     * @param int    $nb_keys
     * @param int    $ttl
     */
    public function __construct($filename, array $parameters, $nb_keys, $ttl)
    {
        Assertion::integer($ttl);
        Assertion::greaterThan($ttl, 0, 'The parameter TTL must be at least 0.');
        $this->ttl = $ttl;
        parent::__construct($filename, $parameters, $nb_keys);
    }

    /**
     * @return \Jose\Object\JWKSetInterface
     */
    protected function getJWKSet()
    {
        $jwkset = parent::getJWKSet();
        if (null !== $this->getFileLastModificationTime()) {
            if ($this->getFileLastModificationTime() + $this->ttl < time()) {
                $keys = $jwkset->getKeys();
                unset($keys[count($keys) - 1]);
                $jwkset = new JWKSet();
                $jwkset->addKey($this->createJWK());

                foreach ($keys as $key) {
                    $jwkset->addKey($key);
                }
                $this->jwkset = $jwkset;
                $this->save();
            }
        }

        return parent::getJWKSet();
    }
}


1			<?php
2
3			/*
4			* The MIT License (MIT)
5			*
6			* Copyright (c) 2014-2016 Spomky-Labs
7			*
8			* This software may be modified and distributed under the terms
9			* of the MIT license. See the LICENSE file for details.
10			*/
11
12			namespace Jose\Object;
13
14			use Assert\Assertion;
15
16			/**
17			* Class RotatableJWKSet.
18			*/
19			final class RotatableJWKSet extends StorableJWKSet implements RotatableJWKSetInterface
20			{
21			/**
22			* @var int
23			*/
24			private $ttl;
25
26			/**
27			* RotatableJWKSet constructor.
28			*
29			* @param string $filename
30			* @param array $parameters
31			* @param int $nb_keys
32			* @param int $ttl
33			*/
34			public function __construct($filename, array $parameters, $nb_keys, $ttl)
35			{
36			Assertion::integer($ttl);
37			Assertion::greaterThan($ttl, 0, 'The parameter TTL must be at least 0.');
38			$this->ttl = $ttl;
39			parent::__construct($filename, $parameters, $nb_keys);
40			}
41
42			/**
43			* @return \Jose\Object\JWKSetInterface
44			*/
45			protected function getJWKSet()
46			{
47			$jwkset = parent::getJWKSet();
48			if (null !== $this->getFileLastModificationTime()) {
49			if ($this->getFileLastModificationTime() + $this->ttl < time()) {
50			$keys = $jwkset->getKeys();
51			unset($keys[count($keys) - 1]);
52			$jwkset = new JWKSet();
53			$jwkset->addKey($this->createJWK());
			0 ignored issues – show Bug introduced 2016-09-20 22:05 UTC by Report Bug Copy Issue Report It seems like `$this->createJWK()` targeting `Jose\Object\StorableJWKSet::createJWK()` can also be of type `object<Jose\Object\JWKSet>`; however, `Jose\Object\JWKSet::addKey()` does only seem to accept `object<Jose\Object\JWKInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
54			foreach ($keys as $key) {
55			$jwkset->addKey($key);
56			}
57			$this->jwkset = $jwkset;
58			$this->save();
59			}
60			}
61
62			return parent::getJWKSet();
63			}
64			}
65

Spomky-Labs / jose

Push — master ( c70c83...5e6944 )

RotatableJWKSet::getJWKSet() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like