Spomky-Labs /
jose
Complex classes like RSAKey often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use RSAKey, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 25 | final class RSAKey extends Sequence |
||
| 26 | { |
||
| 27 | /** |
||
| 28 | * @var array |
||
| 29 | */ |
||
| 30 | private $values = []; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * @param \Jose\Object\JWKInterface|string|array $data |
||
| 34 | */ |
||
| 35 | public function __construct($data) |
||
| 36 | { |
||
| 37 | parent::__construct(); |
||
| 38 | |||
| 39 | if ($data instanceof JWKInterface) { |
||
| 40 | $this->loadJWK($data->getAll()); |
||
| 41 | } elseif (is_array($data)) { |
||
| 42 | $this->loadJWK($data); |
||
| 43 | } elseif (is_string($data)) { |
||
| 44 | $this->loadPEM($data); |
||
| 45 | } else { |
||
| 46 | throw new \InvalidArgumentException('Unsupported input'); |
||
| 47 | } |
||
| 48 | } |
||
| 49 | |||
| 50 | /** |
||
| 51 | * @return bool |
||
| 52 | */ |
||
| 53 | public function isPublic() |
||
| 54 | { |
||
| 55 | return !$this->isPrivate(); |
||
| 56 | } |
||
| 57 | |||
| 58 | /** |
||
| 59 | * @return bool |
||
| 60 | */ |
||
| 61 | public function isPrivate() |
||
| 62 | { |
||
| 63 | return array_key_exists('d', $this->values); |
||
| 64 | } |
||
| 65 | |||
| 66 | /** |
||
| 67 | * @return \Jose\Util\BigInteger |
||
| 68 | */ |
||
| 69 | public function getModulus() |
||
| 70 | { |
||
| 71 | return $this->convertBase64StringToBigInteger($this->values['n']); |
||
| 72 | } |
||
| 73 | |||
| 74 | /** |
||
| 75 | * @return int |
||
| 76 | */ |
||
| 77 | public function getModulusLength() |
||
| 78 | { |
||
| 79 | return strlen($this->getModulus()->toBytes()); |
||
| 80 | } |
||
| 81 | |||
| 82 | /** |
||
| 83 | * @return \Jose\Util\BigInteger |
||
| 84 | */ |
||
| 85 | public function getExponent() |
||
| 86 | { |
||
| 87 | if (array_key_exists('d', $this->values)) { |
||
| 88 | return $this->getPrivateExponent(); |
||
| 89 | } |
||
| 90 | return $this->getPublicExponent(); |
||
| 91 | } |
||
| 92 | |||
| 93 | /** |
||
| 94 | * @return \Jose\Util\BigInteger |
||
| 95 | */ |
||
| 96 | public function getPublicExponent() |
||
| 97 | { |
||
| 98 | return $this->convertBase64StringToBigInteger($this->values['e']); |
||
| 99 | } |
||
| 100 | |||
| 101 | /** |
||
| 102 | * @return \Jose\Util\BigInteger |
||
| 103 | */ |
||
| 104 | public function getPrivateExponent() |
||
| 105 | { |
||
| 106 | Assertion::keyExists($this->values, 'd'); |
||
| 107 | |||
| 108 | return $this->convertBase64StringToBigInteger($this->values['d']); |
||
| 109 | } |
||
| 110 | |||
| 111 | /** |
||
| 112 | * @return \Jose\Util\BigInteger[] |
||
| 113 | */ |
||
| 114 | public function getPrimes() |
||
| 115 | { |
||
| 116 | if (array_key_exists('p', $this->values) && array_key_exists('q', $this->values)) { |
||
| 117 | return [ |
||
| 118 | $this->convertBase64StringToBigInteger($this->values['p']), |
||
| 119 | $this->convertBase64StringToBigInteger($this->values['q']), |
||
| 120 | ]; |
||
| 121 | } |
||
| 122 | |||
| 123 | return []; |
||
| 124 | } |
||
| 125 | |||
| 126 | /** |
||
| 127 | * @return \Jose\Util\BigInteger[] |
||
| 128 | */ |
||
| 129 | public function getExponents() |
||
| 130 | { |
||
| 131 | if (array_key_exists('dp', $this->values) && array_key_exists('dq', $this->values) && array_key_exists('qi', $this->values)) { |
||
| 132 | return [ |
||
| 133 | $this->convertBase64StringToBigInteger($this->values['dp']), |
||
| 134 | $this->convertBase64StringToBigInteger($this->values['dq']), |
||
| 135 | ]; |
||
| 136 | } |
||
| 137 | |||
| 138 | return []; |
||
| 139 | } |
||
| 140 | |||
| 141 | /** |
||
| 142 | * @return \Jose\Util\BigInteger|null |
||
| 143 | */ |
||
| 144 | public function getCoefficient() |
||
| 145 | { |
||
| 146 | if (array_key_exists('qi', $this->values)) { |
||
| 147 | return $this->convertBase64StringToBigInteger($this->values['qi']); |
||
| 148 | } |
||
| 149 | } |
||
| 150 | |||
| 151 | /** |
||
| 152 | * @param string $value |
||
| 153 | * |
||
| 154 | * @return \Jose\Util\BigInteger |
||
| 155 | */ |
||
| 156 | private function convertBase64StringToBigInteger($value) |
||
| 157 | { |
||
| 158 | return BigInteger::createFromBinaryString(Base64Url::decode($value)); |
||
| 159 | } |
||
| 160 | |||
| 161 | /** |
||
| 162 | * @param $data |
||
| 163 | * |
||
| 164 | * @throws \Exception |
||
| 165 | * @throws \FG\ASN1\Exception\ParserException |
||
| 166 | * |
||
| 167 | * @return array |
||
| 168 | */ |
||
| 169 | private function loadPEM($data) |
||
| 170 | { |
||
| 171 | $res = openssl_pkey_get_private($data); |
||
| 172 | if (false === $res) { |
||
| 173 | $res = openssl_pkey_get_public($data); |
||
| 174 | } |
||
| 175 | Assertion::false(false === $res, 'Unable to load the key'); |
||
| 176 | |||
| 177 | $details = openssl_pkey_get_details($res); |
||
| 178 | Assertion::keyExists($details, 'rsa', 'Unable to load the key'); |
||
| 179 | |||
| 180 | $this->values['kty'] = 'RSA'; |
||
| 181 | $keys = [ |
||
| 182 | 'n' => 'n', |
||
| 183 | 'e' => 'e', |
||
| 184 | 'd' => 'd', |
||
| 185 | 'p' => 'p', |
||
| 186 | 'q' => 'q', |
||
| 187 | 'dp' => 'dmp1', |
||
| 188 | 'dq' => 'dmq1', |
||
| 189 | 'qi' => 'iqmp', |
||
| 190 | ]; |
||
| 191 | foreach ($details['rsa'] as $key => $value) { |
||
| 192 | if (in_array($key, $keys)) { |
||
| 193 | $value = Base64Url::encode($value); |
||
| 194 | $this->values[array_search($key, $keys)] = $value; |
||
| 195 | } |
||
| 196 | } |
||
| 197 | } |
||
| 198 | |||
| 199 | /** |
||
| 200 | * @param array $jwk |
||
| 201 | */ |
||
| 202 | private function loadJWK(array $jwk) |
||
| 217 | |||
| 218 | /** |
||
| 219 | * @throws \Exception |
||
| 220 | */ |
||
| 221 | private function initPublicKey() |
||
| 222 | { |
||
| 223 | $oid_sequence = new Sequence(); |
||
| 224 | $oid_sequence->addChild(new ObjectIdentifier('1.2.840.113549.1.1.1')); |
||
| 225 | $oid_sequence->addChild(new NullObject()); |
||
| 226 | $this->addChild($oid_sequence); |
||
| 227 | |||
| 228 | $n = new Integer($this->fromBase64ToInteger($this->values['n'])); |
||
| 229 | $e = new Integer($this->fromBase64ToInteger($this->values['e'])); |
||
| 230 | |||
| 231 | $key_sequence = new Sequence(); |
||
| 232 | $key_sequence->addChild($n); |
||
| 233 | $key_sequence->addChild($e); |
||
| 234 | $key_bit_string = new BitString(bin2hex($key_sequence->getBinary())); |
||
| 235 | $this->addChild($key_bit_string); |
||
| 236 | } |
||
| 237 | |||
| 238 | private function initPrivateKey() |
||
| 270 | |||
| 271 | /** |
||
| 272 | * @param string $value |
||
| 273 | * |
||
| 274 | * @return string |
||
| 275 | */ |
||
| 276 | private function fromBase64ToInteger($value) |
||
| 280 | |||
| 281 | /** |
||
| 282 | * @param \Jose\KeyConverter\RSAKey $private |
||
| 283 | * |
||
| 284 | * @return \Jose\KeyConverter\RSAKey |
||
| 285 | */ |
||
| 286 | public static function toPublic(RSAKey $private) |
||
| 298 | |||
| 299 | public function __toString() |
||
| 303 | |||
| 304 | /** |
||
| 305 | * @return array |
||
| 306 | */ |
||
| 307 | public function toArray() |
||
| 311 | |||
| 312 | /** |
||
| 313 | * @return string |
||
| 314 | */ |
||
| 315 | public function toDER() |
||
| 316 | { |
||
| 317 | return $this->getBinary(); |
||
| 318 | } |
||
| 319 | |||
| 320 | /** |
||
| 321 | * @return string |
||
| 322 | */ |
||
| 323 | public function toPEM() |
||
| 324 | { |
||
| 325 | $result = '-----BEGIN '.($this->isPrivate() ? 'RSA PRIVATE' : 'PUBLIC').' KEY-----'.PHP_EOL; |
||
| 326 | $result .= chunk_split(base64_encode($this->getBinary()), 64, PHP_EOL); |
||
| 331 | } |
||
| 332 |
