Jose\Object\RotatableJWKSet

Complexity

Total Complexity

8

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	2
Bugs	2	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getJWKSet()	0	6	1
A	rotate()	0	13	1
B	rotateIfNeeded()	0	12	5

<?php

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2017 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace Jose\Object;

/**
 * Class RotatableJWKSet.
 */
final class RotatableJWKSet extends StorableJWKSet implements RotatableInterface
{
    /**
     * Interval at which keys should be rotated.
     *
     * @var int|null
     */
    private $interval;

    /**
     * RotatableJWKSet constructor.
     *
     * @param string   $filename
     * @param array    $parameters
     * @param int      $nb_keys
     * @param int|null $interval
     */
    public function __construct($filename, array $parameters, $nb_keys, $interval = null)
    {
        parent::__construct($filename, $parameters, $nb_keys);

        $this->interval = $interval;
    }

    /**
     * {@inheritdoc}
     */
    public function getJWKSet()
    {
        // Check if we need to rotate keys upon every interaction with the underlying JWK set
        $this->rotateIfNeeded();
        return parent::getJWKSet();
    }

    /**
     * {@inheritdoc}
     */
    public function rotate()
    {
        $jwkset = parent::getJWKSet();

It seems like you call parent on a different method (getJWKSet() instead of rotate()). Are you sure this is correct? If so, you might want to change this to $this->getJWKSet().

        // Remove last key in set
        $jwkset->removeKey($jwkset->countKeys() - 1);

        // Prepend new key to set
        $jwkset->prependKey($this->createJWK());

It seems like $this->createJWK() targeting Jose\Object\StorableJWKSet::createJWK() can also be of type object<Jose\Object\JWKSet>; however, Jose\Object\JWKSetInterface::prependKey() does only seem to accept object<Jose\Object\JWKInterface>, maybe add an additional type check?

        // Save new key set
        $this->saveObject($jwkset);
    }

    /**
     * Rotate key set if last modification time is due.
     */
    private function rotateIfNeeded()
    {
        if (isset($this->interval) && $this->interval >= 0) {
            $modificationTime = $this->getLastModificationTime();

            if (null === $modificationTime) {
                $this->regen();
            } elseif (($modificationTime + $this->interval) < time()) {
                $this->rotate();
            }
        }
    }
}