HeaderCheckerManager::checkHeaders() - Code Metrics - Inspection of "Apply fixes from StyleCI" - Spomky-Labs/jose - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — v7 (#250)

by Florent

created 2017-09-14 19:47 UTC

HeaderCheckerManager::checkHeaders() D

↳ Parent: HeaderCheckerManager

Complexity

Conditions	10
Paths	26

Size

Total Lines	34
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	34
rs	4.8196
c	0
b	0
f	0
cc	10
eloc	24
nc	26
nop	2

How to fix Complexity

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2017 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace Jose\Component\Checker;

use Jose\Component\Core\JWTInterface;
use Jose\Component\Encryption\JWE;
use Jose\Component\Signature\JWS;

/**
 * Class HeaderCheckerManager.
 */
final class HeaderCheckerManager
{
    /**
     * @var HeaderCheckerInterface[]
     */
    private $checkers = [];

    /**
     * HeaderCheckerManager constructor.
     *
     * @param HeaderCheckerInterface[] $checkers
     */
    private function __construct(array $checkers)
    {
        foreach ($checkers as $checker) {
            $this->add($checker);
        }
    }

    /**
     * @param HeaderCheckerInterface[] $checkers
     *
     * @return HeaderCheckerManager
     */
    public static function create(array $checkers): HeaderCheckerManager
    {
        return new self($checkers);
    }

    /**
     * @param HeaderCheckerInterface $checker
     */
    private function add(HeaderCheckerInterface $checker)
    {
        $header = $checker->supportedHeader();
        if (array_key_exists($header, $this->checkers)) {
            throw new \InvalidArgumentException(sprintf('The header checker "%s" is already supported.', $header));
        }

        $this->checkers[$header] = $checker;
    }

    /**
     * @param JWTInterface $jwt
     * @param int          $component
     */
    public function check(JWTInterface $jwt, int $component)
    {
        switch (true) {
            case $jwt instanceof JWS:
                $this->checkJWS($jwt, $component);

                break;
            case $jwt instanceof JWE:
                $this->checkJWE($jwt, $component);

                break;
            default:
                throw new \InvalidArgumentException('Unsupported argument');
        }
    }

    /**
     * @param JWS $jws
     * @param int $signature
     */
    public function checkJWS(JWS $jws, int $signature)
    {
        if ($signature > $jws->countSignatures()) {
            throw new \InvalidArgumentException('Unknown signature index.');
        }
        $protected = $jws->getSignature($signature)->getProtectedHeaders();
        $headers = $jws->getSignature($signature)->getHeaders();
        $this->checkDuplicatedHeaderParameters($protected, $headers);
        $this->checkHeaders($protected, $headers);
    }

    /**
     * @param JWE $jwe
     * @param int $recipient
     */
    public function checkJWE(JWE $jwe, int $recipient)
    {
        if ($recipient > $jwe->countRecipients()) {
            throw new \InvalidArgumentException('Unknown recipient index.');
        }
        $protected = $jwe->getSharedProtectedHeaders();
        $headers = $jwe->getSharedHeaders();
        $recipient = $jwe->getRecipient($recipient)->getHeaders();
        $this->checkDuplicatedHeaderParameters($protected, $headers);
        $this->checkDuplicatedHeaderParameters($protected, $recipient);
        $this->checkDuplicatedHeaderParameters($headers, $recipient);
        $unprotected = array_merge(
            $headers,
            $recipient
        );
        $this->checkHeaders($protected, $unprotected);
    }

    /**
     * @param array $header1
     * @param array $header2
     */
    private function checkDuplicatedHeaderParameters(array $header1, array $header2)
    {
        $inter = array_intersect_key($header1, $header2);
        if (!empty($inter)) {
            throw new \InvalidArgumentException(sprintf('The header contains duplicated entries: %s.', implode(', ', array_keys($inter))));
        }
    }

    /**
     * @param array $protected
     * @param array $headers
     */
    private function checkHeaders(array $protected, array $headers)
    {
        $checkedHeaders = [];
        foreach ($this->checkers as $header => $checker) {
            if ($checker->protectedHeaderOnly()) {
                if (array_key_exists($header, $protected)) {
                    $checker->checkHeader($protected[$header]);
                    $checkedHeaders[] = $header;
                } else {
                    throw new \InvalidArgumentException(sprintf('The header "%s" must be protected.', $header));
                }
            } else {
                if (array_key_exists($header, $protected)) {
                    $checker->checkHeader($protected[$header]);
                    $checkedHeaders[] = $header;
                } elseif (array_key_exists($header, $headers)) {
                    $checker->checkHeader($headers[$header]);
                    $checkedHeaders[] = $header;
                }
            }
        }

        if (array_key_exists('crit', $protected)) {
            if (!is_array($protected['crit'])) {
                throw new \InvalidArgumentException('The header "crit" mus be a list of header parameters.');
            }
            $diff = array_diff($protected['crit'], $checkedHeaders);
            if (!empty($diff)) {
                throw new \InvalidArgumentException(sprintf('One or more headers are marked as critical, but they are missing or have not been checked: %s.', implode(', ', array_values($diff))));
            }
        } elseif (array_key_exists('crit', $headers)) {
            throw new \InvalidArgumentException('The header parameter "crit" must be protected.');
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* The MIT License (MIT)
7			*
8			* Copyright (c) 2014-2017 Spomky-Labs
9			*
10			* This software may be modified and distributed under the terms
11			* of the MIT license. See the LICENSE file for details.
12			*/
13
14			namespace Jose\Component\Checker;
15
16			use Jose\Component\Core\JWTInterface;
17			use Jose\Component\Encryption\JWE;
18			use Jose\Component\Signature\JWS;
19
20			/**
21			* Class HeaderCheckerManager.
22			*/
23			final class HeaderCheckerManager
24			{
25			/**
26			* @var HeaderCheckerInterface[]
27			*/
28			private $checkers = [];
29
30			/**
31			* HeaderCheckerManager constructor.
32			*
33			* @param HeaderCheckerInterface[] $checkers
34			*/
35			private function __construct(array $checkers)
36			{
37			foreach ($checkers as $checker) {
38			$this->add($checker);
39			}
40			}
41
42			/**
43			* @param HeaderCheckerInterface[] $checkers
44			*
45			* @return HeaderCheckerManager
46			*/
47			public static function create(array $checkers): HeaderCheckerManager
48			{
49			return new self($checkers);
50			}
51
52			/**
53			* @param HeaderCheckerInterface $checker
54			*/
55			private function add(HeaderCheckerInterface $checker)
56			{
57			$header = $checker->supportedHeader();
58			if (array_key_exists($header, $this->checkers)) {
59			throw new \InvalidArgumentException(sprintf('The header checker "%s" is already supported.', $header));
60			}
61
62			$this->checkers[$header] = $checker;
63			}
64
65			/**
66			* @param JWTInterface $jwt
67			* @param int $component
68			*/
69			public function check(JWTInterface $jwt, int $component)
70			{
71			switch (true) {
72			case $jwt instanceof JWS:
73			$this->checkJWS($jwt, $component);
74
75			break;
76			case $jwt instanceof JWE:
77			$this->checkJWE($jwt, $component);
78
79			break;
80			default:
81			throw new \InvalidArgumentException('Unsupported argument');
82			}
83			}
84
85			/**
86			* @param JWS $jws
87			* @param int $signature
88			*/
89			public function checkJWS(JWS $jws, int $signature)
90			{
91			if ($signature > $jws->countSignatures()) {
92			throw new \InvalidArgumentException('Unknown signature index.');
93			}
94			$protected = $jws->getSignature($signature)->getProtectedHeaders();
95			$headers = $jws->getSignature($signature)->getHeaders();
96			$this->checkDuplicatedHeaderParameters($protected, $headers);
97			$this->checkHeaders($protected, $headers);
98			}
99
100			/**
101			* @param JWE $jwe
102			* @param int $recipient
103			*/
104			public function checkJWE(JWE $jwe, int $recipient)
105			{
106			if ($recipient > $jwe->countRecipients()) {
107			throw new \InvalidArgumentException('Unknown recipient index.');
108			}
109			$protected = $jwe->getSharedProtectedHeaders();
110			$headers = $jwe->getSharedHeaders();
111			$recipient = $jwe->getRecipient($recipient)->getHeaders();
112			$this->checkDuplicatedHeaderParameters($protected, $headers);
113			$this->checkDuplicatedHeaderParameters($protected, $recipient);
114			$this->checkDuplicatedHeaderParameters($headers, $recipient);
115			$unprotected = array_merge(
116			$headers,
117			$recipient
118			);
119			$this->checkHeaders($protected, $unprotected);
120			}
121
122			/**
123			* @param array $header1
124			* @param array $header2
125			*/
126			private function checkDuplicatedHeaderParameters(array $header1, array $header2)
127			{
128			$inter = array_intersect_key($header1, $header2);
129			if (!empty($inter)) {
130			throw new \InvalidArgumentException(sprintf('The header contains duplicated entries: %s.', implode(', ', array_keys($inter))));
131			}
132			}
133
134			/**
135			* @param array $protected
136			* @param array $headers
137			*/
138			private function checkHeaders(array $protected, array $headers)
139			{
140			$checkedHeaders = [];
141			foreach ($this->checkers as $header => $checker) {
142			if ($checker->protectedHeaderOnly()) {
143			if (array_key_exists($header, $protected)) {
144			$checker->checkHeader($protected[$header]);
145			$checkedHeaders[] = $header;
146			} else {
147			throw new \InvalidArgumentException(sprintf('The header "%s" must be protected.', $header));
148			}
149			} else {
150			if (array_key_exists($header, $protected)) {
151			$checker->checkHeader($protected[$header]);
152			$checkedHeaders[] = $header;
153			} elseif (array_key_exists($header, $headers)) {
154			$checker->checkHeader($headers[$header]);
155			$checkedHeaders[] = $header;
156			}
157			}
158			}
159
160			if (array_key_exists('crit', $protected)) {
161			if (!is_array($protected['crit'])) {
162			throw new \InvalidArgumentException('The header "crit" mus be a list of header parameters.');
163			}
164			$diff = array_diff($protected['crit'], $checkedHeaders);
165			if (!empty($diff)) {
166			throw new \InvalidArgumentException(sprintf('One or more headers are marked as critical, but they are missing or have not been checked: %s.', implode(', ', array_values($diff))));
167			}
168			} elseif (array_key_exists('crit', $headers)) {
169			throw new \InvalidArgumentException('The header parameter "crit" must be protected.');
170			}
171			}
172			}
173

Spomky-Labs / jose

Pull Request — v7 (#250)

HeaderCheckerManager::checkHeaders() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like