NoneSignatureTest::testInvalidKey() - Code Metrics - Inspection of "Bugs fixed" - Spomky-Labs/jose - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 686594...b5844e )

by Florent

created 2016-03-19 22:24 UTC

NoneSignatureTest::testInvalidKey() A

↳ Parent: NoneSignatureTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	11
rs	9.4285
cc	1
eloc	6
nc	1
nop	0

<?php

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2016 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

use Jose\Algorithm\Signature\None;
use Jose\Factory\SignerFactory;
use Jose\Loader;
use Jose\Object\JWK;
use Jose\Object\JWSInterface;
use Jose\Test\TestCase;

/**
 * Class NoneSignatureTest.
 *
 * @group None
 * @group Unit
 */
class NoneSignatureTest extends TestCase
{
    public function testNoneSignAndVerifyAlgorithm()
    {
        $key = new JWK([
            'kty' => 'none',
        ]);

        $none = new None();
        $data = 'Live long and Prosper.';

        $signature = $none->sign($key, $data);

        $this->assertEquals($signature, '');
        $this->assertTrue($none->verify($key, $data, $signature));
    }

    /**
     * @expectedException \InvalidArgumentException
     * @expectedExceptionMessage Wrong key type.
     */
    public function testInvalidKey()
    {
        $key = new JWK([
            'kty' => 'EC',
        ]);

        $none = new None();
        $data = 'Live long and Prosper.';

        $none->sign($key, $data);
    }

    public function testNoneSignAndVerifyComplete()
    {
        $jwk = new JWK([
            'kty' => 'none',
        ]);

        $jws = \Jose\Factory\JWSFactory::createJWS('Live long and Prosper.');
        $jws = $jws->addSignature($jwk, ['alg' => 'none']);

        $signer = SignerFactory::createSigner(['none']);
        $signer->sign($jws);

        $this->assertEquals(1, $jws->countSignatures());

        $compact = $jws->toCompactJSON(0);
        $this->assertTrue(is_string($compact));

        $result = Loader::load($compact);

        $this->assertInstanceOf(JWSInterface::class, $result);

        $this->assertEquals('Live long and Prosper.', $result->getPayload());
        $this->assertEquals(1, $result->countSignatures());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertTrue($result->getSignature(0)->hasProtectedHeader('alg'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertEquals('none', $result->getSignature(0)->getProtectedHeader('alg'));
    }
}


Push — develop ( 686594...b5844e )

NoneSignatureTest::testInvalidKey() A

Complexity

Size

Duplication

Available Fixes

Available Fixes

1			<?php
2
3			/*
4			* The MIT License (MIT)
5			*
6			* Copyright (c) 2014-2016 Spomky-Labs
7			*
8			* This software may be modified and distributed under the terms
9			* of the MIT license. See the LICENSE file for details.
10			*/
11
12			use Jose\Algorithm\Signature\None;
13			use Jose\Factory\SignerFactory;
14			use Jose\Loader;
15			use Jose\Object\JWK;
16			use Jose\Object\JWSInterface;
17			use Jose\Test\TestCase;
18
19			/**
20			* Class NoneSignatureTest.
21			*
22			* @group None
23			* @group Unit
24			*/
25			class NoneSignatureTest extends TestCase
26			{
27			public function testNoneSignAndVerifyAlgorithm()
28			{
29			$key = new JWK([
30			'kty' => 'none',
31			]);
32
33			$none = new None();
34			$data = 'Live long and Prosper.';
35
36			$signature = $none->sign($key, $data);
37
38			$this->assertEquals($signature, '');
39			$this->assertTrue($none->verify($key, $data, $signature));
40			}
41
42			/**
43			* @expectedException \InvalidArgumentException
44			* @expectedExceptionMessage Wrong key type.
45			*/
46			public function testInvalidKey()
47			{
48			$key = new JWK([
49			'kty' => 'EC',
50			]);
51
52			$none = new None();
53			$data = 'Live long and Prosper.';
54
55			$none->sign($key, $data);
56			}
57
58			public function testNoneSignAndVerifyComplete()
59			{
60			$jwk = new JWK([
61			'kty' => 'none',
62			]);
63
64			$jws = \Jose\Factory\JWSFactory::createJWS('Live long and Prosper.');
65			$jws = $jws->addSignature($jwk, ['alg' => 'none']);
66
67			$signer = SignerFactory::createSigner(['none']);
68			$signer->sign($jws);
69
70			$this->assertEquals(1, $jws->countSignatures());
71
72			$compact = $jws->toCompactJSON(0);
73			$this->assertTrue(is_string($compact));
74
75			$result = Loader::load($compact);
76
77			$this->assertInstanceOf(JWSInterface::class, $result);
78
79			$this->assertEquals('Live long and Prosper.', $result->getPayload());
80			$this->assertEquals(1, $result->countSignatures());
			0 ignored issues – show Bug introduced 2016-03-19 22:27 UTC by Report Bug Copy Issue Report The method `countSignatures` does only exist in `Jose\Object\JWSInterface`, but not in `Jose\Object\JWEInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
81			$this->assertTrue($result->getSignature(0)->hasProtectedHeader('alg'));
			0 ignored issues – show Bug introduced 2016-03-19 22:27 UTC by Report Bug Copy Issue Report The method `getSignature` does only exist in `Jose\Object\JWSInterface`, but not in `Jose\Object\JWEInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
82			$this->assertEquals('none', $result->getSignature(0)->getProtectedHeader('alg'));
83			}
84			}
85

Spomky-Labs / jose

Push — develop ( 686594...b5844e )

NoneSignatureTest::testInvalidKey() A

Complexity

Size

Duplication

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like