Jose\Object\RotatableJWKSet

Complexity

Total Complexity

2

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	rotate()	0	15	2

<?php

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2016 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace Jose\Object;

/**
 * Class RotatableJWKSet.
 */
final class RotatableJWKSet extends StorableJWKSet implements RotatableJWKSetInterface
{
    /**
     * {@inheritdoc}
     */
    public function rotate()
    {
        $jwkset = $this->getObject();

        $keys = $jwkset->getKeys();
        unset($keys[count($keys) - 1]);
        $jwkset = new JWKSet();
        $jwkset->addKey($this->createJWK());

It seems like $this->createJWK() targeting Jose\Object\StorableJWKSet::createJWK() can also be of type object<Jose\Object\JWKSet>; however, Jose\Object\JWKSet::addKey() does only seem to accept object<Jose\Object\JWKInterface>, maybe add an additional type check?

        foreach ($keys as $key) {
            $jwkset->addKey($key);
        }
        $this->jwkset = $jwkset;

The property jwkset does not exist. Did you maybe forget to declare it?

        $this->setObject($jwkset);
        $this->saveObject($jwkset);
    }
}