Report - Code Metrics - Inspection of "Initial Support for FlexiBee custom reports" - Spoje-NET/php-flexibee - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 394c6b...374c2c )

by Vítězslav

created 2020-04-20 14:15 UTC

Report A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	40
rs	10
c	0
b	0
f	0
wmc	4
lcom	1
cbo	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	loadFromFlexiBee()	0	9	3
A	updateApiURL()	0	7	1

<?php

/**
 * FlexiPeeHP - Custom Report object.
 *
 * @author     Vítězslav Dvořák <[email protected]>
 * @copyright  (C) 2020 Spoje.Net
 */

namespace FlexiPeeHP;

/**
 * Description of Report
 *
 * @author vitex
 */
class Report extends FlexiBeeRW {

    /**
     * Evidence užitá objektem.
     * Evidence used by object.
     *
     * @var string
     */
    public $evidence = 'report';

    /**
     * Načte záznam z FlexiBee a uloží v sobě jeho data
     * Read FlexiBee record and store it inside od object
     *
     * @param int|string $id ID or conditions
     *
     * @return int počet načtených položek
     */
    public function loadFromFlexiBee($id = null) {
        if (strstr($id, 'code:')) { //Dirty Hack ⚠ Error 400: Entita 'Report' neobsahuje kód nebo ho nelze použít jako ID (není unikátní)
            $candidates = $this->getColumnsFromFlexibee(['id', 'kod'], null, 'kod');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            if (array_key_exists(\FlexiPeeHP\FlexiBeeRO::uncode($id), $candidates)) {
                $id = intval($candidates[\FlexiPeeHP\FlexiBeeRO::uncode($id)]['id']);
            }
        }
        return parent::loadFromFlexiBee($id);
    }

    /**
     * Update $this->apiURL
     */
    public function updateApiURL() {
        $code = $this->getDataValue('kod');
        $this->unsetDataValue('kod');
        $result = parent::updateApiURL();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->setDataValue('kod',$code);
        return $result;
    }

}


1			<?php
2
3			/**
4			* FlexiPeeHP - Custom Report object.
5			*
6			* @author Vítězslav Dvořák <[email protected]>
7			* @copyright (C) 2020 Spoje.Net
8			*/
9
10			namespace FlexiPeeHP;
11
12			/**
13			* Description of Report
14			*
15			* @author vitex
16			*/
17			class Report extends FlexiBeeRW {
18
19			/**
20			* Evidence užitá objektem.
21			* Evidence used by object.
22			*
23			* @var string
24			*/
25			public $evidence = 'report';
26
27			/**
28			* Načte záznam z FlexiBee a uloží v sobě jeho data
29			* Read FlexiBee record and store it inside od object
30			*
31			* @param int\|string $id ID or conditions
32			*
33			* @return int počet načtených položek
34			*/
35			public function loadFromFlexiBee($id = null) {
36			if (strstr($id, 'code:')) { //Dirty Hack ⚠ Error 400: Entita 'Report' neobsahuje kód nebo ho nelze použít jako ID (není unikátní)
37			$candidates = $this->getColumnsFromFlexibee(['id', 'kod'], null, 'kod');
			0 ignored issues – show Documentation introduced 2020-04-20 14:40 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38			if (array_key_exists(\FlexiPeeHP\FlexiBeeRO::uncode($id), $candidates)) {
39			$id = intval($candidates[\FlexiPeeHP\FlexiBeeRO::uncode($id)]['id']);
40			}
41			}
42			return parent::loadFromFlexiBee($id);
43			}
44
45			/**
46			* Update $this->apiURL
47			*/
48			public function updateApiURL() {
49			$code = $this->getDataValue('kod');
50			$this->unsetDataValue('kod');
51			$result = parent::updateApiURL();
			0 ignored issues – show Bug introduced 2020-04-20 14:40 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$result` is correct as `parent::updateApiURL()` (which targets `FlexiPeeHP\FlexiBeeRO::updateApiURL()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
52			$this->setDataValue('kod',$code);
53			return $result;
54			}
55
56			}
57

Spoje-NET / php-flexibee

Push — master ( 394c6b...374c2c )

Report A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like