SubItems - Code Metrics - Inspection of "Handling SubItems Trait for not even Invoices adde..." - Spoje-NET/php-flexibee - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 230897...bb977a )

by Vítězslav

created 2020-07-11 02:15 UTC

SubItems A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	20
rs	10
c	0
b	0
f	0
wmc	5
lcom	0
cbo	0

3 Methods

Rating	Name	Size	Complexity
A	getSubItems()	3	1
A	setSubitems()	3	1
A	getSubMenuName()	4	3

<?php

/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */

namespace FlexiPeeHP;

/**
 *
 * @author vitex
 */
trait SubItems {
    /**
     * Subitems - ex. items of invoice
     * 
     * @return array of document items or null
     */
    public function getSubItems() {
        return $this->getDataValue($this->getSubmenuName());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
    
    public function setSubitems(array $subitems) {
        return $this->setDataValue($this->getSubmenuName(), $subitems);    
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function getSubMenuName() {
        return array_key_exists('polozkyFaktury', $this->getData()) ? 'polozkyFaktury' : (array_key_exists('polozkyDokladu', $this->getData()) ? 'polozkyDokladu' : null);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

    }
    
}


1			<?php
2
3			/*
4			* To change this license header, choose License Headers in Project Properties.
5			* To change this template file, choose Tools \| Templates
6			* and open the template in the editor.
7			*/
8
9			namespace FlexiPeeHP;
10
11			/**
12			*
13			* @author vitex
14			*/
15			trait SubItems {
16			/**
17			* Subitems - ex. items of invoice
18			*
19			* @return array of document items or null
20			*/
21			public function getSubItems() {
22			return $this->getDataValue($this->getSubmenuName());
			0 ignored issues – show Bug introduced 2020-07-11 02:39 UTC by Report Bug Copy Issue Report It seems like `getDataValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23			}
24
25			public function setSubitems(array $subitems) {
26			return $this->setDataValue($this->getSubmenuName(), $subitems);
			0 ignored issues – show Bug introduced 2020-07-11 02:39 UTC by Report Bug Copy Issue Report It seems like `setDataValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27			}
28
29			public function getSubMenuName() {
30			return array_key_exists('polozkyFaktury', $this->getData()) ? 'polozkyFaktury' : (array_key_exists('polozkyDokladu', $this->getData()) ? 'polozkyDokladu' : null);
			0 ignored issues – show Bug introduced 2020-07-11 02:39 UTC by Report Bug Copy Issue Report It seems like `getData()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31
32			}
33
34			}
35

Spoje-NET / php-flexibee

Push — master ( 230897...bb977a )

SubItems A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like