UcetniObdobi::createYearsFrom() - Code Metrics - Inspection of "BIG Unit tests update" - Spoje-NET/FlexiPeeHP - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 9ca4a5...db00ed )

by Vítězslav

created 2017-10-03 16:08 UTC

UcetniObdobi::createYearsFrom() B

↳ Parent: UcetniObdobi

Complexity

Conditions	4
Paths	6

Size

Total Lines	22
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	4.343

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	15
nc	6
nop	2
dl	0
loc	22
ccs	13
cts	18
cp	0.7221
crap	4.343
rs	8.9197
c	1
b	0
f	0

<?php
/**
 * FlexiPeeHP - Objekt účetního období.
 *
 * @author     Vítězslav Dvořák <[email protected]>
 * @copyright  (C) 2015-2017 Spoje.Net
 */

namespace FlexiPeeHP;

/**
 * Class for Accounting period handling.
 *
 * @link https://demo.flexibee.eu/c/demo/ucetni-obdobi/properties Položky evidence
 * @author vitex
 */
class UcetniObdobi extends FlexiBeeRW
{
    /**
     * Evidence FlexiBee
     * @var string
     */
    public $evidence = 'ucetni-obdobi';

    /**
     * Create requested Accounting period
     *
     * @param int $startYear first year to create
     * @param int $endYear   last yar to create - default is current year
     *
     * @return array Results
     */
    public function createYearsFrom($startYear, $endYear = null)
    {
        $result = [];
        if (is_null($endYear)) {
            $endYear = date('Y');
        }

        for ($year = $startYear; $year <= $endYear; ++$year) {
            $obdobi = ['kod' => $year,
                'platiOdData' => $year.'-01-01T00:00:00',
                'platiDoData' => $year.'-12-31T23:59:59',
            ];
            if ($this->idExists('code:'.$year)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $this->addStatusMessage(sprintf(_('%s already exists.'), $year));
            } else {
                $this->setData($obdobi);
                $result[] = $this->insertToFlexibee();
            $this->dataReset();
        }
        }
        return $result;
    }
}


1		<?php
2		/**
3		* FlexiPeeHP - Objekt účetního období.
4		*
5		* @author Vítězslav Dvořák <[email protected]>
6		* @copyright (C) 2015-2017 Spoje.Net
7		*/
8
9		namespace FlexiPeeHP;
10
11		/**
12		* Class for Accounting period handling.
13		*
14		* @link https://demo.flexibee.eu/c/demo/ucetni-obdobi/properties Položky evidence
15		* @author vitex
16		*/
17		class UcetniObdobi extends FlexiBeeRW
18		{
19		/**
20		* Evidence FlexiBee
21		* @var string
22		*/
23		public $evidence = 'ucetni-obdobi';
24
25		/**
26		* Create requested Accounting period
27		*
28		* @param int $startYear first year to create
29		* @param int $endYear last yar to create - default is current year
30		*
31		* @return array Results
32		*/
33	1	public function createYearsFrom($startYear, $endYear = null)
34		{
35	1	$result = [];
36	1	if (is_null($endYear)) {
37		$endYear = date('Y');
38		}
39
40	1	for ($year = $startYear; $year <= $endYear; ++$year) {
41	1	$obdobi = ['kod' => $year,
42	1	'platiOdData' => $year.'-01-01T00:00:00',
43	1	'platiDoData' => $year.'-12-31T23:59:59',
44	1	];
45	1	if ($this->idExists('code:'.$year)) {
		0 ignored issues – show Documentation introduced 2017-10-03 16:19 UTC by Report Bug Copy Issue Report `'code:' . $year` is of type `string`, but the function expects a `boolean\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
46	1	$this->addStatusMessage(sprintf(_('%s already exists.'), $year));
47	1	} else {
48		$this->setData($obdobi);
49		$result[] = $this->insertToFlexibee();
50		$this->dataReset();
51		}
52	1	}
53	1	return $result;
54		}
55		}
56

Spoje-NET / FlexiPeeHP

Push — master ( 9ca4a5...db00ed )

UcetniObdobi::createYearsFrom() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like