Spoje-NET /
FlexiPeeHP
| Conditions | 4 |
| Paths | 3 |
| Total Lines | 15 |
| Code Lines | 10 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
| 1 | <?php |
||
| 33 | public function addSerialNumber($number, $isMain = false) |
||
| 34 | { |
||
| 35 | $numberBranch['kod'] = $number; |
||
|
|
|||
| 36 | $crrentSerialNumbers = $this->getDataValue('vyrobniCislaPrijata'); |
||
| 37 | if ($isMain) { |
||
| 38 | if (!empty($crrentSerialNumbers)) { |
||
| 39 | foreach (array_keys($crrentSerialNumbers) as $serialNumberID) { |
||
| 40 | unset($this->data['vyrobniCislaPrijata'][$serialNumberID]['vyrobnicislohlav']); |
||
| 41 | } |
||
| 42 | } |
||
| 43 | $numberBranch['vyrobnicislohlav'] = 1; |
||
| 44 | } |
||
| 45 | $this->setDataValue('mnozMj', count($crrentSerialNumbers) + 1); |
||
| 46 | return $this->addArrayToBranch($numberBranch, 'vyrobniCislaPrijata'); |
||
| 47 | } |
||
| 48 | } |
||
| 49 |
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.