Priloha::saveToFile() - Code Metrics - Inspection of "Added Basic support for work with Attachments" - Spoje-NET/FlexiPeeHP - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( bb67b0...f67d68 )

by Vítězslav

created 2017-03-19 23:16 UTC

Priloha::saveToFile() A

↳ Parent: Priloha

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	3
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php
/**
 * FlexiPeeHP - Objekt kontaktu.
 *
 * @author     Vítězslav Dvořák <[email protected]>
 * @copyright  (C) 2015-2017 Spoje.Net
 */

namespace FlexiPeeHP;

/**
 * Příloha
 *
 * @link https://www.flexibee.eu/api/dokumentace/ref/attachments/
 * @link https://demo.flexibee.eu/c/demo/priloha/properties
 */
class Priloha extends FlexiBeeRW
{
    /**
     * Evidence užitá objektem.
     *
     * @var string
     */
    public $evidence               = 'priloha';
    public static $relatedEvidence = [
        'prodejka' => 'doklFak', 'pohledavka' => 'doklFak', 'zavazek' => 'doklFak',
        'faktura-prijata' => 'doklFak', 'faktura-vydana' => 'doklFak',
        'interni-doklad' => 'doklInt', 'pokladni-pohyb' => 'doklInt', 'vzajemny-zapocet' => 'doklInt',
        'banka' => 'doklInt',
        'poptavka-vydana' => 'doklObch', 'poptavka-prijata' => 'doklObch', 'objednavka-prijata' => 'doklObch',
        'nabidka-vydana' => 'doklObch',
        'objednavka-vydana' => 'doklObch', 'nabidka-prijata' => 'doklObch',
        'skladovy-pohyb' => 'doklSklad',
        'cenik' => 'cenik',
        'adresar' => 'adresar', 'kontakt' => 'kontakt'
    ];

    public function attachFile($filepath, $attachmentData = [])
    {
        if (file_exists($filepath)) {
            $attachmentData['nazSoub']     = basename($filepath);
            $attachmentData['contentType'] = mime_content_type($filepath);
            $attachmentData['dataSize']    = filesize($filepath);
            $attachmentData['dataHash']    = md5_file($filepath);

            switch ($attachmentData['contentType']) {
                case 'image/png':
                case 'image/gif':
                case 'image/jpeg':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                    break;
            }
            $attachmentData['content'] = base64_encode(file_get_contents($filepath));
        }
    }

    /**
     * Obtain url for Attachment Download
     *
     * @return string url
     */
    public static function getDownloadUrl($object)
    {
        return $object->apiURL.'/content';
    }

    public function getFirsAttachment($object)
    {
        $attachments = self::getAttachmentsList($object);
        return count($attachments) ? current($attachments) : null;
    }

    public static function download($object, $attachmentID = null)

    {
        header('Content-Description: File Transfer');
        header('Content-Type: application/octet-stream');
        header('Content-Transfer-Encoding: binary');
        header('Expires: 0');
        header('Cache-Control: must-revalidate, post-check=0, pre-check=0');
        header('Pragma: public');
        header('Content-Disposition: attachment; filename='.$this->host->getName().'_nrpe.sh');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        header('Content-Length: '.strlen($nrpesh));

        echo $object;
    }

    public static function saveToFile($object, $filename, $attachmentID = null)

    {

    }

    /**
     * Add Attachment from File
     *
     * @param FlexiBeeRW $object
     * @param string     $filename
     *
     * @return int      HTTP response code
     */
    public static function addAttachmentFromFile($object, $filename)
    {
        return self::addAttachment($object, basename($filename),
                file_get_contents($filename), mime_content_type($filename));
    }

    /**
     * Add Attachment related to current $object content
     *
     * @param FlexiBeeRW $object
     * @param string $filename
     * @param string $attachment Body
     * @param string $contentType Attachment Content-Type
     *
     * @return int HTTP Response code
     */
    public static function addAttachment($object, $filename, $attachment,
                                         $contentType)
    {
        $headersBackup                              = $object->defaultHttpHeaders;
        $object->postFields                         = $attachment;
        $object->defaultHttpHeaders['Content-Type'] = $contentType;
        $url                                        = $object->getFlexiBeeURL().'/prilohy/new/'.$filename;
        $response                                   = $object->doCurlRequest($url,
            'PUT');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $object->defaultHttpHeaders                 = $headersBackup;
        return $response;
    }

    /**
     * Obtain Record related attachments list
     *
     * @param FlexiBeeRO $object
     * @return array
     */
    public static function getAttachmentsList($object)
    {
        return $object->getFlexiData($object->getFlexiBeeURL().'/prilohy');
    }
}


1			<?php
2			/**
3			* FlexiPeeHP - Objekt kontaktu.
4			*
5			* @author Vítězslav Dvořák <[email protected]>
6			* @copyright (C) 2015-2017 Spoje.Net
7			*/
8
9			namespace FlexiPeeHP;
10
11			/**
12			* Příloha
13			*
14			* @link https://www.flexibee.eu/api/dokumentace/ref/attachments/
15			* @link https://demo.flexibee.eu/c/demo/priloha/properties
16			*/
17			class Priloha extends FlexiBeeRW
18			{
19			/**
20			* Evidence užitá objektem.
21			*
22			* @var string
23			*/
24			public $evidence = 'priloha';
25			public static $relatedEvidence = [
26			'prodejka' => 'doklFak', 'pohledavka' => 'doklFak', 'zavazek' => 'doklFak',
27			'faktura-prijata' => 'doklFak', 'faktura-vydana' => 'doklFak',
28			'interni-doklad' => 'doklInt', 'pokladni-pohyb' => 'doklInt', 'vzajemny-zapocet' => 'doklInt',
29			'banka' => 'doklInt',
30			'poptavka-vydana' => 'doklObch', 'poptavka-prijata' => 'doklObch', 'objednavka-prijata' => 'doklObch',
31			'nabidka-vydana' => 'doklObch',
32			'objednavka-vydana' => 'doklObch', 'nabidka-prijata' => 'doklObch',
33			'skladovy-pohyb' => 'doklSklad',
34			'cenik' => 'cenik',
35			'adresar' => 'adresar', 'kontakt' => 'kontakt'
36			];
37
38			public function attachFile($filepath, $attachmentData = [])
39			{
40			if (file_exists($filepath)) {
41			$attachmentData['nazSoub'] = basename($filepath);
42			$attachmentData['contentType'] = mime_content_type($filepath);
43			$attachmentData['dataSize'] = filesize($filepath);
44			$attachmentData['dataHash'] = md5_file($filepath);
45
46			switch ($attachmentData['contentType']) {
47			case 'image/png':
48			case 'image/gif':
49			case 'image/jpeg':
			0 ignored issues – show Coding Style introduced 2017-03-19 23:23 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
50
51			break;
52			}
53			$attachmentData['content'] = base64_encode(file_get_contents($filepath));
54			}
55			}
56
57			/**
58			* Obtain url for Attachment Download
59			*
60			* @return string url
61			*/
62			public static function getDownloadUrl($object)
63			{
64			return $object->apiURL.'/content';
65			}
66
67			public function getFirsAttachment($object)
68			{
69			$attachments = self::getAttachmentsList($object);
70			return count($attachments) ? current($attachments) : null;
71			}
72
73			public static function download($object, $attachmentID = null)
			0 ignored issues – show Unused Code introduced 2017-03-19 23:23 UTC by Report Bug Copy Issue Report The parameter `$attachmentID` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
74			{
75			header('Content-Description: File Transfer');
76			header('Content-Type: application/octet-stream');
77			header('Content-Transfer-Encoding: binary');
78			header('Expires: 0');
79			header('Cache-Control: must-revalidate, post-check=0, pre-check=0');
80			header('Pragma: public');
81			header('Content-Disposition: attachment; filename='.$this->host->getName().'_nrpe.sh');
			0 ignored issues – show Bug introduced 2017-03-19 23:23 UTC by Report Bug Copy Issue Report The property `host` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-03-19 23:23 UTC by Report Bug Copy Issue Report The variable `$this` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
82			header('Content-Length: '.strlen($nrpesh));
			0 ignored issues – show Bug introduced 2017-03-19 23:23 UTC by Report Bug Copy Issue Report The variable `$nrpesh` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
83			echo $object;
84			}
85
86			public static function saveToFile($object, $filename, $attachmentID = null)
			0 ignored issues – show Unused Code introduced 2017-03-19 23:23 UTC by Report Bug Copy Issue Report The parameter `$object` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-03-19 23:23 UTC by Report Bug Copy Issue Report The parameter `$filename` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-03-19 23:23 UTC by Report Bug Copy Issue Report The parameter `$attachmentID` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
87			{
88
89			}
90
91			/**
92			* Add Attachment from File
93			*
94			* @param FlexiBeeRW $object
95			* @param string $filename
96			*
97			* @return int HTTP response code
98			*/
99			public static function addAttachmentFromFile($object, $filename)
100			{
101			return self::addAttachment($object, basename($filename),
102			file_get_contents($filename), mime_content_type($filename));
103			}
104
105			/**
106			* Add Attachment related to current $object content
107			*
108			* @param FlexiBeeRW $object
109			* @param string $filename
110			* @param string $attachment Body
111			* @param string $contentType Attachment Content-Type
112			*
113			* @return int HTTP Response code
114			*/
115			public static function addAttachment($object, $filename, $attachment,
116			$contentType)
117			{
118			$headersBackup = $object->defaultHttpHeaders;
119			$object->postFields = $attachment;
120			$object->defaultHttpHeaders['Content-Type'] = $contentType;
121			$url = $object->getFlexiBeeURL().'/prilohy/new/'.$filename;
122			$response = $object->doCurlRequest($url,
123			'PUT');
			0 ignored issues – show Documentation introduced 2017-03-19 23:23 UTC by Report Bug Copy Issue Report `'PUT'` is of type `string`, but the function expects a `object<FlexiPeeHP\strinf>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
124			$object->defaultHttpHeaders = $headersBackup;
125			return $response;
126			}
127
128			/**
129			* Obtain Record related attachments list
130			*
131			* @param FlexiBeeRO $object
132			* @return array
133			*/
134			public static function getAttachmentsList($object)
135			{
136			return $object->getFlexiData($object->getFlexiBeeURL().'/prilohy');
137			}
138			}
139

Spoje-NET / FlexiPeeHP

Push — master ( bb67b0...f67d68 )

Priloha::saveToFile() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like