Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | class Manager extends AbstractResource |
||
13 | { |
||
14 | /** |
||
15 | * Get a manager. |
||
16 | * |
||
17 | * @param string $id The manager UUID. |
||
18 | * @return ManagerModel |
||
19 | */ |
||
20 | View Code Duplication | public function getManager($id) |
|
30 | |||
31 | /** |
||
32 | * Get the manager for the user owing the API key. |
||
33 | * |
||
34 | * @return ManagerModel |
||
35 | */ |
||
36 | public function getMyManager() |
||
40 | } |
||
41 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.