Speicher210 /
fastbill-api
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | View Code Duplication | final class RequestData extends AbstractRequestData |
|
|
|
|||
| 12 | { |
||
| 13 | /** |
||
| 14 | * The subscription ID. |
||
| 15 | * |
||
| 16 | * @var integer |
||
| 17 | * |
||
| 18 | * @JMS\Type("integer") |
||
| 19 | * @JMS\SerializedName("SUBSCRIPTION_ID") |
||
| 20 | */ |
||
| 21 | protected $subscriptionId; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * The subscription start. |
||
| 25 | * |
||
| 26 | * @var \DateTime |
||
| 27 | * |
||
| 28 | * @JMS\Type("DateTime<'Y-m-d H:i:s'>") |
||
| 29 | * @JMS\SerializedName("START") |
||
| 30 | */ |
||
| 31 | protected $subscriptionStart; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * The subscription end. |
||
| 35 | * |
||
| 36 | * @var \DateTime |
||
| 37 | * |
||
| 38 | * @JMS\Type("DateTime<'Y-m-d H:i:s'>") |
||
| 39 | * @JMS\SerializedName("END") |
||
| 40 | */ |
||
| 41 | protected $subscriptionEnd; |
||
| 42 | |||
| 43 | /** |
||
| 44 | * Constructor. |
||
| 45 | * |
||
| 46 | * @param integer $subscriptionId The subscription ID. |
||
| 47 | */ |
||
| 48 | 3 | public function __construct($subscriptionId) |
|
| 52 | |||
| 53 | /** |
||
| 54 | * Get the subscription ID. |
||
| 55 | * |
||
| 56 | * @return integer |
||
| 57 | */ |
||
| 58 | 3 | public function getSubscriptionId() |
|
| 62 | |||
| 63 | /** |
||
| 64 | * Set the subscription ID. |
||
| 65 | * |
||
| 66 | * @param integer $subscriptionId The subscription ID. |
||
| 67 | * @return RequestData |
||
| 68 | */ |
||
| 69 | 3 | public function setSubscriptionId($subscriptionId) |
|
| 75 | |||
| 76 | /** |
||
| 77 | * Get the subscription start. |
||
| 78 | * |
||
| 79 | * @return \DateTime |
||
| 80 | */ |
||
| 81 | 3 | public function getSubscriptionStart() |
|
| 85 | |||
| 86 | /** |
||
| 87 | * Set the subscription start. |
||
| 88 | * |
||
| 89 | * @param \DateTime $subscriptionStart The subscription start. |
||
| 90 | * @return RequestData |
||
| 91 | */ |
||
| 92 | 3 | public function setSubscriptionStart($subscriptionStart) |
|
| 98 | |||
| 99 | /** |
||
| 100 | * Get the subscription end. |
||
| 101 | * |
||
| 102 | * @return \DateTime |
||
| 103 | */ |
||
| 104 | 3 | public function getSubscriptionEnd() |
|
| 108 | |||
| 109 | /** |
||
| 110 | * Set the subscription end. |
||
| 111 | * |
||
| 112 | * @param \DateTime $subscriptionEnd The subscription end. |
||
| 113 | * @return RequestData |
||
| 114 | */ |
||
| 115 | 3 | public function setSubscriptionEnd($subscriptionEnd) |
|
| 121 | } |
||
| 122 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.