DayBuilder::fromArray() - Code Metrics - Inspection of "Added DayBuilder" - Speicher210/business-hours - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 62bde9...a3c5fc )

by Dragos

created 2016-04-06 10:12 UTC

DayBuilder::fromArray() C

↳ Parent: DayBuilder

Complexity

Conditions	11
Paths	4

Size

Total Lines	27
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	27
rs	5.2653
cc	11
eloc	17
nc	4
nop	1

How to fix Complexity

<?php

namespace Speicher210\BusinessHours;

/**
 * Build a DayInterface concrete implementation.
 */
class DayBuilder
{
    /**
     * Create a DayInterface object from an array.
     *
     * @param array $data The day data.
     * @return DayInterface
     */
    public static function fromArray(array $data)
    {
        if (!isset($data['openingIntervals']) || !is_array($data['openingIntervals']) || !isset($data['dayOfWeek'])) {
            throw new \InvalidArgumentException('Array is not valid.');
        }

        if (count($data['openingIntervals']) === 1 && self::isIntervalArrayAllDay(reset($data['openingIntervals']))) {
            return new AllDay($data['dayOfWeek']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        $openingIntervals = array();
        foreach ($data['openingIntervals'] as $openingInterval) {
            $start = new Time(
                $openingInterval['start']['hours'],
                isset($openingInterval['start']['minutes']) ? $openingInterval['start']['minutes'] : 0,
                isset($openingInterval['start']['seconds']) ? $openingInterval['start']['seconds'] : 0
            );
            $end = new Time(
                $openingInterval['end']['hours'],
                isset($openingInterval['end']['minutes']) ? $openingInterval['end']['minutes'] : 0,
                isset($openingInterval['end']['seconds']) ? $openingInterval['end']['seconds'] : 0
            );
            $openingIntervals[] = array($start, $end);
        }

        return new Day($data['dayOfWeek'], $openingIntervals);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Check if an interval array is all day.
     *
     * @param array $data The interval as an array to check.
     * @return boolean
     */
    private static function isIntervalArrayAllDay(array $data)
    {
        if ($data['start']['hours'] != 0 || $data['end']['hours'] != 24) {
            return false;
        }

        if (isset($data['start']['minutes']) && $data['start']['minutes'] != 0) {

            return false;
        }

        if (isset($data['end']['minutes']) && $data['end']['minutes'] != 0) {

            return false;
        }


        if (isset($data['start']['seconds']) && $data['start']['seconds'] != 0) {

            return false;
        }

        if (isset($data['end']['seconds']) && $data['end']['seconds'] != 0) {

            return false;
        }

        return true;
    }
}

1		<?php
2
3		namespace Speicher210\BusinessHours;
4
5		/**
6		* Build a DayInterface concrete implementation.
7		*/
8		class DayBuilder
9		{
10		/**
11		* Create a DayInterface object from an array.
12		*
13		* @param array $data The day data.
14		* @return DayInterface
15		*/
16		public static function fromArray(array $data)
17		{
18		if (!isset($data['openingIntervals']) \|\| !is_array($data['openingIntervals']) \|\| !isset($data['dayOfWeek'])) {
19		throw new \InvalidArgumentException('Array is not valid.');
20		}
21
22		if (count($data['openingIntervals']) === 1 && self::isIntervalArrayAllDay(reset($data['openingIntervals']))) {
23		return new AllDay($data['dayOfWeek']);
		0 ignored issues – show Documentation introduced 2016-04-06 10:25 UTC by Report Bug Copy Issue Report `$data['dayOfWeek']` is of type `array`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
24		}
25
26		$openingIntervals = array();
27		foreach ($data['openingIntervals'] as $openingInterval) {
28		$start = new Time(
29		$openingInterval['start']['hours'],
30		isset($openingInterval['start']['minutes']) ? $openingInterval['start']['minutes'] : 0,
31		isset($openingInterval['start']['seconds']) ? $openingInterval['start']['seconds'] : 0
32		);
33		$end = new Time(
34		$openingInterval['end']['hours'],
35		isset($openingInterval['end']['minutes']) ? $openingInterval['end']['minutes'] : 0,
36		isset($openingInterval['end']['seconds']) ? $openingInterval['end']['seconds'] : 0
37		);
38		$openingIntervals[] = array($start, $end);
39		}
40
41		return new Day($data['dayOfWeek'], $openingIntervals);
		0 ignored issues – show Documentation introduced 2016-04-06 10:25 UTC by Report Bug Copy Issue Report `$data['dayOfWeek']` is of type `array`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42		}
43
44		/**
45		* Check if an interval array is all day.
46		*
47		* @param array $data The interval as an array to check.
48		* @return boolean
49		*/
50		private static function isIntervalArrayAllDay(array $data)
51		{
52		if ($data['start']['hours'] != 0 \|\| $data['end']['hours'] != 24) {
53		return false;
54		}
55
56	View Code Duplication	if (isset($data['start']['minutes']) && $data['start']['minutes'] != 0) {
		0 ignored issues – show Duplication introduced 2016-04-06 10:25 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		return false;
58		}
59
60	View Code Duplication	if (isset($data['end']['minutes']) && $data['end']['minutes'] != 0) {
		0 ignored issues – show Duplication introduced 2016-04-06 10:25 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61		return false;
62		}
63
64
65	View Code Duplication	if (isset($data['start']['seconds']) && $data['start']['seconds'] != 0) {
		0 ignored issues – show Duplication introduced 2016-04-06 10:25 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		return false;
67		}
68
69	View Code Duplication	if (isset($data['end']['seconds']) && $data['end']['seconds'] != 0) {
		0 ignored issues – show Duplication introduced 2016-04-06 10:25 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70		return false;
71		}
72
73		return true;
74		}
75		}

GitHub Access Token became invalid

Push — master ( 62bde9...a3c5fc )

DayBuilder::fromArray() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Speicher210 / business-hours

GitHub Access Token became invalid

Push — master ( 62bde9...a3c5fc )

DayBuilder::fromArray() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like