ClosureVoter::prepareResult() - Code Metrics - Inspection of "Use spareparts/enum" - SpareParts/Overseer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6)

by Ondrej

created 2017-01-09 09:22 UTC

ClosureVoter::prepareResult() A

↳ Parent: ClosureVoter

Complexity

Conditions	4
Paths	4

Size

Total Lines	14
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	6.5971

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	5
cts	11
cp	0.4545
rs	9.2
c	0
b	0
f	0
cc	4
eloc	11
nc	4
nop	1
crap	6.5971

<?php

namespace SpareParts\Overseer\Voter;


use SpareParts\Overseer\Context\IVotingContext;
use SpareParts\Overseer\VotingDecisionEnum;

class ClosureVoter implements IVoter
{
    /**
     * @var \Closure
     */
    private $authorizationClosure;


    /**
     * ClosureVoter constructor.
     * @param \Closure $authorizationClosure
     */
    public function __construct(\Closure $authorizationClosure)
    {
        $this->authorizationClosure = $authorizationClosure;
    }


    /**
     * @param mixed $votingSubject
     * @param \SpareParts\Overseer\Context\IVotingContext $votingContext
     * @return ISingleVoterResult
     */
    public function vote($votingSubject, IVotingContext $votingContext)
    {
        $closure = $this->authorizationClosure;
        $result = $closure($votingSubject, $votingContext);

        $result = $this->prepareResult($result);

        return $result;
    }


    /**
     * @param mixed $result
     * @return SingleVoterResult
     */
    public function prepareResult($result)
    {
        if ($result === true) {
            $result = new SingleVoterResult(VotingDecisionEnum::ALLOWED());
            return $result;
        } elseif ($result === false) {
            $result = new SingleVoterResult(VotingDecisionEnum::DENIED());
            return $result;
        } elseif ($result instanceof VotingDecisionEnum) {
            $result = new SingleVoterResult($result);
            return $result;
        }
        return $result;
    }
}


1		<?php
2
3		namespace SpareParts\Overseer\Voter;
4
5
6		use SpareParts\Overseer\Context\IVotingContext;
7		use SpareParts\Overseer\VotingDecisionEnum;
8
9		class ClosureVoter implements IVoter
10		{
11		/**
12		* @var \Closure
13		*/
14		private $authorizationClosure;
15
16
17		/**
18		* ClosureVoter constructor.
19		* @param \Closure $authorizationClosure
20		*/
21	3	public function __construct(\Closure $authorizationClosure)
22		{
23	3	$this->authorizationClosure = $authorizationClosure;
24	3	}
25
26
27		/**
28		* @param mixed $votingSubject
29		* @param \SpareParts\Overseer\Context\IVotingContext $votingContext
30		* @return ISingleVoterResult
31		*/
32	2	public function vote($votingSubject, IVotingContext $votingContext)
33		{
34	2	$closure = $this->authorizationClosure;
35	2	$result = $closure($votingSubject, $votingContext);
36
37	2	$result = $this->prepareResult($result);
38
39	2	return $result;
40		}
41
42
43		/**
44		* @param mixed $result
45		* @return SingleVoterResult
46		*/
47	2	public function prepareResult($result)
48		{
49	2	if ($result === true) {
50		$result = new SingleVoterResult(VotingDecisionEnum::ALLOWED());
51		return $result;
52	2	} elseif ($result === false) {
53		$result = new SingleVoterResult(VotingDecisionEnum::DENIED());
54		return $result;
55	2	} elseif ($result instanceof VotingDecisionEnum) {
56		$result = new SingleVoterResult($result);
57		return $result;
58		}
59	2	return $result;
60		}
61		}
62

SpareParts / Overseer

Pull Request — master (#6)

ClosureVoter::prepareResult() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like