SpareParts\Enum\Mapping\Annotations

Complexity

Total Complexity

5

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Test Coverage

Coverage

81.82%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	loadEnumValues()	0	11	3
A	getAnalyzer()	0	6	2

<?php declare(strict_types=1);
namespace SpareParts\Enum\Mapping;

use Doctrine\Common\Annotations\AnnotationReader;

The type Doctrine\Common\Annotations\AnnotationReader was not found. Maybe you did not declare it correctly or list all dependencies?

use Doctrine\Common\Annotations\Reader;

The type Doctrine\Common\Annotations\Reader was not found. Maybe you did not declare it correctly or list all dependencies?

class Annotations
{
    /** @var AnnotationsAnalyzer */
    static private $analyzer;


    /**
     * @return string[]
     * @throws \InvalidArgumentException
     */
    public static function loadEnumValues(string $classname): array
    {
        try {
            $reflection = new \ReflectionClass($classname);
        } catch (\ReflectionException $exception) {
            throw new \InvalidArgumentException("Problem with fetching reflection of class: `" . var_export($classname, true) . "`", 0, $exception);
        }

        $analyzer = static::getAnalyzer();
        $docblock = $reflection->getDocComment() ?: '';
        return $analyzer->analyzeValuesFromDocblock($docblock);

It seems like $docblock can also be of type true; however, parameter $classdocblock of SpareParts\Enum\Mapping\AnnotationsAnalyzer::analyzeValuesFromDocblock() does only seem to accept string, maybe add an additional type check?

    }

    private static function getAnalyzer(): AnnotationsAnalyzer
    {
        if (!static::$analyzer) {

Since $analyzer is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $analyzer to at least protected.

            static::$analyzer = new AnnotationsAnalyzer();
        }
        return static::$analyzer;
    }

}