SpareParts\Enum\Set\Converter\StringSerializeConverter

Complexity

Total Complexity

6

Size/Duplication

Total Lines	47
Duplicated Lines	38.3 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	7	7	2
A	convertToEnumSet()	11	11	2
A	convertFromEnumSet()	0	8	2

<?php

namespace SpareParts\Enum\Set\Converter;


use SpareParts\Enum\Enum;
use SpareParts\Enum\Exception\InvalidEnumClassException;
use SpareParts\Enum\Set\ISet;
use SpareParts\Enum\Set\ImmutableSet;

class StringSerializeConverter implements IEnumSetConverter
{
    /**
     * @var string
     */
    private $enumClass;

    /**
     * @param string $enumClass
     */
    public function __construct($enumClass)

This method seems to be duplicated in your project.

    {
        if (!is_subclass_of($enumClass, Enum::class)) {

Due to PHP Bug #53727, is_subclass_of might return inconsistent results on some PHP versions if \SpareParts\Enum\Enum::class can be an interface. If so, you could instead use ReflectionClass::implementsInterface.

            throw new InvalidEnumClassException("Class ${enumClass} does not implement Enum (as it should).");
        }
        $this->enumClass = $enumClass;
    }

    /**
     * @param string $serialized
     * @return ImmutableSet
     */
    public function convertToEnumSet($serialized)

This method seems to be duplicated in your project.

    {
        $serialized = (string) $serialized;
        $stringList = unserialize($serialized);

        $set = [];
        foreach ($stringList as $value) {
            $set[] = call_user_func([$this->enumClass, 'instance'], $value);
        }
        return new ImmutableSet($this->enumClass, $set);
    }

    /**
     * @param ISet $enumSet
     * @return string
     */
    public function convertFromEnumSet(ISet $enumSet)
    {
        $stringList = [];
        foreach ($enumSet as $enum) {
            $stringList[] = (string) $enum;
        }
        return serialize($stringList);
    }
}