Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
21 | class MapConverter implements IConverter |
||
22 | { |
||
23 | /** |
||
24 | * @var array mapValue => enumInstance |
||
25 | */ |
||
26 | protected $scalarMap = []; |
||
27 | |||
28 | /** |
||
29 | * @var array enumString => mapValue |
||
30 | */ |
||
31 | protected $enumMap = []; |
||
32 | |||
33 | /** |
||
34 | * @param array $map |
||
35 | * @throws ConverterSetupException |
||
36 | */ |
||
37 | 6 | public function __construct(array $map) |
|
48 | |||
49 | /** |
||
50 | * @param mixed $value |
||
51 | * @return Enum |
||
52 | * @throws UnableToConvertException |
||
53 | */ |
||
54 | 3 | public function toEnum($value) |
|
66 | |||
67 | /** |
||
68 | * @param Enum $enum |
||
69 | * @return string |
||
70 | * @throws UnableToConvertException |
||
71 | */ |
||
72 | 2 | public function fromEnum(Enum $enum) |
|
87 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.