Soullivaneuh /
composer-versions-check
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 4 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.
There are several approaches to avoid long parameter lists:
| 1 | <?php |
||
| 9 | public function getMock($originalClassName, $methods = [], $arguments = [], $mockClassName = '', $callOriginalConstructor = true, $callOriginalClone = true, $callAutoload = true, $cloneArguments = false, $callOriginalMethods = false, $proxyTarget = mull) |
||
| 10 | { |
||
| 11 | return $this->getMockBuilder($originalClassName)->getMock(); |
||
| 12 | } |
||
| 13 | } |
||
| 19 |
This check looks for classes that have been defined more than once in the same file.
If you can, we would recommend to use standard object-oriented programming techniques. For example, to avoid multiple types, it might make sense to create a common interface, and then multiple, different implementations for that interface.
This also has the side-effect of providing you with better IDE auto-completion, static analysis and also better OPCode caching from PHP.