SLLH\IsoCodesValidator\AbstractIsoCodesConstraintValidator

Complexity

Total Complexity

8

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	validate()	0	19	7
A	createViolation()	0	5	1

<?php

namespace SLLH\IsoCodesValidator;

use SLLH\IsoCodesValidator\Constraints\IsoCodesGeneric;
use SLLH\IsoCodesValidator\Constraints\IsoCodesGenericValidator;
use SLLH\IsoCodesValidator\Exception\ValidatorNotExistsException;
use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator;
use Symfony\Component\Validator\Context\ExecutionContext;
use Symfony\Component\Validator\Context\ExecutionContextInterface;
use Symfony\Component\Validator\Exception\UnexpectedTypeException;

/**
 * @author Sullivan Senechal <soullivaneuh@gmail.com>
 */
abstract class AbstractIsoCodesConstraintValidator extends ConstraintValidator
{
    /**
     * Override PHP doc block to get IDE completion.
     * Can be removed when `buildViolation` would be added on ExecutionContextInterface.
     * Should probably done in Symfony 3.0.
     *
     * @var ExecutionContextInterface|ExecutionContext
     */
    protected $context;

    /**
     * {@inheritdoc}
     */
    public function validate($value, Constraint $constraint)
    {
        $validatorClass = get_class($this);
        if (IsoCodesGenericValidator::class === $validatorClass
            && !($constraint instanceof AbstractIsoCodesGenericConstraint || $constraint instanceof IsoCodesGeneric)

The class SLLH\IsoCodesValidator\Constraints\IsoCodesGeneric does not exist. Did you forget a USE statement, or did you not list all dependencies?

        ) {
            throw new UnexpectedTypeException($constraint, AbstractIsoCodesGenericConstraint::class);
        } elseif (IsoCodesGenericValidator::class !== $validatorClass) {
            $constraintClass = preg_replace('/Validator$/', '', $validatorClass);

            if (!$constraint instanceof $constraintClass) {
                throw new UnexpectedTypeException($constraint, $constraintClass);
            }
        }

        if (!class_exists($constraint->getIsoCodesClass())) {

It seems like you code against a specific sub-type and not the parent class Symfony\Component\Validator\Constraint as the method getIsoCodesClass() does only exist in the following sub-classes of Symfony\Component\Validator\Constraint: SLLH\IsoCodesValidator\AbstractConstraint, SLLH\IsoCodesValidator\AbstractIsoCodesGenericConstraint, SLLH\IsoCodesValidator\Constraints\Bban, SLLH\IsoCodesValidator\Constraints\Cif, SLLH\IsoCodesValidator\Constraints\CreditCard, SLLH\IsoCodesValidator\Constraints\Ean13, SLLH\IsoCodesValidator\Constraints\Ean8, SLLH\IsoCodesValidator\Constraints\Iban, SLLH\IsoCodesValidator\Constraints\Insee, SLLH\IsoCodesValidator\Constraints\Ip, SLLH\IsoCodesValidator\Constraints\Isbn, SLLH\IsoCodesValidator\Constraints\Mac, SLLH\IsoCodesValidator\Constraints\Nif, SLLH\IsoCodesValidator\Constraints\Siren, SLLH\IsoCodesValidator\Constraints\Siret, SLLH\IsoCodesValidator\Constraints\Ssn, SLLH\IsoCodesValidator\Constraints\StructuredCommunication, SLLH\IsoCodesValidator\Constraints\SwiftBic, SLLH\IsoCodesValidator\Constraints\Uknin, SLLH\IsoCodesValidator\Constraints\Vat, SLLH\IsoCodesValidator\Constraints\ZipCode. Maybe you want to instanceof check for one of these explicitly?

            throw new ValidatorNotExistsException($constraint);

$constraint is of type object<Symfony\Component\Validator\Constraint>, but the function expects a object<SLLH\IsoCodesValidator\ConstraintInterface>.

        }
    }

    /**
     * Makes and adds a Constraint violation.
     *
     * @param string $message
     */
    protected function createViolation($message)
    {
        $this->context->buildViolation($message)
            ->addViolation();
    }
}