Issues in ParserTest.php (master) - Issues in master - SomeBlackMagic/phpmd - Measure and Improve Code Quality continuously with Scrutinizer

Issues (575)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/php/PHPMD/ParserTest.php (16 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This file is part of PHP Mess Detector.
 *
 * Copyright (c) Manuel Pichler <[email protected]>.
 * All rights reserved.
 *
 * Licensed under BSD License
 * For full copyright and license information, please see the LICENSE file.
 * Redistributions of files must retain the above copyright notice.
 *
 * @author Manuel Pichler <[email protected]>
 * @copyright Manuel Pichler. All rights reserved.
 * @license https://opensource.org/licenses/bsd-license.php BSD License
 * @link http://phpmd.org/
 */

namespace PHPMD;

use PDepend\Source\Parser\InvalidStateException;
use PDepend\Source\AST\ASTCompilationUnit;
use PDepend\Source\AST\ASTMethod;
use PDepend\Source\AST\ASTFunction;
use PDepend\Source\AST\ASTClass;
use PDepend\Engine;
use PHPMD\Node\FunctionNode;
use PHPMD\Node\MethodNode;
use PHPMD\Node\ClassNode;

/**
 * Test case for the PHP_Depend backend adapter class.
 *
 * @covers \PHPMD\Parser
 */
class ParserTest extends AbstractTest
{
    /**
     * Tests that the metrics adapter delegates a node to a registered rule-set.
     *
     * @return void
     */
    public function testAdapterDelegatesClassNodeToRuleSet()

    {
        $mock = $this->getPHPDependClassMock();
        $mock->expects($this->once())

            ->method('isUserDefined')
            ->willReturn(true);

        $adapter = new Parser($this->getPHPDependMock());
        $adapter->addRuleSet($this->getRuleSetMock(ClassNode::class));
        $adapter->setReport($this->getReportMock(0));
        $adapter->visitClass($mock);
    }

    /**
     * Tests that the metrics adapter does not delegate a node without source
     * code file to a registered rule-set.
     *
     * @return void
     */
    public function testAdapterDoesNotDelegateNonSourceClassNodeToRuleSet()

    {
        $mock = $this->getPHPDependClassMock();
        $mock->expects($this->once())

            ->method('isUserDefined')
            ->willReturn(false);

        $adapter = new Parser($this->getPHPDependMock());
        $adapter->addRuleSet($this->getRuleSetMock());
        $adapter->setReport($this->getReportMock(0));
        $adapter->visitClass($mock);
    }

    /**
     * Tests that the metrics adapter delegates a node to a registered rule-set.
     *
     * @return void
     */
    public function testAdapterDelegatesMethodNodeToRuleSet()

    {
        $adapter = new Parser($this->getPHPDependMock());
        $adapter->addRuleSet($this->getRuleSetMock(MethodNode::class));
        $adapter->setReport($this->getReportMock(0));
        $adapter->visitMethod($this->getPHPDependMethodMock());
    }

    /**
     * Tests that the metrics adapter does not delegate a node without source
     * code file to a registered rule-set.
     *
     * @return void
     */
    public function testAdapterDoesNotDelegateNonSourceMethodNodeToRuleSet()

    {
        $adapter = new Parser($this->getPHPDependMock());
        $adapter->addRuleSet($this->getRuleSetMock());
        $adapter->setReport($this->getReportMock(0));
        $adapter->visitMethod($this->getPHPDependMethodMock(null));
    }

    /**
     * Tests that the metrics adapter delegates a node to a registered rule-set.
     *
     * @return void
     */
    public function testAdapterDelegatesFunctionNodeToRuleSet()

    {
        $adapter = new Parser($this->getPHPDependMock());
        $adapter->addRuleSet($this->getRuleSetMock(FunctionNode::class));
        $adapter->setReport($this->getReportMock(0));
        $adapter->visitFunction($this->getPHPDependFunctionMock());
    }

    /**
     * Tests that the metrics adapter does not delegate a node without source
     * code file to a registered rule-set.
     *
     * @return void
     */
    public function testAdapterDoesNotDelegateNonSourceFunctionNodeToRuleSet()

    {
        $adapter = new Parser($this->getPHPDependMock());
        $adapter->addRuleSet($this->getRuleSetMock());
        $adapter->setReport($this->getReportMock(0));
        $adapter->visitFunction($this->getPHPDependFunctionMock(null));
    }

    /**
     * testParserStoreParsingExceptionsInReport
     *
     * @return void
     * @since 1.2.1
     */
    public function testParserStoreParsingExceptionsInReport()
    {
        $report = $this->getReportMock(0);
        $report->expects($this->once())
            ->method('addError');

        $pdepend = $this->getPHPDependMock();
        $pdepend->expects($this->once())

            ->method('getExceptions')
            ->willReturn(array(
                new InvalidStateException(42, __FILE__, 'foo')
            ));

        $parser = new Parser($pdepend);
        $parser->parse($report);
    }

    /**
     * Creates a mocked PDepend instance.
     *
     * @return \PDepend\Engine
     */
    private function getPHPDependMock()
    {
        return $this->getMock(Engine::class, array(), array(null), '', false);

    }

    /**
     * Creates a mocked PDepend class instance.
     *
     * @return \PDepend\Source\AST\ASTClass
     */
    protected function getPHPDependClassMock()
    {
        $class = $this->getMock(ASTClass::class, array(), array(null));

        $class
            ->method('getCompilationUnit')
            ->willReturn($this->getPHPDependFileMock('foo.php'));
        $class
            ->method('getConstants')
            ->willReturn(new \ArrayIterator(array()));
        $class
            ->method('getProperties')
            ->willReturn(new \ArrayIterator(array()));
        $class
            ->method('getMethods')
            ->willReturn(new \ArrayIterator(array()));

        return $class;
    }

    /**
     * Creates a mocked PHP_Depend function instance.
     *
     * @param string $fileName Optional file name for the source file.
     * @return PHP_Depend_Code_Function
     */
    protected function getPHPDependFunctionMock($fileName = '/foo/bar.php')

    {
        $function = $this->getMock(ASTFunction::class, array(), array(null));

        $function->expects($this->atLeastOnce())
            ->method('getCompilationUnit')
            ->willReturn($this->getPHPDependFileMock($fileName));

        return $function;
    }

    /**
     * Creates a mocked PHP_Depend method instance.
     *
     * @param string $fileName Optional file name for the source file.
     * @return PHP_Depend_Code_CodeMethod
     */
    protected function getPHPDependMethodMock($fileName = '/foo/bar.php')

    {
        $method = $this->getMock(ASTMethod::class, array(), array(null));

        $method->expects($this->atLeastOnce())
            ->method('getCompilationUnit')
            ->willReturn($this->getPHPDependFileMock($fileName));

        return $method;
    }

    /**
     * Creates a mocked PHP_Depend file instance.
     *
     * @param string $fileName The temporary file name.
     * @return PHP_Depend_Code_File
     */
    protected function getPHPDependFileMock($fileName)
    {
        $file = $this->getMock(ASTCompilationUnit::class, array(), array(null));

        $file
            ->method('getFileName')
            ->willReturn($fileName);

        return $file;
    }
}


1		<?php
2		/**
3		* This file is part of PHP Mess Detector.
4		*
5		* Copyright (c) Manuel Pichler <[email protected]>.
6		* All rights reserved.
7		*
8		* Licensed under BSD License
9		* For full copyright and license information, please see the LICENSE file.
10		* Redistributions of files must retain the above copyright notice.
11		*
12		* @author Manuel Pichler <[email protected]>
13		* @copyright Manuel Pichler. All rights reserved.
14		* @license https://opensource.org/licenses/bsd-license.php BSD License
15		* @link http://phpmd.org/
16		*/
17
18		namespace PHPMD;
19
20		use PDepend\Source\Parser\InvalidStateException;
21		use PDepend\Source\AST\ASTCompilationUnit;
22		use PDepend\Source\AST\ASTMethod;
23		use PDepend\Source\AST\ASTFunction;
24		use PDepend\Source\AST\ASTClass;
25		use PDepend\Engine;
26		use PHPMD\Node\FunctionNode;
27		use PHPMD\Node\MethodNode;
28		use PHPMD\Node\ClassNode;
29
30		/**
31		* Test case for the PHP_Depend backend adapter class.
32		*
33		* @covers \PHPMD\Parser
34		*/
35		class ParserTest extends AbstractTest
36		{
37		/**
38		* Tests that the metrics adapter delegates a node to a registered rule-set.
39		*
40		* @return void
41		*/
42	View Code Duplication	public function testAdapterDelegatesClassNodeToRuleSet()
		0 ignored issues – show Duplication introduced 2019-01-15 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		$mock = $this->getPHPDependClassMock();
45		$mock->expects($this->once())
		0 ignored issues – show Bug introduced 2019-01-15 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<PDepend\Source\AST\ASTClass>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
46		->method('isUserDefined')
47		->willReturn(true);
48
49		$adapter = new Parser($this->getPHPDependMock());
50		$adapter->addRuleSet($this->getRuleSetMock(ClassNode::class));
51		$adapter->setReport($this->getReportMock(0));
52		$adapter->visitClass($mock);
53		}
54
55		/**
56		* Tests that the metrics adapter does not delegate a node without source
57		* code file to a registered rule-set.
58		*
59		* @return void
60		*/
61	View Code Duplication	public function testAdapterDoesNotDelegateNonSourceClassNodeToRuleSet()
		0 ignored issues – show Duplication introduced 2019-01-15 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62		{
63		$mock = $this->getPHPDependClassMock();
64		$mock->expects($this->once())
		0 ignored issues – show Bug introduced 2019-01-15 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<PDepend\Source\AST\ASTClass>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
65		->method('isUserDefined')
66		->willReturn(false);
67
68		$adapter = new Parser($this->getPHPDependMock());
69		$adapter->addRuleSet($this->getRuleSetMock());
70		$adapter->setReport($this->getReportMock(0));
71		$adapter->visitClass($mock);
72		}
73
74		/**
75		* Tests that the metrics adapter delegates a node to a registered rule-set.
76		*
77		* @return void
78		*/
79	View Code Duplication	public function testAdapterDelegatesMethodNodeToRuleSet()
		0 ignored issues – show Duplication introduced 2019-01-15 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
80		{
81		$adapter = new Parser($this->getPHPDependMock());
82		$adapter->addRuleSet($this->getRuleSetMock(MethodNode::class));
83		$adapter->setReport($this->getReportMock(0));
84		$adapter->visitMethod($this->getPHPDependMethodMock());
85		}
86
87		/**
88		* Tests that the metrics adapter does not delegate a node without source
89		* code file to a registered rule-set.
90		*
91		* @return void
92		*/
93	View Code Duplication	public function testAdapterDoesNotDelegateNonSourceMethodNodeToRuleSet()
		0 ignored issues – show Duplication introduced 2019-01-15 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
94		{
95		$adapter = new Parser($this->getPHPDependMock());
96		$adapter->addRuleSet($this->getRuleSetMock());
97		$adapter->setReport($this->getReportMock(0));
98		$adapter->visitMethod($this->getPHPDependMethodMock(null));
99		}
100
101		/**
102		* Tests that the metrics adapter delegates a node to a registered rule-set.
103		*
104		* @return void
105		*/
106	View Code Duplication	public function testAdapterDelegatesFunctionNodeToRuleSet()
		0 ignored issues – show Duplication introduced 2019-01-15 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
107		{
108		$adapter = new Parser($this->getPHPDependMock());
109		$adapter->addRuleSet($this->getRuleSetMock(FunctionNode::class));
110		$adapter->setReport($this->getReportMock(0));
111		$adapter->visitFunction($this->getPHPDependFunctionMock());
112		}
113
114		/**
115		* Tests that the metrics adapter does not delegate a node without source
116		* code file to a registered rule-set.
117		*
118		* @return void
119		*/
120	View Code Duplication	public function testAdapterDoesNotDelegateNonSourceFunctionNodeToRuleSet()
		0 ignored issues – show Duplication introduced 2019-01-15 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
121		{
122		$adapter = new Parser($this->getPHPDependMock());
123		$adapter->addRuleSet($this->getRuleSetMock());
124		$adapter->setReport($this->getReportMock(0));
125		$adapter->visitFunction($this->getPHPDependFunctionMock(null));
126		}
127
128		/**
129		* testParserStoreParsingExceptionsInReport
130		*
131		* @return void
132		* @since 1.2.1
133		*/
134		public function testParserStoreParsingExceptionsInReport()
135		{
136		$report = $this->getReportMock(0);
137		$report->expects($this->once())
138		->method('addError');
139
140		$pdepend = $this->getPHPDependMock();
141		$pdepend->expects($this->once())
		0 ignored issues – show Bug introduced 2019-01-15 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<PDepend\Engine>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
142		->method('getExceptions')
143		->willReturn(array(
144		new InvalidStateException(42, __FILE__, 'foo')
145		));
146
147		$parser = new Parser($pdepend);
148		$parser->parse($report);
149		}
150
151		/**
152		* Creates a mocked PDepend instance.
153		*
154		* @return \PDepend\Engine
155		*/
156		private function getPHPDependMock()
157		{
158		return $this->getMock(Engine::class, array(), array(null), '', false);
		0 ignored issues – show Deprecated Code introduced 2019-01-17 21:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPMD\AbstractTest::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0; use createMock() or getMockBuilder() instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
159		}
160
161		/**
162		* Creates a mocked PDepend class instance.
163		*
164		* @return \PDepend\Source\AST\ASTClass
165		*/
166		protected function getPHPDependClassMock()
167		{
168		$class = $this->getMock(ASTClass::class, array(), array(null));
		0 ignored issues – show Deprecated Code introduced 2019-01-17 21:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPMD\AbstractTest::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0; use createMock() or getMockBuilder() instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
169		$class
170		->method('getCompilationUnit')
171		->willReturn($this->getPHPDependFileMock('foo.php'));
172		$class
173		->method('getConstants')
174		->willReturn(new \ArrayIterator(array()));
175		$class
176		->method('getProperties')
177		->willReturn(new \ArrayIterator(array()));
178		$class
179		->method('getMethods')
180		->willReturn(new \ArrayIterator(array()));
181
182		return $class;
183		}
184
185		/**
186		* Creates a mocked PHP_Depend function instance.
187		*
188		* @param string $fileName Optional file name for the source file.
189		* @return PHP_Depend_Code_Function
190		*/
191	View Code Duplication	protected function getPHPDependFunctionMock($fileName = '/foo/bar.php')
		0 ignored issues – show Duplication introduced 2019-01-15 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
192		{
193		$function = $this->getMock(ASTFunction::class, array(), array(null));
		0 ignored issues – show Deprecated Code introduced 2019-01-17 21:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPMD\AbstractTest::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0; use createMock() or getMockBuilder() instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
194		$function->expects($this->atLeastOnce())
195		->method('getCompilationUnit')
196		->willReturn($this->getPHPDependFileMock($fileName));
197
198		return $function;
199		}
200
201		/**
202		* Creates a mocked PHP_Depend method instance.
203		*
204		* @param string $fileName Optional file name for the source file.
205		* @return PHP_Depend_Code_CodeMethod
206		*/
207	View Code Duplication	protected function getPHPDependMethodMock($fileName = '/foo/bar.php')
		0 ignored issues – show Duplication introduced 2019-01-15 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
208		{
209		$method = $this->getMock(ASTMethod::class, array(), array(null));
		0 ignored issues – show Deprecated Code introduced 2019-01-17 21:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPMD\AbstractTest::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0; use createMock() or getMockBuilder() instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
210		$method->expects($this->atLeastOnce())
211		->method('getCompilationUnit')
212		->willReturn($this->getPHPDependFileMock($fileName));
213
214		return $method;
215		}
216
217		/**
218		* Creates a mocked PHP_Depend file instance.
219		*
220		* @param string $fileName The temporary file name.
221		* @return PHP_Depend_Code_File
222		*/
223		protected function getPHPDependFileMock($fileName)
224		{
225		$file = $this->getMock(ASTCompilationUnit::class, array(), array(null));
		0 ignored issues – show Deprecated Code introduced 2019-01-17 21:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPMD\AbstractTest::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0; use createMock() or getMockBuilder() instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
226		$file
227		->method('getFileName')
228		->willReturn($fileName);
229
230		return $file;
231		}
232		}
233

SomeBlackMagic / phpmd

Issues (575)

Security Analysis not enabled

tests/php/PHPMD/ParserTest.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like