PHPMD\Rule\Design\LongParameterListTest

Complexity

Total Complexity

9

Size/Duplication

Total Lines	119
Duplicated Lines	35.29 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	testApplyIgnoresMethodsWithLessParametersThanMinimum()	7	7	1
A	testApplyReportsMethodsWithIdenticalParametersAndMinimum()	7	7	1
A	testApplyReportsMethodsWithMoreParametersThanMinimum()	7	7	1
A	testApplyIgnoresFunctionsWithLessParametersThanMinimum()	7	7	1
A	testApplyReportsFunctionsWithIdenticalParametersAndMinimum()	7	7	1
A	testApplyReportsFunctionsWithMoreParametersThanMinimum()	7	7	1
A	createMethod()	0	4	1
A	createFunction()	0	4	1
A	initFunctionOrMethodMock()	0	8	1

<?php
/**
 * This file is part of PHP Mess Detector.
 *
 * Copyright (c) Manuel Pichler <mapi@phpmd.org>.
 * All rights reserved.
 *
 * Licensed under BSD License
 * For full copyright and license information, please see the LICENSE file.
 * Redistributions of files must retain the above copyright notice.
 *
 * @author Manuel Pichler <mapi@phpmd.org>
 * @copyright Manuel Pichler. All rights reserved.
 * @license https://opensource.org/licenses/bsd-license.php BSD License
 * @link http://phpmd.org/
 */

namespace PHPMD\Rule\Design;

use PHPMD\AbstractTest;

/**
 * Test case for the excessive long parameter list rule.
 *
 * @covers \PHPMD\Rule\Design\LongParameterList
 */
class LongParameterListTest extends AbstractTest
{
    /**
     * testApplyIgnoresMethodsWithLessParametersThanMinimum
     *
     * @return void
     */
    public function testApplyIgnoresMethodsWithLessParametersThanMinimum()

This method seems to be duplicated in your project.

    {
        $rule = new LongParameterList();
        $rule->setReport($this->getReportMock(0));
        $rule->addProperty('minimum', '4');
        $rule->apply($this->createMethod(3));
    }

    /**
     * testApplyReportsMethodsWithIdenticalParametersAndMinimum
     *
     * @return void
     */
    public function testApplyReportsMethodsWithIdenticalParametersAndMinimum()

This method seems to be duplicated in your project.

    {
        $rule = new LongParameterList();
        $rule->setReport($this->getReportMock(1));
        $rule->addProperty('minimum', '3');
        $rule->apply($this->createMethod(3));
    }

    /**
     * testApplyReportsMethodsWithMoreParametersThanMinimum
     *
     * @return void
     */
    public function testApplyReportsMethodsWithMoreParametersThanMinimum()

This method seems to be duplicated in your project.

    {
        $rule = new LongParameterList();
        $rule->setReport($this->getReportMock(1));
        $rule->addProperty('minimum', '3');
        $rule->apply($this->createMethod(42));
    }

    /**
     * testApplyIgnoresFunctionsWithLessParametersThanMinimum
     *
     * @return void
     */
    public function testApplyIgnoresFunctionsWithLessParametersThanMinimum()

This method seems to be duplicated in your project.

    {
        $rule = new LongParameterList();
        $rule->setReport($this->getReportMock(0));
        $rule->addProperty('minimum', '4');
        $rule->apply($this->createFunction(3));
    }

    /**
     * testApplyReportsFunctionsWithIdenticalParametersAndMinimum
     *
     * @return void
     */
    public function testApplyReportsFunctionsWithIdenticalParametersAndMinimum()

This method seems to be duplicated in your project.

    {
        $rule = new LongParameterList();
        $rule->setReport($this->getReportMock(1));
        $rule->addProperty('minimum', '3');
        $rule->apply($this->createFunction(3));
    }

    /**
     * testApplyReportsFunctionsWithMoreParametersThanMinimum
     *
     * @return void
     */
    public function testApplyReportsFunctionsWithMoreParametersThanMinimum()

This method seems to be duplicated in your project.

    {
        $rule = new LongParameterList();
        $rule->setReport($this->getReportMock(1));
        $rule->addProperty('minimum', '3');
        $rule->apply($this->createFunction(42));
    }

    /**
     * Returns a mocked method instance.
     *
     * @param integer $parameterCount
     * @return \PHPMD\Node\MethodNode
     */
    private function createMethod($parameterCount)
    {
        return $this->initFunctionOrMethodMock($this->getMethodMock(), $parameterCount);

The expression $this->initFunctionOrMethodMock($this->getMethodMock(), $parameterCount); of type PHPMD\Node\FunctionNode|PHPMD\Node\MethodNode adds the type PHPMD\Node\FunctionNode to the return on line 115 which is incompatible with the return type documented by PHPMD\Rule\Design\LongParameterListTest::createMethod of type PHPMD\Node\MethodNode.

    }

    /**
     * Creates a mocked function node instance.
     *
     * @param integer $parameterCount Number of function parameters.
     *
     * @return \PHPMD\Node\FunctionNode
     */
    private function createFunction($parameterCount)
    {
        return $this->initFunctionOrMethodMock($this->createFunctionMock(), $parameterCount);

The expression $this->initFunctionOrMethodMock($this->createFunctionMock(), $parameterCount); of type PHPMD\Node\FunctionNode|PHPMD\Node\MethodNode adds the type PHPMD\Node\MethodNode to the return on line 127 which is incompatible with the return type documented by PHPMD\Rule\Design\LongParameterListTest::createFunction of type PHPMD\Node\FunctionNode.

    }

    /**
     * Initializes the getParameterCount() method of the given callable.
     *
     * @param \PHPMD\Node\FunctionNode|\PHPMD\Node\MethodNode $mock
     * @param integer $parameterCount
     * @return \PHPMD\Node\FunctionNode|\PHPMD\Node\MethodNode
     */
    private function initFunctionOrMethodMock($mock, $parameterCount)
    {
        $mock->expects($this->once())
            ->method('getParameterCount')
            ->willReturn($parameterCount);

        return $mock;
    }
}