InstagramAccountTest::testIsValidMediaID() - Code Metrics - Inspection of "Add more unit tests for InstagramAccount" - SomarDesignStudios/silverstripe-instagram - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by David

created 2016-08-08 09:59 UTC

InstagramAccountTest::testIsValidMediaID() B

↳ Parent: InstagramAccountTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	88
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	88
rs	8.6012
cc	1
eloc	40
nc	1
nop	0

How to fix Long Method

<?php

use \Mockery as Mockery;

class InstagramAccountTest extends SapphireTest
namespace YourVendor;

class YourClass { }
{
    public function tearDown()
    {
        Mockery::close();
        parent::tearDown();
    }

    protected function getNewInstagramAccountMock()
    {
        return Mockery::mock('InstagramAccount');
    }

    public function testUpdateAccessToken()
    {
        $validToken =
            '{"user":{"username":"somardesignstudios","bio":"","website":"","profile_picture":"",' .
            '"full_name":"","id":"12345678"},"access_token":"","resource_owner_id":""}';

        $invalidToken =
            '{"user":{"username":"somardesignstudios","bio":"","website":"","profile_picture":"",' .
            '"full_name":"","id":"87654321"},"access_token":"","resource_owner_id":""}';

        /*
         * Should throw if the session state is invalid.
         */
        $mock = $this->getNewInstagramAccountMock()->makePartial();
        $mock
            ->shouldReceive('getSessionOAuthState')
            ->once()
            ->withNoArgs()
            ->andReturn('state');

        try {
            $mock->updateAccessToken($validToken, 'invalidState');
        } catch (Exception $e) {
            $this->assertEquals('Trying to set token on wrong InstagramAccount', $e->getMessage());

        }

        /*
         * Should throw if the session state is valid and the token username doesn't match the title.
         */
        $mock = $this->getNewInstagramAccountMock()->makePartial();
        $mock
            ->shouldReceive('getSessionOAuthState')
            ->once()
            ->withNoArgs()
            ->andReturn('state');
        $mock
            ->shouldReceive('getField')
            ->once()
            ->with('Title')
            ->andReturn('otherusername');

        try {
            $mock->updateAccessToken($validToken, 'state');
        } catch (Exception $e) {
            $this->assertEquals('Trying to set token on wrong InstagramAccount', $e->getMessage());

        }

        /*
         * Should set the token if session state is valid and there's no current token.
         */
        $mock = $this->getNewInstagramAccountMock()->makePartial();
        $mock
            ->shouldReceive('getSessionOAuthState')
            ->once()
            ->withNoArgs()
            ->andReturn('state');
        $mock
            ->shouldReceive('getField')
            ->with('Title')
            ->andReturn('somardesignstudios');
        $mock
            ->shouldReceive('getField')
            ->with('AccessToken')
            ->andReturn(null);
        $mock
            ->shouldReceive('setField')
            ->once()
            ->with('AccessToken', $validToken);

        $mock->updateAccessToken($validToken, 'state');

        /*
         * Should throw if the session state is valid, the token username matches the title,
         * and the new token is for another account.
         */
        $mock = $this->getNewInstagramAccountMock()->makePartial();
        $mock
            ->shouldReceive('getSessionOAuthState')
            ->once()
            ->withNoArgs()
            ->andReturn('state');
        $mock
            ->shouldReceive('getField')
            ->with('Title')
            ->andReturn('somardesignstudios');
        $mock
            ->shouldReceive('getField')
            ->with('AccessToken')
            ->andReturn($validToken);

        try {
            $mock->updateAccessToken($invalidToken, 'state');
        } catch (Exception $e) {
            $this->assertEquals('Trying to set token on wrong InstagramAccount', $e->getMessage());

        }

        /*
         * Should update the token if the session state is valid and the token IDs match.
         */
        $mock = $this->getNewInstagramAccountMock()->makePartial();
        $mock
            ->shouldReceive('getSessionOAuthState')
            ->once()
            ->withNoArgs()
            ->andReturn('state');
        $mock
            ->shouldReceive('getField')
            ->with('Title')
            ->andReturn('somardesignstudios');
        $mock
            ->shouldReceive('getField')
            ->with('AccessToken')
            ->andReturn($validToken);
        $mock
            ->shouldReceive('setField')
            ->once()
            ->with('AccessToken', $validToken);

        $mock->updateAccessToken($validToken, 'state');
    }

    public function testGetOAuthStateValueFromLoginURL()
    {
        $instagramAccount = new InstagramAccount();

        /*
         * Should return null if no URL is passed.
         */
        $this->assertEquals(null, $instagramAccount->getOAuthStateValueFromLoginURL());


        /*
         * Should return null if there's no "state" query string.
         */
        $this->assertEquals(

            null,
            $instagramAccount->getOAuthStateValueFromLoginURL(
                'http://example.com/admin/admin/instagram/InstagramAccount/OAuth?code=123'
            )
        );

        /*
         * Should return the value of the "state" query string if it exists.
         */
        $this->assertEquals(

            'abc',
            $instagramAccount->getOAuthStateValueFromLoginURL(
                'http://example.com/admin/admin/instagram/InstagramAccount/OAuth?code=123&state=abc'
            )
        );
    }

    public function testIsValidMediaID()
    {
        /*
         * Should return false if no media ID is passed.
         */
        $instagramAccount = new InstagramAccount();

        $this->assertEquals(false, $instagramAccount->isValidMediaID());


        /*
         * Should return false if the account ID is unavailable.
         */
        $mock = $this->getNewInstagramAccountMock()->makePartial();
        $mock
            ->shouldReceive('getInstagramID')
            ->withNoArgs()
            ->andReturn(null);

        $this->assertEquals(

            false,
            $mock->isValidMediaID('123456789012345678_123')
        );

        /*
         * Should return false if the media ID is less than 18 digits.
         */
        $mock = $this->getNewInstagramAccountMock()->makePartial();
        $mock
            ->shouldReceive('getInstagramID')
            ->withNoArgs()
            ->andReturn('123');

        $this->assertEquals(

            false,
            $mock->isValidMediaID('12345678901234567_123')
        );

        /*
         * Should return false if the media ID is greater than 19 digits.
         */
        $this->assertEquals(

            false,
            $mock->isValidMediaID('12345678901234567890_123')
        );

        /*
         * Should return false if the media ID length is valid but contains non-digits.
         */
        $this->assertEquals(

            false,
            $mock->isValidMediaID('123456789Z12345678_123')
        );

        $this->assertEquals(

            false,
            $mock->isValidMediaID('123456789&12345678_123')
        );

        /*
         * Should return false if a valid media ID is not followed by an underscore.
         */
        $this->assertEquals(

            false,
            $mock->isValidMediaID('123456789012345678-123')
        );

        /*
         * Should return false if the media ID doesn't end with the account ID.
         */
        $this->assertEquals(

            false,
            $mock->isValidMediaID('123456789012345678_321')
        );

        /*
         * Should return true if the media ID is 18 or 19 characters followed by
         * an underscore and the account ID.
         */
        $this->assertEquals(

            true,
            $mock->isValidMediaID('123456789012345678_123')
        );

        $this->assertEquals(

            true,
            $mock->isValidMediaID('1234567890123456789_123')
        );
    }
}


1			<?php
2
3			use \Mockery as Mockery;
4
5			class InstagramAccountTest extends SapphireTest
			0 ignored issues – show Coding Style Compatibility introduced 2016-08-03 03:02 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6			{
7			public function tearDown()
8			{
9			Mockery::close();
10			parent::tearDown();
11			}
12
13			protected function getNewInstagramAccountMock()
14			{
15			return Mockery::mock('InstagramAccount');
16			}
17
18			public function testUpdateAccessToken()
19			{
20			$validToken =
21			'{"user":{"username":"somardesignstudios","bio":"","website":"","profile_picture":"",' .
22			'"full_name":"","id":"12345678"},"access_token":"","resource_owner_id":""}';
23
24			$invalidToken =
25			'{"user":{"username":"somardesignstudios","bio":"","website":"","profile_picture":"",' .
26			'"full_name":"","id":"87654321"},"access_token":"","resource_owner_id":""}';
27
28			/*
29			* Should throw if the session state is invalid.
30			*/
31			$mock = $this->getNewInstagramAccountMock()->makePartial();
32			$mock
33			->shouldReceive('getSessionOAuthState')
34			->once()
35			->withNoArgs()
36			->andReturn('state');
37
38			try {
39			$mock->updateAccessToken($validToken, 'invalidState');
40			} catch (Exception $e) {
41			$this->assertEquals('Trying to set token on wrong InstagramAccount', $e->getMessage());
			0 ignored issues – show Bug introduced 2016-08-03 03:02 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
42			}
43
44			/*
45			* Should throw if the session state is valid and the token username doesn't match the title.
46			*/
47			$mock = $this->getNewInstagramAccountMock()->makePartial();
48			$mock
49			->shouldReceive('getSessionOAuthState')
50			->once()
51			->withNoArgs()
52			->andReturn('state');
53			$mock
54			->shouldReceive('getField')
55			->once()
56			->with('Title')
57			->andReturn('otherusername');
58
59			try {
60			$mock->updateAccessToken($validToken, 'state');
61			} catch (Exception $e) {
62			$this->assertEquals('Trying to set token on wrong InstagramAccount', $e->getMessage());
			0 ignored issues – show Bug introduced 2016-08-03 03:02 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
63			}
64
65			/*
66			* Should set the token if session state is valid and there's no current token.
67			*/
68			$mock = $this->getNewInstagramAccountMock()->makePartial();
69			$mock
70			->shouldReceive('getSessionOAuthState')
71			->once()
72			->withNoArgs()
73			->andReturn('state');
74			$mock
75			->shouldReceive('getField')
76			->with('Title')
77			->andReturn('somardesignstudios');
78			$mock
79			->shouldReceive('getField')
80			->with('AccessToken')
81			->andReturn(null);
82			$mock
83			->shouldReceive('setField')
84			->once()
85			->with('AccessToken', $validToken);
86
87			$mock->updateAccessToken($validToken, 'state');
88
89			/*
90			* Should throw if the session state is valid, the token username matches the title,
91			* and the new token is for another account.
92			*/
93			$mock = $this->getNewInstagramAccountMock()->makePartial();
94			$mock
95			->shouldReceive('getSessionOAuthState')
96			->once()
97			->withNoArgs()
98			->andReturn('state');
99			$mock
100			->shouldReceive('getField')
101			->with('Title')
102			->andReturn('somardesignstudios');
103			$mock
104			->shouldReceive('getField')
105			->with('AccessToken')
106			->andReturn($validToken);
107
108			try {
109			$mock->updateAccessToken($invalidToken, 'state');
110			} catch (Exception $e) {
111			$this->assertEquals('Trying to set token on wrong InstagramAccount', $e->getMessage());
			0 ignored issues – show Bug introduced 2016-08-03 03:02 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
112			}
113
114			/*
115			* Should update the token if the session state is valid and the token IDs match.
116			*/
117			$mock = $this->getNewInstagramAccountMock()->makePartial();
118			$mock
119			->shouldReceive('getSessionOAuthState')
120			->once()
121			->withNoArgs()
122			->andReturn('state');
123			$mock
124			->shouldReceive('getField')
125			->with('Title')
126			->andReturn('somardesignstudios');
127			$mock
128			->shouldReceive('getField')
129			->with('AccessToken')
130			->andReturn($validToken);
131			$mock
132			->shouldReceive('setField')
133			->once()
134			->with('AccessToken', $validToken);
135
136			$mock->updateAccessToken($validToken, 'state');
137			}
138
139			public function testGetOAuthStateValueFromLoginURL()
140			{
141			$instagramAccount = new InstagramAccount();
142
143			/*
144			* Should return null if no URL is passed.
145			*/
146			$this->assertEquals(null, $instagramAccount->getOAuthStateValueFromLoginURL());
			0 ignored issues – show Bug introduced 2016-08-08 10:03 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
147
148			/*
149			* Should return null if there's no "state" query string.
150			*/
151			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-08-08 10:03 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
152			null,
153			$instagramAccount->getOAuthStateValueFromLoginURL(
154			'http://example.com/admin/admin/instagram/InstagramAccount/OAuth?code=123'
155			)
156			);
157
158			/*
159			* Should return the value of the "state" query string if it exists.
160			*/
161			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-08-08 10:03 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
162			'abc',
163			$instagramAccount->getOAuthStateValueFromLoginURL(
164			'http://example.com/admin/admin/instagram/InstagramAccount/OAuth?code=123&state=abc'
165			)
166			);
167			}
168
169			public function testIsValidMediaID()
170			{
171			/*
172			* Should return false if no media ID is passed.
173			*/
174			$instagramAccount = new InstagramAccount();
175
176			$this->assertEquals(false, $instagramAccount->isValidMediaID());
			0 ignored issues – show Bug introduced 2016-08-08 10:03 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
177
178			/*
179			* Should return false if the account ID is unavailable.
180			*/
181			$mock = $this->getNewInstagramAccountMock()->makePartial();
182			$mock
183			->shouldReceive('getInstagramID')
184			->withNoArgs()
185			->andReturn(null);
186
187			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-08-08 10:03 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
188			false,
189			$mock->isValidMediaID('123456789012345678_123')
190			);
191
192			/*
193			* Should return false if the media ID is less than 18 digits.
194			*/
195			$mock = $this->getNewInstagramAccountMock()->makePartial();
196			$mock
197			->shouldReceive('getInstagramID')
198			->withNoArgs()
199			->andReturn('123');
200
201			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-08-08 10:03 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
202			false,
203			$mock->isValidMediaID('12345678901234567_123')
204			);
205
206			/*
207			* Should return false if the media ID is greater than 19 digits.
208			*/
209			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-08-08 10:03 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
210			false,
211			$mock->isValidMediaID('12345678901234567890_123')
212			);
213
214			/*
215			* Should return false if the media ID length is valid but contains non-digits.
216			*/
217			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-08-08 10:03 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
218			false,
219			$mock->isValidMediaID('123456789Z12345678_123')
220			);
221
222			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-08-08 10:03 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
223			false,
224			$mock->isValidMediaID('123456789&12345678_123')
225			);
226
227			/*
228			* Should return false if a valid media ID is not followed by an underscore.
229			*/
230			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-08-08 10:03 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
231			false,
232			$mock->isValidMediaID('123456789012345678-123')
233			);
234
235			/*
236			* Should return false if the media ID doesn't end with the account ID.
237			*/
238			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-08-08 10:03 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
239			false,
240			$mock->isValidMediaID('123456789012345678_321')
241			);
242
243			/*
244			* Should return true if the media ID is 18 or 19 characters followed by
245			* an underscore and the account ID.
246			*/
247			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-08-08 10:03 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
248			true,
249			$mock->isValidMediaID('123456789012345678_123')
250			);
251
252			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-08-08 10:03 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<InstagramAccountTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
253			true,
254			$mock->isValidMediaID('1234567890123456789_123')
255			);
256			}
257			}
258

SomarDesignStudios / silverstripe-instagram

Pull Request — master (#2)

InstagramAccountTest::testIsValidMediaID() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like