ContentBlock_ColumnLayout::getCMSFields() - Code Metrics - SomarDesignStudios/silverstripe-contentblocks - Measure and Improve Code Quality continuously with Scrutinizer

ContentBlock_ColumnLayout::getCMSFields() A
last analyzed 2017-06-19 21:54 UTC

↳ Parent: ContentBlock_ColumnLayout

Complexity

Conditions	1
Paths	1

Size

Total Lines	63
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	63
rs	9.4347
c	0
b	0
f	0
cc	1
eloc	41
nc	1
nop	0

How to fix Long Method

<?php

/**
 * Models a Content Block Column Layout
 *
 * @since 1.0.0
 */
class ContentBlock_ColumnLayout extends ContentBlock
namespace YourVendor;

class YourClass { }
{

    private static $db = [

        'Layout' => 'Enum("One Column, Two Column, Three Column")',
        'ColumnOneContent' => 'HTMLText',
        'ColumnTwoContent' => 'HTMLText',
        'ColumnThreeContent' => 'HTMLText',
        'ColumnOneColour' => 'Varchar',
        'ColumnTwoColour' => 'Varchar',
        'ColumnThreeColour' => 'Varchar',
    ];

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $fields->push(
            DropdownField::create('Layout')
            ->setSource(
                singleton('ContentBlock_ColumnLayout')
                ->dbObject('Layout')
                ->enumValues()
            )
        );

        $colourSource = Config::inst()->get('ContentBlock_ColumnLayout', 'colour_options');

        //Column One -------
        $columnOne = DisplayLogicWrapper::create(CompositeField::create([
             HeaderField::create('ColumnOne', 'Column One'),
             DropdownField::create(
                 'ColumnOneColour',
                 'Colour',
                 $colourSource
             ),
             HTMLEditorField::create('ColumnOneContent', 'Content'),
        ]));
        //Display if One Column || Two Column || Three Column
        $columnOne->displayIf('Layout')->isEqualTo('One Column')
            ->orIf('Layout')->isEqualTo('Two Column')
            ->orIf('Layout')->isEqualTo('Three Column');
        $fields->push($columnOne);

        //Column Two -------
        //Display if Two Column
        $columnTwo = DisplayLogicWrapper::create(CompositeField::create([
             HeaderField::create('ColumnTwo', 'Column Two'),
             DropdownField::create(
                 'ColumnTwoColour',
                 'Colour',
                 $colourSource
             ),
             HTMLEditorField::create('ColumnTwoContent', 'Content'),
        ]));
        $columnTwo->displayIf('Layout')->isEqualTo('Two Column')
            ->orIf('Layout')->isEqualTo('Three Column');
        $fields->push($columnTwo);

        //Column Three -------
        $columnThree =  DisplayLogicWrapper::create(CompositeField::create([
             HeaderField::create('ColumnThree', 'Column Three'),
             DropdownField::create(
                 'ColumnThreeColour',
                 'Colour',
                 $colourSource
             ),
             HTMLEditorField::create('ColumnThreeContent', 'Content'),
        ]));
        $columnThree->displayIf('Layout')->isEqualTo('Three Column');
        $fields->push($columnThree);

        $this->extend('updateCMSFields', $fields);

        return $fields;
    }

    /**
     * Get the colour for a column
     *
     * @return string
     */
    public function ColumnColour($column)
    {
        $property = sprintf('Column%sColour', $column);
        $colour = $this->getField($property);
        return sprintf('#%s', $colour);
    }

    public function IsLayout($layout){
        return ($this->getField('Layout') == $layout);
    }

    /**
     * Gets the configured classes for a column
     *
     * @return string
     */
    public function ColumnClasses()

    {
        $classesArray = Config::inst()->get('ContentBlock_ColumnLayout', 'column_classes');

        $this->extend('updateColumnClasses', $classes);

        return (!empty($classesArray)) ? implode(' ', $classesArray) : '' ;
    }

    /**
     * Gets the configured classes for a row
     *
     * @return string
     */
    public function RowClasses()

    {
        $classesArray = Config::inst()->get('ContentBlock_ColumnLayout', 'row_classes');

        $this->extend('updateRowClasses', $classes);

        return (!empty($classesArray)) ? implode(' ', $classesArray) : '' ;
    }

    /**
     * Gets the block type for CMS display
     *
     * @return string
     */
    public function getBlockType()
    {
        return 'Column Layout';
    }

    /**
     * Renders the block for template
     *
     * @return string
     */
    public function RenderBlock()
    {
        Requirements::javascript(CONTENTBLOCKS_DIR . '/javascript/lib/jquery.matchHeight-min.js');
        return parent::RenderBlock();
    }

}


1		<?php
2
3		/**
4		* Models a Content Block Column Layout
5		*
6		* @since 1.0.0
7		*/
8		class ContentBlock_ColumnLayout extends ContentBlock
		0 ignored issues – show Coding Style Compatibility introduced 2016-10-14 02:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9		{
10
11		private static $db = [
		0 ignored issues – show Comprehensibility introduced 2016-10-14 02:29 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-10-14 02:29 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12		'Layout' => 'Enum("One Column, Two Column, Three Column")',
13		'ColumnOneContent' => 'HTMLText',
14		'ColumnTwoContent' => 'HTMLText',
15		'ColumnThreeContent' => 'HTMLText',
16		'ColumnOneColour' => 'Varchar',
17		'ColumnTwoColour' => 'Varchar',
18		'ColumnThreeColour' => 'Varchar',
19		];
20
21		public function getCMSFields()
22		{
23		$fields = parent::getCMSFields();
24
25		$fields->push(
26		DropdownField::create('Layout')
27		->setSource(
28		singleton('ContentBlock_ColumnLayout')
29		->dbObject('Layout')
30		->enumValues()
31		)
32		);
33
34		$colourSource = Config::inst()->get('ContentBlock_ColumnLayout', 'colour_options');
35
36		//Column One -------
37		$columnOne = DisplayLogicWrapper::create(CompositeField::create([
38		HeaderField::create('ColumnOne', 'Column One'),
39		DropdownField::create(
40		'ColumnOneColour',
41		'Colour',
42		$colourSource
43		),
44		HTMLEditorField::create('ColumnOneContent', 'Content'),
45		]));
46		//Display if One Column \|\| Two Column \|\| Three Column
47		$columnOne->displayIf('Layout')->isEqualTo('One Column')
48		->orIf('Layout')->isEqualTo('Two Column')
49		->orIf('Layout')->isEqualTo('Three Column');
50		$fields->push($columnOne);
51
52		//Column Two -------
53		//Display if Two Column
54		$columnTwo = DisplayLogicWrapper::create(CompositeField::create([
55		HeaderField::create('ColumnTwo', 'Column Two'),
56		DropdownField::create(
57		'ColumnTwoColour',
58		'Colour',
59		$colourSource
60		),
61		HTMLEditorField::create('ColumnTwoContent', 'Content'),
62		]));
63		$columnTwo->displayIf('Layout')->isEqualTo('Two Column')
64		->orIf('Layout')->isEqualTo('Three Column');
65		$fields->push($columnTwo);
66
67		//Column Three -------
68		$columnThree = DisplayLogicWrapper::create(CompositeField::create([
69		HeaderField::create('ColumnThree', 'Column Three'),
70		DropdownField::create(
71		'ColumnThreeColour',
72		'Colour',
73		$colourSource
74		),
75		HTMLEditorField::create('ColumnThreeContent', 'Content'),
76		]));
77		$columnThree->displayIf('Layout')->isEqualTo('Three Column');
78		$fields->push($columnThree);
79
80		$this->extend('updateCMSFields', $fields);
81
82		return $fields;
83		}
84
85		/**
86		* Get the colour for a column
87		*
88		* @return string
89		*/
90		public function ColumnColour($column)
91		{
92		$property = sprintf('Column%sColour', $column);
93		$colour = $this->getField($property);
94		return sprintf('#%s', $colour);
95		}
96
97		public function IsLayout($layout){
98		return ($this->getField('Layout') == $layout);
99		}
100
101		/**
102		* Gets the configured classes for a column
103		*
104		* @return string
105		*/
106	View Code Duplication	public function ColumnClasses()
		0 ignored issues – show Duplication introduced 2016-10-14 02:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
107		{
108		$classesArray = Config::inst()->get('ContentBlock_ColumnLayout', 'column_classes');
109
110		$this->extend('updateColumnClasses', $classes);
111
112		return (!empty($classesArray)) ? implode(' ', $classesArray) : '' ;
113		}
114
115		/**
116		* Gets the configured classes for a row
117		*
118		* @return string
119		*/
120	View Code Duplication	public function RowClasses()
		0 ignored issues – show Duplication introduced 2016-10-14 02:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
121		{
122		$classesArray = Config::inst()->get('ContentBlock_ColumnLayout', 'row_classes');
123
124		$this->extend('updateRowClasses', $classes);
125
126		return (!empty($classesArray)) ? implode(' ', $classesArray) : '' ;
127		}
128
129		/**
130		* Gets the block type for CMS display
131		*
132		* @return string
133		*/
134		public function getBlockType()
135		{
136		return 'Column Layout';
137		}
138
139		/**
140		* Renders the block for template
141		*
142		* @return string
143		*/
144		public function RenderBlock()
145		{
146		Requirements::javascript(CONTENTBLOCKS_DIR . '/javascript/lib/jquery.matchHeight-min.js');
147		return parent::RenderBlock();
148		}
149
150		}
151

SomarDesignStudios / silverstripe-contentblocks

GitHub Access Token became invalid

ContentBlock_ColumnLayout::getCMSFields() A last analyzed 2017-06-19 21:54 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

ContentBlock_ColumnLayout::getCMSFields() A
last analyzed 2017-06-19 21:54 UTC