ContentBlock_TileSection

Complexity

Total Complexity

5

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	getCMSFields()	0	37	2
A	getAvailableTemplates()	0	8	2
A	getBlockType()	0	4	1

<?php

/**
 * Models a Content Block Tile Section
 *
 * @since 1.0.0
 */
class ContentBlock_TileSection extends ContentBlock

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $db = [

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'TilesPerRow' => 'Enum("One, Two, Three")',
        'TileTemplate' => 'Text'
    ];

    private static $has_many = [

Consider using a different property name as you override a private property of the parent class.

The property $has_many is not used and could be removed.

        'ContentTiles' => 'TileSection_ContentTile',
    ];

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $fields->push(DropdownField::create(
            'TilesPerRow',
            'Tiles Per Row',
            singleton('ContentBlock_TileSection')
            ->dbObject('TilesPerRow')
            ->enumValues()
        ));

        $fields->push(DropdownField::create(
            'TileTemplate',
            'Tile Template',
            $this->getAvailableTemplates()
        ));

        if ($this->getField('ID')) {
            $fields->push(GridField::create(
                'ContentTiles',
                'Content Tiles',
                $this->ContentTiles(),

The method ContentTiles does not exist on object<ContentBlock_TileSection>? Since you implemented __call, maybe consider adding a @method annotation.

                GridFieldConfig_RecordEditor::create()
                ->addComponent(new GridFieldOrderableRows('Sort'))
            ));
        } else {
            $fields->push(LiteralField::create(
                'Unsaved',
                '<p class="message info">Please save first, to begin adding Tiles </p>'
            ));
        }

        $this->extend('updateCMSFields', $fields);

        return $fields;
    }

    /**
     * Gets available templates from the static configuration
     *
     * @return array
     */
     public function getAvailableTemplates()
     {
         $templates = Config::inst()->get('ContentBlock_TileSection', 'tile_templates');

         $this->extend('updateAvailableTemplates', $templates);

         return (!empty($templates)) ? $templates : [] ;
     }


    /**
     * Gets the block type for CMS display
     *
     * @return string
     */
    public function getBlockType()
    {
        return 'Tile Section';
    }
}