ContentBlock

Complexity

Total Complexity

8

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	7	1
A	getCMSValidator()	0	6	1
A	onBeforeWrite()	0	8	2
A	getTemplateName()	0	6	1
A	RenderBlock()	0	8	2
A	getBlockType()	0	4	1

<?php

/**
 * Models a Content Block - a base class for different types of Content Blocks
 *
 * @since 1.0.0
 */
class ContentBlock extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $casting = [

Consider using a different property name as you override a private property of the parent class.

The property $casting is not used and could be removed.

        'RenderBlock' => 'HTMLText'
    ];

    private static $db = [

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'Sort' => 'Int',
        'Title' => 'Text',
    ];

    private static $has_one = [

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        'ParentPage' => 'SiteTree',
    ];

    private static $default_sort = 'Sort ASC';

Consider using a different property name as you override a private property of the parent class.

The property $default_sort is not used and could be removed.

    public function getCMSFields()
    {
        return FieldList::create([
            TextField::create('Title')
            ->setDescription('For CMS Identification')
        ]);
    }

    /**
     * @return RequiredFields
     */
    public function getCMSValidator()
    {
        return RequiredFields::create([
            'Title'
        ]);
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();

        if (!$this->getField('Title')) {
            $this->Title = sprintf('New %s', $this->getBlockType());

The property Title does not exist on object<ContentBlock>. Since you implemented __set, maybe consider adding a @property annotation.

        }
    }

    /**
     * @return string
     */
    public function getTemplateName()
    {
        $template = $this->getField('ClassName');
        $this->extend('updateTemplateName', $template);
        return $template;
    }

    /**
     * Renders the block for template
     *
     * @return string
     */
    public function RenderBlock()
    {
        if (Config::inst()->get('ContentBlock', 'include_bootstrap')) {
            Requirements::javascript(CONTENTBLOCKS_DIR . '/javascript/lib/bootstrap.min.js');
            Requirements::css(CONTENTBLOCKS_DIR . '/css/lib/bootstrap.min.css');
        }
        return $this->renderWith($this->getTemplateName());
    }

    /**
     * Gets the block type for CMS display
     *
     * @return string
     */
    public function getBlockType()
    {
        return 'Content Block';
    }

}