SomarDesignStudios / silverstripe-chimpify

code/admin/ChimpifyAdmin.php

<?php

use \DrewM\MailChimp\MailChimp;

class ChimpifyAdmin extends ModelAdmin

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $managed_models = [

Consider using a different property name as you override a private property of the parent class.

The property $managed_models is not used and could be removed.

        'ChimpifyCampaign',
    ];

    private static $url_segment = 'mailchimp-campaigns';

Consider using a different property name as you override a private property of the parent class.

The property $url_segment is not used and could be removed.

    private static $menu_title = 'MailChimp Campaigns';

Consider using a different property name as you override a private property of the parent class.

The property $menu_title is not used and could be removed.

    public function getEditForm($id = null, $fields = null)
    {
        $form = parent::getEditForm($id, $fields);

        $gridFieldName = $this->sanitiseClassName($this->modelClass);
        $gridFieldConfig = $form->Fields()->fieldByName($gridFieldName)->getConfig();

        $gridFieldConfig->removeComponentsByType('GridFieldPrintButton');
        $gridFieldConfig->removeComponentsByType('GridFieldExportButton');
        $gridFieldConfig
            ->getComponentByType('GridFieldAddNewButton')
            ->setButtonName(
                _t('Chimpify.ButtonLabelAddMailChimpCampaign', 'Add MailChimp Campaign')
            );
        $gridFieldConfig
            ->getComponentByType('GridFieldDetailForm')
            ->setItemRequestClass('ChimpifyRequestHandler');

        return $form;
    }
}

class ChimpifyRequestHandler extends GridFieldDetailForm_ItemRequest

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $allowed_actions = [

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'edit',
        'view',
        'ItemEditForm'
    ];

    public function ItemEditForm()
    {
        $form = parent::ItemEditForm();

        if (!$this->record->ID) {
            return $form;
        }

        $formActions = $form->Actions();

        if ($actions = $this->record->getCMSActions()) {
            foreach ($actions as $action) {
                $formActions->push($action);
            }
        }

        return $form;
    }

    /**
     * Handles responses from the MailChimp API.
     *
     * @param MailChimp $mailChimp
     * @return Array
     */
    public function handleMailChimpResponse($mailChimp)
    {
        $response = $mailChimp->getLastResponse();

        if (!$mailChimp->success()) {

This code seems to be duplicated across your project.

            $message = $response && array_key_exists($response['errors'])

The expression $response of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                ? $response['errors'][0]['message']
                : 'Error connecting to MailChimp API';

            user_error($message, E_USER_ERROR);
        }

        return Convert::json2array($response['body']);
    }

    /**
     * Creates a MailChimp campaign via the API.
     *
     * @param MailChimp $mailChimp
     * @return Array
     */
    public function createCampaign($mailChimp)
    {
        $mailChimp->post('campaigns', [
          'type' => 'regular',
          'settings' => [
            'subject_line' => $this->record->Title,
            'from_name' => $this->record->FromName,
            'reply_to' => $this->record->ReplyTo,
          ],
        ]);

        return $this->handleMailChimpResponse($mailChimp);
    }

    /**
     * Populates a MailChimp Campaign with Blog content via the API.
     *
     * @param MailChimp $mailChimp
     * @param Int $campaignID
     * @return Array
     */
    public function populateCampaignContent($mailChimp, $campaignID)
    {
        $mailChimp->put("campaigns/{$campaignID}/content", [
            'template' => [
                'id' => $this->record->TemplateID,
                'sections' => [
                    'chimpify' => $this->record->getCampaignContent(),
                ],
            ],
        ]);

        return $this->handleMailChimpResponse($mailChimp);
    }

    /**
     * Creates and populates a MailChimp Campaign with blog content via the API.
     *
     * @param Array $data
     * @param Form $form
     */
    public function doGenerateCampaign($data, $form)

The parameter $data is not used and could be removed.

    {
        if (!$api_key = $this->record->config()->get('api_key')) {
            user_error(
                'Add a MailChimp API key to config (ChimpifyCampaign::api_key)',
                E_USER_ERROR
            );
        }

        $controller = $this->getToplevelController();

        if (!$this->record || !$this->record->canEdit()) {
            return $controller->httpError(403);
        }

        $form->validate();

        $mailChimp = new MailChimp($api_key);

        $response = $this->createCampaign($mailChimp);
        $response = $this->populateCampaignContent($mailChimp, $response['id']);

$response is not used, you could remove the assignment.

        $form->sessionMessage(
            _t(
                'Chimpify.MessageGenerateCampaignSuccess',
                'Successfully created MailChimp Campaign'
            ),
            'good'
        );

        return $controller->redirectBack();
    }
}