ChimpifyCampaign

Complexity

Total Complexity

12

Size/Duplication

Total Lines	166
Duplicated Lines	4.22 %

Coupling/Cohesion

Components	1
Dependencies	15

Test Coverage

Coverage

16.48%

Importance

Changes	6
Bugs	2	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
B	getCMSFields()	0	77	3
A	getCMSActions()	0	15	1
A	getCMSValidator()	0	6	1
B	getMailChimpTemplates()	7	23	6
A	getCampaignContent()	0	4	1

<?php

use \DrewM\MailChimp\MailChimp;

class ChimpifyCampaign extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $api_key;

The property $api_key is not used and could be removed.

    private static $db = [

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'Title' => 'Varchar',
        'FromName' => 'Varchar',
        'ReplyTo' => 'Varchar',
        'TemplateID' => 'Int',
        'Intro' => 'Text',
        'ItemLimit' => 'Int',
    ];

    private static $many_many = [

Consider using a different property name as you override a private property of the parent class.

The property $many_many is not used and could be removed.

        'ContentSources' => 'Blog',
    ];

    private static $defaults = [

Consider using a different property name as you override a private property of the parent class.

The property $defaults is not used and could be removed.

        'ItemLimit' => 3,
    ];

    private static $singular_name = 'MailChimp Campaign';

Consider using a different property name as you override a private property of the parent class.

The property $singular_name is not used and could be removed.

    private static $plural_name = 'MailChimp Campaigns';

Consider using a different property name as you override a private property of the parent class.

The property $plural_name is not used and could be removed.

    public function getCMSFields()
    {
        if (!$api_key = $this->config()->get('api_key')) {
            user_error(
                'Add a MailChimp API key to config (ChimpifyCampaign::api_key)',
                E_USER_ERROR
            );
        }

        $fields = parent::getCMSFields();

        $fields->removeByName('ItemLimit');
        $fields->removeByName('ContentSources');

        $mailChimp = new MailChimp($api_key);

        $fields->addFieldsToTab(
            'Root.Main',
            [
                TextField::create(
                    'Title',
                    _t('Chimpify.FieldLabelSubjectLine', 'Subject line')
                ),
                TextField::create(
                    'FromName',
                    _t('Chimpify.FieldLabelFromName', 'From name')
                ),
                EmailField::create(
                    'ReplyTo',
                    _t('Chimpify.FieldLabelReplyTo', 'Reply to email address')
                ),
                DropdownField::create(
                    'TemplateID',
                    _t('Chimpify.FieldLabelMailChimpTemplate', 'MailChimp template'),
                    $this->getMailChimpTemplates($mailChimp)->map('id', 'name'))
                    ->setEmptyString(
                        _t('Chimpify.FieldPlaceholderMailChimpTemplate', 'Select...')
                    ),
                TextareaField::create(
                    'Intro',
                    _t('Chimpify.FieldLabelIntro', 'Introduction'))
                    ->setDescription(_t(
                        'Chimpify.FieldDescriptionIntro',
                        'Dispayled above the list of Blog posts.'
                    )),
            ]
        );

        if ($this->ID) {
            $sourcesConfig = GridFieldConfig_RelationEditor::create();
            $sourcesConfig->removeComponentsByType('GridFieldEditButton');
            $sourcesConfig->removeComponentsByType('GridFieldAddNewButton');

            $fields->addFieldsToTab(
                'Root.Main',
                [
                    GridField::create(
                        'ContentSources',
                        _t('Chimpify.FieldLabelContentSources', 'Content sources'),
                        $this->ContentSources(),

The method ContentSources does not exist on object<ChimpifyCampaign>? Since you implemented __call, maybe consider adding a @method annotation.

                        $sourcesConfig
                    ),
                    NumericField::create(
                        'ItemLimit',
                        _t('Chimpify.FieldLabelItemLimit', 'Number of posts'))
                        ->setDescription(_t(
                            'Chimpify.FieldDescriptionItemLimit',
                            'The number of posts to display from each content source.'
                        )),
                ]
            );
        }

        $this->extend('updateCMSFields', $fields);

        return $fields;
    }

    public function getCMSActions()
    {
        $actions = parent::getCMSActions();

        $actions->push(
            FormAction::create(
                'doGenerateCampaign',
                _t('Chimpify.ButtonLabelGenerateCampaign', 'Create in MailChimp')
            )
        );

        $this->extend('updateCMSActions', $actions);

        return $actions;
    }

    public function getCMSValidator()
    {
        return new RequiredFields(
            'Title', 'FromName', 'ReplyTo', 'TemplateID', 'Intro', 'ItemLimit'
        );
    }

    /**
     * Fetches a list of email templates from MailChimp.
     *
     * @param MailChimp $mailChimp
     * @return ArrayList
     */
    public function getMailChimpTemplates($mailChimp)
    {
        $templates = ArrayList::create();
        $response = $mailChimp->get('templates');

        if (!$mailChimp->success()) {

This code seems to be duplicated across your project.

            $message = $response && array_key_exists($response['errors'])
                ? $response['errors'][0]['message']
                : 'Error connecting to MailChimp API';

            user_error($message, E_USER_ERROR);
        }

        foreach ($response['templates'] as $template) {
            if ($template['type'] == 'user') {
                $templates->push(ArrayData::create($template));
            }
        }

        $this->extend('updateMailChimpTemplates', $templates);

        return $templates;
    }

    /**
     * Generates HTML from ContentSources.
     *
     * @return String
     */
    public function getCampaignContent()
    {
        return $this->renderWith('ChimpifyCampaignContent')->Value;
    }
}