SQLUpdate::execute() - Code Metrics - Inspection of "removing unecessary constructors" - SoftboxLab/php-persistence - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 519cfb...a79a93 )

by Nielsen

created 2017-03-01 16:59 UTC

SQLUpdate::execute() A

↳ Parent: SQLUpdate

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	9
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	9
loc	9
ccs	0
cts	6
cp	0
rs	9.6666
c	1
b	0
f	0
cc	2
eloc	6
nc	2
nop	0
crap	6

<?php

namespace Softbox\Persistence\Core\SQL\Command;

use Softbox\Persistence\Core\SQL\Builder\SQLConverter;
use Softbox\Persistence\Core\SQL\PersistenceService;
use Softbox\Persistence\Core\UpdateBase;

/**
 * Class that represents the UPDATE SQL command
 *
 * @package Softbox\Persistence\Core\SQL\Command
 */
class SQLUpdate extends UpdateBase {

    private function getParams() {
        $filter = $this->getFilter();
        return $filter ? $filter->getParams() : [];
    }

    /**
     * Return only the values that exists on table
     *
     * @return array [[Col => New Value] .. ]
     */
    public function getTableValues() {

        $cols = $this->persistence->getColsOfTable($this->getEntity());
        $values = [];
        foreach ($this->getValues() as $col => $val) {
            if (in_array($col, $cols)) {
                $values[$col] = $val;
            }
        }

        return $values;
    }

    public function execute() {

        $values = $this->getTableValues();
        if (empty($values)) {
            throw new SQLException("There are no values to be updated.");
        }
        $sql = $this->build(new SQLConverter());

        return $this->persistence->exec($sql, array_merge($values, $this->getParams()));
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1		<?php
2
3		namespace Softbox\Persistence\Core\SQL\Command;
4
5		use Softbox\Persistence\Core\SQL\Builder\SQLConverter;
6		use Softbox\Persistence\Core\SQL\PersistenceService;
7		use Softbox\Persistence\Core\UpdateBase;
8
9		/**
10		* Class that represents the UPDATE SQL command
11		*
12		* @package Softbox\Persistence\Core\SQL\Command
13		*/
14		class SQLUpdate extends UpdateBase {
15
16		private function getParams() {
17		$filter = $this->getFilter();
18		return $filter ? $filter->getParams() : [];
19		}
20
21		/**
22		* Return only the values that exists on table
23		*
24		* @return array [[Col => New Value] .. ]
25		*/
26	View Code Duplication	public function getTableValues() {
		0 ignored issues – show Duplication introduced 2017-03-01 00:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		$cols = $this->persistence->getColsOfTable($this->getEntity());
28		$values = [];
29		foreach ($this->getValues() as $col => $val) {
30		if (in_array($col, $cols)) {
31		$values[$col] = $val;
32		}
33		}
34
35		return $values;
36		}
37
38	View Code Duplication	public function execute() {
		0 ignored issues – show Duplication introduced 2017-03-01 00:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
39		$values = $this->getTableValues();
40		if (empty($values)) {
41		throw new SQLException("There are no values to be updated.");
42		}
43		$sql = $this->build(new SQLConverter());
44
45		return $this->persistence->exec($sql, array_merge($values, $this->getParams()));
		0 ignored issues – show Bug Best Practice introduced 2017-03-01 00:59 UTC by Report Bug Copy Issue Report The return type of `return $this->persistenc..., $this->getParams()));` (`array`) is incompatible with the return type declared by the interface `Softbox\Persistence\Core...mand\Updatable::execute` of type `integer`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
46		}
47		}
48

SoftboxLab / php-persistence

Push — master ( 519cfb...a79a93 )

SQLUpdate::execute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like