AbstractProvider::parseAccessToken() - Code Metrics - Inspection of "Remove deprecated method `getAccessToken`" - SocialiteProviders/Manager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 43f209...d4d820 )

by Brian

created 2016-06-03 17:54 UTC

AbstractProvider::parseAccessToken() A

↳ Parent: AbstractProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	4
ccs	0
cts	1
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php

namespace SocialiteProviders\Manager\OAuth2;

use Illuminate\Support\Arr;
use GuzzleHttp\ClientInterface;
use Laravel\Socialite\Two\InvalidStateException;
use SocialiteProviders\Manager\Contracts\OAuth2\ProviderInterface;
use SocialiteProviders\Manager\SocialiteWasCalled;
use SocialiteProviders\Manager\ConfigTrait;
use Laravel\Socialite\Two\AbstractProvider as BaseProvider;

abstract class AbstractProvider extends BaseProvider implements ProviderInterface
{
    use ConfigTrait;

    /**
     * @var array
     */
    protected $credentialsResponseBody;

    public static function serviceContainerKey($providerName)
    {
        return SocialiteWasCalled::SERVICE_CONTAINER_PREFIX.$providerName;
    }

    /**
     * @return \SocialiteProviders\Manager\OAuth2\User
     */
    public function user()
    {
        if ($this->hasInvalidState()) {
            throw new InvalidStateException();
        }

        $response = $this->getAccessTokenResponse($this->getCode());


        $user = $this->mapUserToObject($this->getUserByToken(
            $token = $this->parseAccessToken($response)
        ));

        $this->credentialsResponseBody = $response;

        if ($user instanceof User) {
            return $user->setAccessTokenResponseBody($this->credentialsResponseBody);
        }

        return $user->setToken($token)

                    ->setRefreshToken(Arr::get($response, 'refresh_token'))
                    ->setExpiresIn(Arr::get($response, 'expires_in'));
    }

    /**
     * Get the access token from the token response body.
     *
     * @param string $body
     *
     * @return string
     */
    protected function parseAccessToken($body)
    {
        return Arr::get($body, 'access_token');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2
3		namespace SocialiteProviders\Manager\OAuth2;
4
5		use Illuminate\Support\Arr;
6		use GuzzleHttp\ClientInterface;
7		use Laravel\Socialite\Two\InvalidStateException;
8		use SocialiteProviders\Manager\Contracts\OAuth2\ProviderInterface;
9		use SocialiteProviders\Manager\SocialiteWasCalled;
10		use SocialiteProviders\Manager\ConfigTrait;
11		use Laravel\Socialite\Two\AbstractProvider as BaseProvider;
12
13		abstract class AbstractProvider extends BaseProvider implements ProviderInterface
14		{
15		use ConfigTrait;
16
17		/**
18	1	* @var array
19		*/
20	1	protected $credentialsResponseBody;
21
22		public static function serviceContainerKey($providerName)
23	7	{
24		return SocialiteWasCalled::SERVICE_CONTAINER_PREFIX.$providerName;
25	7	}
26
27		/**
28		* @return \SocialiteProviders\Manager\OAuth2\User
29		*/
30		public function user()
31		{
32		if ($this->hasInvalidState()) {
33	1	throw new InvalidStateException();
34		}
35	1
36	1	$response = $this->getAccessTokenResponse($this->getCode());
		0 ignored issues – show Bug introduced 2016-06-03 18:00 UTC by Report Bug Copy Issue Report The method `getAccessTokenResponse()` does not exist on `SocialiteProviders\Manager\OAuth2\AbstractProvider`. Did you maybe mean `getAccessToken()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
37	1
38	1	$user = $this->mapUserToObject($this->getUserByToken(
39		$token = $this->parseAccessToken($response)
40	1	));
41
42		$this->credentialsResponseBody = $response;
43
44		if ($user instanceof User) {
45		return $user->setAccessTokenResponseBody($this->credentialsResponseBody);
46	5	}
47
48	5	return $user->setToken($token)
		0 ignored issues – show Bug introduced 2016-06-03 18:00 UTC by Report Bug Copy Issue Report The method `setRefreshToken()` does not seem to exist on `object<Laravel\Socialite\Two\User>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
49	2	->setRefreshToken(Arr::get($response, 'refresh_token'))
50		->setExpiresIn(Arr::get($response, 'expires_in'));
51		}
52	3
53	3	/**
54	3	* Get the access token from the token response body.
55		*
56	3	* @param string $body
57		*
58	3	* @return string
59	3	*/
60		protected function parseAccessToken($body)
61		{
62		return Arr::get($body, 'access_token');
		0 ignored issues – show Documentation introduced 2016-06-03 18:00 UTC by Report Bug Copy Issue Report `$body` is of type `string`, but the function expects a `object<ArrayAccess>\|array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
63		}
64		}
65

SocialiteProviders / Manager

Push — master ( 43f209...d4d820 )

AbstractProvider::parseAccessToken() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like