Tumblr::getIdentity() - Code Metrics - Inspection of "Replace get/setSex with get/setGender" - SocialConnect/auth - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — heiglandreas-patch-1 ( 8f4377 )

by Andreas

created 2019-09-15 16:48 UTC

Tumblr::getIdentity() A

↳ Parent: Tumblr

Complexity

Conditions	3
Paths	2

Size

Total Lines	22
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	11
nc	2
nop	1
dl	0
loc	22
ccs	0
cts	12
cp	0
crap	12
rs	9.9
c	1
b	0
f	0

<?php
/**
 * SocialConnect project
 * @author: Patsura Dmitry https://github.com/ovr <[email protected]>
 */
declare(strict_types=1);

namespace SocialConnect\OAuth1\Provider;

use SocialConnect\Common\ArrayHydrator;
use SocialConnect\Provider\AccessTokenInterface;
use SocialConnect\Provider\Exception\InvalidResponse;
use SocialConnect\OAuth1\AbstractProvider;
use SocialConnect\Common\Entity\User;
filter:
    dependency_paths: ["lib/*"]

class Tumblr extends AbstractProvider
{
    const NAME = 'tumblr';

    /**
     * {@inheritdoc}
     */
    public function getBaseUri()
    {
        return 'https://api.tumblr.com/v2/';
    }

    /**
     * {@inheritdoc}
     */
    public function getAuthorizeUri()
    {
        return 'https://www.tumblr.com/oauth/authorize';
    }

    /**
     * {@inheritdoc}
     */
    public function getRequestTokenUri()
    {
        return 'https://www.tumblr.com/oauth/request_token';
    }

    /**
     * @return string
     */
    public function getRequestTokenAccessUri()
    {
        return 'https://www.tumblr.com/oauth/access_token';
    }


    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return self::NAME;
    }

    /**
     * {@inheritdoc}
     */
    public function getIdentity(AccessTokenInterface $accessToken)
    {
        $this->consumerToken = $accessToken;


        $result = $this->request(
            'GET',
            'user/info',
            [],
            $accessToken
        );

        if (!isset($result['response'], $result['response']['user']) || !$result['response']['user']) {
            throw new InvalidResponse(
                'API response without user inside JSON'
            );
        }

        $hydrator = new ArrayHydrator([
            'name' => 'id'
        ]);

        return $hydrator->hydrate(new User(), $result['response']['user']);
    }
}


1		<?php
2		/**
3		* SocialConnect project
4		* @author: Patsura Dmitry https://github.com/ovr <[email protected]>
5		*/
6		declare(strict_types=1);
7
8		namespace SocialConnect\OAuth1\Provider;
9
10		use SocialConnect\Common\ArrayHydrator;
11		use SocialConnect\Provider\AccessTokenInterface;
12		use SocialConnect\Provider\Exception\InvalidResponse;
13		use SocialConnect\OAuth1\AbstractProvider;
14		use SocialConnect\Common\Entity\User;
		0 ignored issues – show Bug introduced 2019-09-15 16:52 UTC by Report Bug Copy Issue Report The type `SocialConnect\Common\Entity\User` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
15
16		class Tumblr extends AbstractProvider
17		{
18		const NAME = 'tumblr';
19
20		/**
21		* {@inheritdoc}
22		*/
23	1	public function getBaseUri()
24		{
25	1	return 'https://api.tumblr.com/v2/';
26		}
27
28		/**
29		* {@inheritdoc}
30		*/
31	1	public function getAuthorizeUri()
32		{
33	1	return 'https://www.tumblr.com/oauth/authorize';
34		}
35
36		/**
37		* {@inheritdoc}
38		*/
39	1	public function getRequestTokenUri()
40		{
41	1	return 'https://www.tumblr.com/oauth/request_token';
42		}
43
44		/**
45		* @return string
46		*/
47	1	public function getRequestTokenAccessUri()
48		{
49	1	return 'https://www.tumblr.com/oauth/access_token';
50		}
51
52
53		/**
54		* {@inheritdoc}
55		*/
56	1	public function getName()
57		{
58	1	return self::NAME;
59		}
60
61		/**
62		* {@inheritdoc}
63		*/
64		public function getIdentity(AccessTokenInterface $accessToken)
65		{
66		$this->consumerToken = $accessToken;
		0 ignored issues – show Documentation Bug introduced 2019-07-15 21:15 UTC by Report Bug Copy Issue Report It seems like `$accessToken` of type `SocialConnect\Provider\AccessTokenInterface` is incompatible with the declared type `SocialConnect\OAuth1\Token` of property `$consumerToken`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
67
68		$result = $this->request(
69		'GET',
70		'user/info',
71		[],
72		$accessToken
73		);
74
75		if (!isset($result['response'], $result['response']['user']) \|\| !$result['response']['user']) {
76		throw new InvalidResponse(
77		'API response without user inside JSON'
78		);
79		}
80
81		$hydrator = new ArrayHydrator([
82		'name' => 'id'
83		]);
84
85		return $hydrator->hydrate(new User(), $result['response']['user']);
86		}
87		}
88

SocialConnect / auth

Push — heiglandreas-patch-1 ( 8f4377 )

Tumblr::getIdentity() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like