Trello::getIdentity() - Code Metrics - Inspection of "Replace get/setSex with get/setGender" - SocialConnect/auth - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — heiglandreas-patch-1 ( 8f4377 )

by Andreas

created 2019-09-15 16:48 UTC

Trello::getIdentity() A

↳ Parent: Trello

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	1
eloc	12
nc	1
nop	1
dl	0
loc	21
ccs	0
cts	10
cp	0
crap	2
rs	9.8666
c	2
b	0
f	0

<?php
/**
 * SocialConnect project
 * @author: Patsura Dmitry https://github.com/ovr <[email protected]>
 */
declare(strict_types=1);

namespace SocialConnect\OAuth1\Provider;

use SocialConnect\Common\ArrayHydrator;
use SocialConnect\Provider\AccessTokenInterface;
use SocialConnect\OAuth1\AbstractProvider;
use SocialConnect\Common\Entity\User;
filter:
    dependency_paths: ["lib/*"]

class Trello extends AbstractProvider
{
    const NAME = 'trello';

    /**
     * {@inheritdoc}
     */
    public function getBaseUri()
    {
        return 'https://api.trello.com/1/';
    }

    /**
     * {@inheritdoc}
     */
    public function getAuthorizeUri()
    {
        return 'https://trello.com/1/OAuthAuthorizeToken';
    }

    /**
     * {@inheritdoc}
     */
    public function getRequestTokenUri()
    {
        return 'https://trello.com/1/OAuthGetRequestToken';
    }

    /**
     * @return string
     */
    public function getRequestTokenAccessUri()
    {
        return 'https://trello.com/1/OAuthGetAccessToken';
    }


    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return self::NAME;
    }

    /**
     * {@inheritdoc}
     */
    public function getIdentity(AccessTokenInterface $accessToken)
    {
        $this->consumerToken = $accessToken;


        $parameters = [
            'key' => $this->consumer->getKey(),
            'token' => $accessToken->getToken()
        ];

        $result = $this->request(
            'GET',
            'members/me',
            $parameters
        );

        $hydrator = new ArrayHydrator([
            'avatarUrl' => 'pictureURL',
            'fullName' => 'fullname',
        ]);

        return $hydrator->hydrate(new User(), $result);
    }
}


1		<?php
2		/**
3		* SocialConnect project
4		* @author: Patsura Dmitry https://github.com/ovr <[email protected]>
5		*/
6		declare(strict_types=1);
7
8		namespace SocialConnect\OAuth1\Provider;
9
10		use SocialConnect\Common\ArrayHydrator;
11		use SocialConnect\Provider\AccessTokenInterface;
12		use SocialConnect\OAuth1\AbstractProvider;
13		use SocialConnect\Common\Entity\User;
		0 ignored issues – show Bug introduced 2019-09-15 16:52 UTC by Report Bug Copy Issue Report The type `SocialConnect\Common\Entity\User` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
14
15		class Trello extends AbstractProvider
16		{
17		const NAME = 'trello';
18
19		/**
20		* {@inheritdoc}
21		*/
22	1	public function getBaseUri()
23		{
24	1	return 'https://api.trello.com/1/';
25		}
26
27		/**
28		* {@inheritdoc}
29		*/
30	1	public function getAuthorizeUri()
31		{
32	1	return 'https://trello.com/1/OAuthAuthorizeToken';
33		}
34
35		/**
36		* {@inheritdoc}
37		*/
38	1	public function getRequestTokenUri()
39		{
40	1	return 'https://trello.com/1/OAuthGetRequestToken';
41		}
42
43		/**
44		* @return string
45		*/
46	1	public function getRequestTokenAccessUri()
47		{
48	1	return 'https://trello.com/1/OAuthGetAccessToken';
49		}
50
51
52		/**
53		* {@inheritdoc}
54		*/
55	1	public function getName()
56		{
57	1	return self::NAME;
58		}
59
60		/**
61		* {@inheritdoc}
62		*/
63		public function getIdentity(AccessTokenInterface $accessToken)
64		{
65		$this->consumerToken = $accessToken;
		0 ignored issues – show Documentation Bug introduced 2019-07-15 21:15 UTC by Report Bug Copy Issue Report It seems like `$accessToken` of type `SocialConnect\Provider\AccessTokenInterface` is incompatible with the declared type `SocialConnect\OAuth1\Token` of property `$consumerToken`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
66
67		$parameters = [
68		'key' => $this->consumer->getKey(),
69		'token' => $accessToken->getToken()
70		];
71
72		$result = $this->request(
73		'GET',
74		'members/me',
75		$parameters
76		);
77
78		$hydrator = new ArrayHydrator([
79		'avatarUrl' => 'pictureURL',
80		'fullName' => 'fullname',
81		]);
82
83		return $hydrator->hydrate(new User(), $result);
84		}
85		}
86

SocialConnect / auth

Push — heiglandreas-patch-1 ( 8f4377 )

Trello::getIdentity() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like