User - Code Metrics - Inspection of "Replace get/setSex with get/setGender" - SocialConnect/auth - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — heiglandreas-patch-1 ( 8f4377 )

by Andreas

created 2019-09-15 16:48 UTC

User A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	91
Duplicated Lines	0 %

Test Coverage

Coverage

45.45%

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	19
c	2
b	0
f	0
dl	0
loc	91
ccs	5
cts	11
cp	0.4545
rs	10
wmc	6

<?php
/**
 * SocialConnect project
 * @author: Patsura Dmitry @ovr <[email protected]>
 */

namespace SocialConnect\Common\Entity;

class User extends \stdClass
{
    const GENDER_MALE = 'male';
    const GENDER_FEMALE = 'female';
    const GENDER_OTHER = 'other';
    const GENDER_UNKNOWN = 'unknown';

    /**
     * @var string
     */
    public $id;

    /**
     * @var string
     */
    public $firstname;

    /**
     * @var string
     */
    public $lastname;

    /**
     * @var string
     */
    public $email;

    /**
     * @var bool
     */
    public $emailVerified = false;

    /**
     * @var \DateTime|null
     */
    protected $birthday;

    /**
     * @var string|null
     */
    public $username;

    /**
     * One of the GENDER_-constants
     *
     * @var string
     */
    protected $gender = GENDER_UNKNOWN;

    /**
     * @var string|null
     */
    public $fullname;

    /**
     * @var string|null
     */
    public $pictureURL;

    /**
     * @return \DateTime|null
     */
    public function getBirthday(): ?\DateTime
    {
        return $this->birthday;
    }

    /**
     * @param \DateTime|null $birthday
     */
    public function setBirthday(?\DateTime $birthday): void
    {
        $this->birthday = $birthday;
    }

    /**
     * @return string
     */
    public function getGender(): string
    {
        return $this->gender;
    }

    /**
     * @param string $sex
     */
    public function setGender(string $gender): void
    {
        $genders = [
            GENDER_OTHER,
            GENDER_MALE,
            GENDER_FEMALE,
        ];
        if (! $gender in_array($genders)) {

            throw new \InvalidArgumentException('Argument $gender is not valid');
        }

        $this->gender = $gender;
    }
    
    /**
     * @deprecated use `getGender` instead
     */
    public function getSex() : string
    {
        return $this->getGender();
    }
    
    /**
     * @deprecated Use setGender instead
     */
    public function setSex(string $sex) : void
    {
        $this->setGender($sex);
    }
}


1			<?php
2			/**
3			* SocialConnect project
4			* @author: Patsura Dmitry @ovr <[email protected]>
5			*/
6
7			namespace SocialConnect\Common\Entity;
8
9			class User extends \stdClass
10			{
11			const GENDER_MALE = 'male';
12			const GENDER_FEMALE = 'female';
13			const GENDER_OTHER = 'other';
14			const GENDER_UNKNOWN = 'unknown';
15
16			/**
17			* @var string
18			*/
19			public $id;
20
21			/**
22			* @var string
23			*/
24			public $firstname;
25
26			/**
27			* @var string
28			*/
29			public $lastname;
30
31			/**
32			* @var string
33			*/
34			public $email;
35
36			/**
37			* @var bool
38			*/
39			public $emailVerified = false;
40
41			/**
42			* @var \DateTime\|null
43			*/
44			protected $birthday;
45
46			/**
47			* @var string\|null
48			*/
49			public $username;
50
51			/**
52			* One of the GENDER_-constants
53			*
54			* @var string
55			*/
56			protected $gender = GENDER_UNKNOWN;
57
58			/**
59			* @var string\|null
60			*/
61			public $fullname;
62
63			/**
64			* @var string\|null
65			*/
66			public $pictureURL;
67
68			/**
69			* @return \DateTime\|null
70			*/
71			public function getBirthday(): ?\DateTime
72			{
73			return $this->birthday;
74			}
75
76			/**
77			* @param \DateTime\|null $birthday
78			*/
79			public function setBirthday(?\DateTime $birthday): void
80			{
81			$this->birthday = $birthday;
82			}
83
84			/**
85			* @return string
86			*/
87			public function getGender(): string
88			{
89			return $this->gender;
90			}
91
92			/**
93			* @param string $sex
94			*/
95			public function setGender(string $gender): void
96			{
97			$genders = [
98			GENDER_OTHER,
99			GENDER_MALE,
100			GENDER_FEMALE,
101			];
102			if (! $gender in_array($genders)) {
			0 ignored issues – show Bug introduced 2019-09-15 16:52 UTC by Report Bug Copy Issue Report A parse error occurred: Syntax error, unexpected T_STRING on line 102 at column 22 Loading history...
103			throw new \InvalidArgumentException('Argument $gender is not valid');
104			}
105
106			$this->gender = $gender;
107			}
108
109			/**
110			* @deprecated use `getGender` instead
111			*/
112			public function getSex() : string
113			{
114			return $this->getGender();
115			}
116
117			/**
118			* @deprecated Use setGender instead
119			*/
120			public function setSex(string $sex) : void
121			{
122			$this->setGender($sex);
123			}
124			}
125

SocialConnect / auth

Push — heiglandreas-patch-1 ( 8f4377 )

User A

Complexity

Size/Duplication

Test Coverage

Importance

Duplication Side-by-Side

Filter issues like