SocialConnect\OAuth1\Util

Complexity

Total Complexity

10

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Test Coverage

Coverage

70.37%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	urldecodeRFC3986()	0	3	1
A	buildHttpQuery()	0	33	5
A	urlencodeRFC3986()	0	19	4

<?php
/**
 * SocialConnect project
 * @author: Patsura Dmitry https://github.com/ovr <talk@dmtry.me>
 */
declare(strict_types=1);

namespace SocialConnect\OAuth1;

class Util
{
    /**
     * @param mixed $input
     * @return array|string
     */
    public static function urlencodeRFC3986($input)
    {
        if (is_int($input)) {
            return (string) $input;
        }

        if (is_array($input)) {
            return array_map(array(
                __NAMESPACE__ . '\Util',
                'urlencodeRFC3986'
            ), $input);
        }

        if (is_scalar($input)) {
            return rawurlencode($input);
        }

        $type = gettype($input);
        throw new \InvalidArgumentException("Unsupported type: {$type}");
    }

    /**
     * This decode function isn't taking into consideration the above
     * modifications to the encoding process. However, this method doesn't
     * seem to be used anywhere so leaving it as is.
     *
     * @param string $string
     * @return string
     */
    public static function urldecodeRFC3986($string)
    {
        return urldecode($string);
    }

    /**
     * @param array $params
     * @return string
     */
    public static function buildHttpQuery(array $params)
    {
        if (!$params) {

The expression $params of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return '';
        }

        $keys   = self::urlencodeRFC3986(array_keys($params));
        $values = self::urlencodeRFC3986(array_values($params));
        $params = array_combine($keys, $values);

        // Parameters are sorted by name, using lexicographical byte value ordering.
        // Ref: Spec: 9.1.1 (1)
        uksort($params, 'strcmp');

It seems like $params can also be of type false; however, parameter $array of uksort() does only seem to accept array, maybe add an additional type check?

        $pairs = [];

        foreach ($params as $parameter => $value) {
            if (is_array($value)) {
                // If two or more parameters share the same name, they are sorted by their value
                // Ref: Spec: 9.1.1 (1)
                // June 12th, 2010 - changed to sort because of issue 164 by hidetaka
                sort($value, SORT_STRING);
                foreach ($value as $duplicate_value) {
                    $pairs[] = $parameter . '=' . $duplicate_value;
                }
            } else {
                $pairs[] = $parameter . '=' . $value;
            }
        }

        // For each parameter, the name is separated from the corresponding value by an '=' character (ASCII code 61)
        // Each name-value pair is separated by an '&' character (ASCII code 38)
        return implode('&', $pairs);
    }
}