Issues in Range.php (master) - Issues in master - Smoren/sequence-php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (19)

src/Structs/Range.php (2 issues)

Labels

Severity

Major 2

<?php

declare(strict_types=1);

namespace Smoren\Sequence\Structs;

/**
 * Range sequence.
 *
 * @template T of int|float
 * @extends StepSequence<T>
 */
class Range extends StepSequence
{
    /**
     * Range constructor.
     *
     * @param T $start start of the range
     * @param int<0, max>|null $size size of the range (infinite if null)
     * @param T $step range step
filter:
    dependency_paths: ["lib/*"]
     */
    public function __construct($start, ?int $size, $step)
    {
        parent::__construct($start, $size, $step);
    }

    /**
     * {@inheritDoc}
     */
    public function getValueByIndex(int $index)
    {
        return $this->start + $index * $this->step;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    /**
     * {@inheritDoc}
     */
    public function getNextValue($previousValue)
    {
        return $previousValue + $this->step;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Smoren\Sequence\Structs;
6
7		/**
8		* Range sequence.
9		*
10		* @template T of int\|float
11		* @extends StepSequence<T>
12		*/
13		class Range extends StepSequence
14		{
15		/**
16		* Range constructor.
17		*
18		* @param T $start start of the range
19		* @param int<0, max>\|null $size size of the range (infinite if null)
20		* @param T $step range step
		0 ignored issues – show Bug introduced 2022-12-29 12:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `Smoren\Sequence\Structs\T` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
21		*/
22	52	public function __construct($start, ?int $size, $step)
23		{
24	52	parent::__construct($start, $size, $step);
25		}
26
27		/**
28		* {@inheritDoc}
29		*/
30	36	public function getValueByIndex(int $index)
31		{
32	36	return $this->start + $index * $this->step;
		0 ignored issues – show Bug Best Practice introduced 2022-12-29 11:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $this->start + $index * $this->step` returns the type `integer` which is incompatible with the return type mandated by `Smoren\Sequence\Interfac...face::getValueByIndex()` of `Smoren\Sequence\Interfaces\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
33		}
34
35		/**
36		* {@inheritDoc}
37		*/
38	25	public function getNextValue($previousValue)
39		{
40	25	return $previousValue + $this->step;
41		}
42		}
43

Smoren / sequence-php

Issues (19)

src/Structs/Range.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like