Range::getValueByIndex() - Code Metrics - Inspection of "in progress" - Smoren/sequence-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e4531b...a6f95b )

by Smoren

created 2022-12-29 11:14 UTC

Range::getValueByIndex() A

↳ Parent: Range

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	1
c	1
b	0
f	0
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
cc	1
nc	1
nop	1
crap	1

<?php

declare(strict_types=1);

namespace Smoren\Sequence\Structs;

/**
 * @extends StepSequence<int|float>
 */
class Range extends StepSequence
{
    /**
     * @param int $index
     * @return int|float
     */
    public function getValueByIndex(int $index)
    {
        return $this->start + $index * $this->step;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    /**
     * @param int|float $previousValue
     * @return int|float
     */
    public function getNextValue($previousValue)
    {
        return $previousValue + $this->step;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Smoren\Sequence\Structs;
6
7		/**
8		* @extends StepSequence<int\|float>
9		*/
10		class Range extends StepSequence
11		{
12		/**
13		* @param int $index
14		* @return int\|float
15		*/
16	8	public function getValueByIndex(int $index)
17		{
18	8	return $this->start + $index * $this->step;
		0 ignored issues – show Bug Best Practice introduced 2022-12-29 11:17 UTC by Report Bug Copy Issue Report The expression `return $this->start + $index * $this->step` returns the type `integer` which is incompatible with the return type mandated by `Smoren\Sequence\Interfac...face::getValueByIndex()` of `Smoren\Sequence\Interfaces\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
19		}
20
21		/**
22		* @param int\|float $previousValue
23		* @return int\|float
24		*/
25	4	public function getNextValue($previousValue)
26		{
27	4	return $previousValue + $this->step;
		0 ignored issues – show Bug Best Practice introduced 2022-12-29 09:39 UTC by Report Bug Copy Issue Report The expression `return $previousValue + $this->step` returns the type `double` which is incompatible with the return type mandated by `Smoren\Sequence\Interfac...terface::getNextValue()` of `Smoren\Sequence\Interfaces\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
28		}
29		}
30

Smoren / sequence-php

Push — master ( e4531b...a6f95b )

Range::getValueByIndex() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like