Issues in IntSequenceIterator.php - Fixed Issues - Inspection of "in progress" - Smoren/sequence-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8dfa4a...e4531b )

by Smoren

created 2022-12-29 09:37 UTC

src/Iterators/IntSequenceIterator.php (1 issue)

Labels

Severity

Major 1

<?php

declare(strict_types=1);

namespace Smoren\Sequence\Iterators;

use Smoren\Sequence\Interfaces\SequenceIteratorInterface;
use Smoren\Sequence\Structs\IntSequence;
use Smoren\Sequence\Traits\SequenceIteratorTrait;

/**
 * @implements SequenceIteratorInterface<int>
 */
class IntSequenceIterator implements SequenceIteratorInterface
{
    /**
     * @use SequenceIteratorTrait<int>
     */
    use SequenceIteratorTrait;

    /**
     * @var IntSequence
     */
    protected IntSequence $sequence;
    /**
     * @var int
     */
    protected int $currentIndex;

    /**
     * @param IntSequence $range
     */
    public function __construct(IntSequence $range)
    {
        $this->sequence = $range;
        $this->currentIndex = 0;
    }

    /**
     * {@inheritDoc}
     * @return int
     */
    public function current(): int
    {
        return $this->sequence[$this->currentIndex];
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Smoren\Sequence\Iterators;
6
7		use Smoren\Sequence\Interfaces\SequenceIteratorInterface;
8		use Smoren\Sequence\Structs\IntSequence;
9		use Smoren\Sequence\Traits\SequenceIteratorTrait;
10
11		/**
12		* @implements SequenceIteratorInterface<int>
13		*/
14		class IntSequenceIterator implements SequenceIteratorInterface
15		{
16		/**
17		* @use SequenceIteratorTrait<int>
18		*/
19		use SequenceIteratorTrait;
20
21		/**
22		* @var IntSequence
23		*/
24		protected IntSequence $sequence;
25		/**
26		* @var int
27		*/
28		protected int $currentIndex;
29
30		/**
31		* @param IntSequence $range
32		*/
33	7	public function __construct(IntSequence $range)
34		{
35	7	$this->sequence = $range;
36	7	$this->currentIndex = 0;
37		}
38
39		/**
40		* {@inheritDoc}
41		* @return int
42		*/
43	7	public function current(): int
44		{
45	7	return $this->sequence[$this->currentIndex];
		0 ignored issues – show Bug Best Practice introduced 2022-12-24 10:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $this->sequence[$this->currentIndex]` returns the type `integer` which is incompatible with the return type mandated by `Smoren\Sequence\Interfac...torInterface::current()` of `Smoren\Sequence\Interfaces\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
46		}
47		}
48

Smoren / sequence-php

Push — master ( 8dfa4a...e4531b )

src/Iterators/IntSequenceIterator.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like